# Collabora Online Weekly #118

**URL:** <https://forum.collaboraonline.com/t/collabora-online-weekly-118/1794>\
**Category:** Development\
**Tags:** meeting-minutes\
**Created:** [May 5, 2023, 10:26am UTC](https://forum.collaboraonline.com/t/collabora-online-weekly-118/1794 "2023-05-05T10:26:01Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![pedro.silva](https://dub1.discourse-cdn.com/flex013/user_avatar/forum.collaboraonline.com/pedro.silva/32/4_2.png) [@pedro.silva](https://forum.collaboraonline.com/u/pedro.silva)\
**Post date:** [May 5, 2023, 10:26am UTC](https://forum.collaboraonline.com/t/collabora-online-weekly-118/1794/1 "2023-05-05T10:26:02Z")

</div>

Collabora Online Weekly Meeting #118

Date: May 4th 2023

All minutes published on: [Topics tagged meeting-minutes](https://forum.collaboraonline.com/tag/meeting-minutes)

# Attendees (write your name):

- Pedro, Andras, Cosmin, Timur, Thorsten, Mike D, Darshan, Gabriel, Nicolas, Gülşah, Ezinne, Aron, Symon, Gokay, Anna, Michael, Timur, Shehr

# Release schedule (Andras)

### Another bug fix 22.05 ~~next (jenkins problems)~~ this week

- New iOS minor version in ~2 weeks based on 22.05
- 23.05 → snapshots this week then testing
  - Tested internally (in progress)

## Releasability of master (Michael)

- Cypress
  - Gokay hacking on this with Michael here & there.
  - Updating the cypress, next → merge to master branch
    - Fixing cypress dependencies

- UX regressions almost all done → looking lots better.
  - Tab behaviour and some dramatic thing son mobile

- Performance issues still to go → clearly still there; needs more love … =)

# Forum (Mike D)

- [Bad request (using K8s)](https://forum.collaboraonline.com/t/error-400-bad-request-url-too-long/1778) AI: Pedro to mention that to Rash
- 8 question done, some already marked as resolved
  - Also a couple more (old ones and already resolved) tagged with resolved etc

- 32 - zero replies in user support: [User Support - Collabora Online](https://forum.collaboraonline.com/c/user-support/11?ascending=true&order=posts)
- ?? - zero replies in installation and config: [Installation & Configuration - Collabora Online](https://forum.collaboraonline.com/c/installation-configuration/10?ascending=true&order=posts)
  - pointing at commits in some cases where there is a fix …

## Dark mode (Michael)

- New theme configurations as pre-canned config fragments
- All is good, Calc is the last piece here … plus polishing of course
- Andreas K. now helping left and right
  - Great to get help here, some things like dialogs not using that, CSS vars too
  - Some already entered
  - Other still waiting for review

- Darshan will be helping out with JS pieces around dark-mode  
here – pwrt. images path.
  - Have a dark/ sub-directory in images.
  - Have COOL built now (Darshan)
    - working on a Nextcloud build now.

- Nextcloud has four themes – we should probably aim to match that:
  - high contrast dark & light, and dark and light (normal).
  - Having an enumeration like this pushed across  
the iframe + PostMessage update (Michael)
    - will add another field in the UI defaults (Pedro)

# Core activity

- A regressions in core relating to a very complex document (Timur)
  - so far reverted half-baked patches … that cause problems.
  - Miklos looking into this.
  - It seems fixing the comment related bug will impact the others → But more testing is needed (maybe that one patch is enough and there will be no need to apply the reverted again)

- Gabriel (1&1): improvements on ~~placeholders~~ in the document (WIP)
  - something useful for contracts – placeholders for names / addresses etc. for signing.
  - Using bookmarks for this – since you can identify a place uniquely.
  - Can inject a list of texts at a list of positions …
    - via JSON.
    - Could provide it via a parameter to the convert-to end-point for conversion

  - You provide a file: with some bookmarks pre-defined, then you issue the command – inserts for each placeholder, provide a text … injecting inside a frame is desirable – without modifying the layout of the text.
    - Created a UNO command in core -which uses 2x commands – one positions to the bookmark, one inserts the text.

  - There are nice content-controls in 22.05 working.
  - Starting to upgrade now to 22.05.

# Online activity (Pedro)

- Attilla working towards the enablement of navigator on online
  - a WIP gerrit change – Pedro needs to jump on this in a bit.
  - [GH issue with table of controls and their status (ongoing)](https://github.com/CollaboraOnline/online/issues/6248#issuecomment-1531101521)
  - Symon now on this also, and a new PR coming up [Private/aszucs3/navigator2 by aszucs3 · Pull Request #6276 · CollaboraOnline/online · GitHub](https://github.com/CollaboraOnline/online/pull/6276)

- Pull request backlog is growing – what to do about it ?
  - If the tests run locally – you should push without CI passing.

- Szymon
  - is back
  - Keyboard improvements for JSDialogs in (treeviews etC)
  - JSDialog: tab focus fix
  - now conditional format dialog → has a PR but needs to fix JSDialog widgets
    - Generic PR entered
    - conditional format PR still needs some checking

- JSDialog conversion
  - Fix writer dialog now maybe 3 left

- Gokay
  - Working on Cypress with Michael for now
  - Now working on accessibility around comments (keyboard)
    - Writer almost 90%

  - Improving now the keyboard navigation
    - Tabs were converted to button, additional UI polishing is needed

  - Some more work needed (we need to use grid instead of flex), it needs to be tested with integrator
  - Running tests locally – if safe, please push …
  - Also on A11Y Contrast problems

- Gulsah
  - Now will investigate why the scrolling indicator appears on mobile (top-toolbar)
    - Darshan claimed this

  - Claimed Pedro’s task on dropdown arrows problems (on tabbed view) [Tabbed view : Dropdown arrows are misplaced · Issue #6236 · CollaboraOnline/online · GitHub](https://github.com/CollaboraOnline/online/issues/6236) Fixed and merged
  - PR ready: Mobile window size detection [Fix wrong device detection logic. by GulsahKose · Pull Request #6177 · CollaboraOnline/online · GitHub](https://github.com/CollaboraOnline/online/pull/6177)
    - AI: to run mobile cypress tests locally, now merged

  - Now working on
    - [Tabbed view: tabs lose format and style when modalpopup is opened #6275](https://github.com/CollaboraOnline/online/issues/6275)

# Design bits (Pedro and others)

- Pedro
  - fixing regression for 23.05
  - Navigator
  - Dark mode reviews
  - Control reviews

- Andreas K.
  - Mobile regressions
  - Interested in adding more comments (CSS)

Shehr

- Trying to build it now via gitpod
- Pedro: cool, better to build it locally in your ubuntu
  - [Build Collabora Online for Web | Collabora Online - Community Page](https://collaboraonline.github.io/post/build-code/)

# Gabriel (1&1)

- I look into [browser: add last modification timeout setting #4195](https://github.com/CollaboraOnline/online/pull/4195) I will then rebase
- Ash created a [PR to solve those saving issues](https://github.com/CollaboraOnline/online/pull/6167)
  - Cosmin looked at/reviewed that and gave [feedback](https://github.com/CollaboraOnline/online/pull/6167#issuecomment-1527105707) – it works great

## LibreOffice conference (Gabriel)

- A steady climb up the learning curve …
- Waiting on university to see if we can have workshops there to popularize FLOSS
  - spreading the ideas through different means is good.

- Will be in Bucharest – and Gabriel will be organizing it too.
  - [LibreOffice Conference 2023 in Bucharest, Romania - The Document Foundation Blog](https://blog.documentfoundation.org/blog/2023/03/01/libocon-2023-in-bucharest/)
  - Call for papers went out
  - Registration is now open

# Next meeting

[maybe it will be skipped, to be confirmed] 11/05/2023