# Status report: consultancy team, week 4, 2024 **URL:** \ **Category:** Status reports\ **Created:** [January 29, 2024, 1:31pm UTC](https://forum.collaboraonline.com/t/status-report-consultancy-team-week-4-2024/2352 "2024-01-29T13:31:15Z")\ **Posts on this page:** 1\ **Page:** 1
**Author:** ![vmiklos](https://dub1.discourse-cdn.com/flex013/user_avatar/forum.collaboraonline.com/vmiklos/32/787_2.png) [@vmiklos](https://forum.collaboraonline.com/u/vmiklos)\ **Post date:** [January 29, 2024, 1:31pm UTC](https://forum.collaboraonline.com/t/status-report-consultancy-team-week-4-2024/2352/1 "2024-01-29T13:31:15Z")
# Caolan - sheet wide invalidation improvements - invalidation rects getting merged to make mega rect - add saltextenc to preloadData - oversized invalidation rects on joining calc doc - some FOSDEM WASM prep with thb - chase what happens to viewid in writer on changing various settings that affect the rendering options to see how things get synced or how the views are considered to match → there is oddness around the relatively new “ShowHiddenChar” defaulted on for Formatting Marks. Turning on/off formatting marks can cause dark/light mode tiles to appear. → so this is the “Writer: Dark mode gives Light mode tiles when user clicks on Formating mark” issue - tdf#159368 upstream regression crash - add page up/down to preview navigation [add pageup and page down to preview navigation by caolanm · Pull Request #8098 · CollaboraOnline/online · GitHub](https://github.com/CollaboraOnline/online/pull/8098) - show full renderstate in browser debuging message [the viewrenderedstate=string string is only used in debugging by caolanm · Pull Request #8099 · CollaboraOnline/online · GitHub](https://github.com/CollaboraOnline/online/pull/8099) - viewid problem → we have just one layout shared between multiple views, if show hidden chars is synced to show formatting, then layout could be different in view formatting on/off which is presumably why it has be treated as a special thing, and that difference in layout makes it futile to have this auto-on with view formatting unless we go down a new road of multiple layouts - “Writer: Dark mode gives Light mode tiles when user clicks on Formating mark” debugging and fixing → [https://gerrit.libreoffice.org/c/core/+/162579](https://gerrit.libreoffice.org/c/core/+/162579) to turn show hidden chars back off again and various tests to capture the problem - dark mode problems in chart - poke around at this, looks like a few problems here → [https://gerrit.libreoffice.org/c/core/+/162619](https://gerrit.libreoffice.org/c/core/+/162619) for toggling dark mode not doing anything when chart is active # Mike - “Improvements needed to DOCX fidelity” - 5 Different positioning of a page number field in the footer - DomainMapper::lcl\_utext checks m\_pImpl-\>m\_pSdtHelper-\>GetSdtType, and calls m\_pImpl-\>m\_pSdtHelper-\>createPlainTextControl - In the first para, SdtHelper::m\_xFieldStartRange is empty - So the problem seems to be, that for a block sdt, the first paragraph (in doc) does not set SdtHelper::m\_xFieldStartRange. - Oh - there’s DomainMapper\_Impl::m\_xSdtEntryStart? - “Improvements needed to DOCX fidelity” - 5 Different positioning of a page number field in the footer - Spent some time time playing with different refactor of field import code, in attempt to make it sane - In the end, created [https://gerrit.libreoffice.org/c/core/+/162427](https://gerrit.libreoffice.org/c/core/+/162427) as the least bad solution (mentioned my concerns there) - “Improvements needed to DOCX fidelity” - 5 Different positioning of a page number field in the footer - Backporting to co-23.05 branch - 4 Different positioning of text in footnote - Started to debug it - “File linked to image is not exported to ReqIF-XHTML” - Estimated and answered - “Inconsistent behaviour with document repair mechanism” - Answered; asked for some clarification - “Bookmarks placed directly behind each other produce une[…]” - Estimated and answered - “Improvements needed to DOCX fidelity” - 4 Different positioning of text in footnote - Created a minimal reproducer - The difference between the case when there’s no space between the number and the footnote text, and when there is, is hanging paragraph indent - Debugging - “Improvements needed to DOCX fidelity” - 4 Different positioning of text in footnote - Created upstream [159382 – DOCX import: Large space between footnote number and following text, when paragraph has hanging indent](https://bugs.documentfoundation.org/show_bug.cgi?id=159382) - In the end, it turned out to be really easy - just use another existing code path when the compat option is set - [https://gerrit.libreoffice.org/c/core/+/162603](https://gerrit.libreoffice.org/c/core/+/162603) - Also will need to add the compat option to the GUI - do it separately, to avoid backporting problems - “Improvements needed to DOCX fidelity” - 4 Different positioning of text in footnote - [https://gerrit.libreoffice.org/c/core/+/162635](https://gerrit.libreoffice.org/c/core/+/162635) - What a mess it is - the code of the compat options dialog … - Backporting to 24-02 (will automatically (?) appear in co-24.04) and co-23.05 - The long name of the option gets on my nerves - Will rename it, it’s not too late - “Improvements needed to DOCX fidelity” - 4 Different positioning of text in footnote - [https://gerrit.libreoffice.org/c/core/+/162654](https://gerrit.libreoffice.org/c/core/+/162654) - Also backported - review needed # Tomaz Calc: add currency dropdown to the notebookbar - Get all the currencies used from the document model - look at how we get the document color - done the same for - added DocumentModelAccessor class so we can access parts of the document model from SfxObjectShell - only implemented currencies in this change - but also document colors should now go there too - Added the currencies that are in the document currencies on top - can access SfxObjectShell in the drop-down, so can get the document currencies - use the language and symbol as criteria - insert on top of the list and not at the bottom - not the most pretty code for insertion - Looked at the updated WIP patches from Szymon to add support for Online - and now it works fine from Online when tested - some issues however (described in the TODO) - needs refactoring, so the ToolbarUnoDispatcher instance is “view aware” - so one instance per view - refactored the code and introduced a NotebookBarViewManager and NotebookBarViewData - this now is also responsible for WeldedTabbedNotebookbar instance and the Notebookbar VCL instance - NotebookBarViewManager is a singleton and just holds the map - for a view instance we have a view data instance, so for SfxViewShell pointer maps to a NotebookBarViewData - changed and looks to work good - need to do more testing with everything together # Miklos Worked on [Clipboard: Implement permissions for pasting in Chrome-based browsers · Issue #8023 · CollaboraOnline/online · GitHub](https://github.com/CollaboraOnline/online/issues/8023), now it even has cypress tests.