Build of Collabore Office Classic fails in vcl/win/dtrans/FmtFilter

Development
1

After a ./g pull -r and a make clean I have started a new build on Windows. But it fails with

/engine/vcl/win/dtrans/FetcList.cxx(145): error C7568: argument list missing after assumed function template ‘Sequence’

and with several error messages in /engine/vcl/dtrans/Fmtfilter.cxx, for example:

/engine/vcl/win/dtrans/FmtFilter.cxx(62): error C7568: argument list missing after assumed function template ‘Sequence’

C:/colwsl7/online/engine/vcl/win/dtrans/FmtFilter.cxx(132): error C2556: ’ WinENHMFPictToOOMFPict(HENHMETAFILE)': overloaded function differs only by return type from ‘cpo::uno::Sequence<sal_Int8> WinENHMFPictToOOMFPict(HENHMETAFILE)’
C:\colwsl7\online\engine\vcl\win\dtrans\FmtFilter.hxx(37): note: see declaration of ‘WinENHMFPictToOOMFPict’
C:/colwsl7/online/engine/vcl/win/dtrans/FmtFilter.cxx(132): error C2371: ‘WinENHMFPictToOOMFPict’: redefinition; different basic types
C:\colwsl7\online\engine\vcl\win\dtrans\FmtFilter.hxx(37): note: see declaration of ‘WinENHMFPictToOOMFPict’

2

That is most likely a fallout from commit 14bf02c09226591481735d02b9276f3968d4bcbd, you can try to change the implicit uno::Sequence to cpo::uno::Sequence in the mentioned lines and see if that helps.

I assume you hit this because CI only tests the --with-distro=CODAWindows config (as documented at Build Collabora Office for Windows | Collabora Office - Community Page ), but you don’t seems to use that? I guess --enable-headless is what bypasses this code in the working case. Thanks.

3

The files have a using namespace com:sun:star:uno; . Need there be something like using namespace cpo::uno ? If yes, in addition or instead?

Or/and needs a #include <cpo/uno/Sequence.h>?

I do not use --with-distro=CODAWindows because I want a Office Classic, for to be similar to LibreOffice.

4

I’ll do that. It looks good so far (build is running). The problem seems to have been, that the files do not contain uno::Sequence but only Sequence and thus were not caught by the script.

5

Build has finished with that changes. The patch with these changes is now at https://gerrit.collaboraoffice.com/c/online/+/6499