After a ./g pull -r and make clean and calling make I get the build failure
C:\colwsl7\online\engine\cppcanvas\inc\pch\precompiled_cppcanvas.hxx(135): fatal error C1083: Cannot open include file: 'cppcanvas/canvas.hxx': No such file or directory
Ideas?
looks like a recent refactoring broke the precompiled header, and Windows CI does not use precompiled headers any more because it conflicts with ccache … hope this gerrit patch should fix it, but i’m afraid Noel will keep moving things around…
The next one is C:\colwsl8\online\engine\canvas\inc\pch\precompiled_canvastools.hxx(39)
I have used
wsl ./bin/update_pch canvas canvastools --cutoff=1 --exclude:system --include:module --include:local
as advised in the COOL TC meeting and written in the comment at top of the file and then building finishes.
I imagine this is the same fix as:
https://gerrit.collaboraoffice.com/c/online/+/7628
I took a look at the --disable-pch we are using on the windows ci
machines and I think there isn’t a fundamental incompatibility with the
ccache approach we are using on the windows machine, the engine
autodetects ccache and sets a ccache strategy that works with pch.
In local testing is all seems to work, maybe even the best of both
worlds with a faster build when headers change. I think the existing
cache is useless, and the same ci builds co-26.04 so probably need to
make sure co-26.04 pch is also fixed for that build, and then maybe try
and turn it on at a non-peak time in case it goes awry.
On my machine, I have got this from running update_pch
pch_canvastools.diff (2.6 KB)