Caolan
- crash seen in share’s coredumpctl list
→ https://gerrit.libreoffice.org/c/core/+/185199 - use tcmalloc equivalent to malloc_trim if linked to that
→ add Util::trimMalloc by caolanm · Pull Request #11910 · CollaboraOnline/online · GitHub - rebase clipboard work
- merge independent fixes
→ restore passing lastHTTPHeader by reference by caolanm · Pull Request #11938 · CollaboraOnline/online · GitHub
→ use an explicit 'mimetype' argument for getclipboard by caolanm · Pull Request #11930 · CollaboraOnline/online · GitHub
→ ServerSession::asyncUpload is always of a file by caolanm · Pull Request #11931 · CollaboraOnline/online · GitHub - worry that we are hammering smaps_rollup too much: Gather smaps for process_exporter to gain PSS metrics (#10966) · Issues · GitLab.com / GitLab Infrastructure Team / Production Engineering · GitLab
- serve clipboards with existing ServerSession thing, some
rejigging required
→ allow setting multiple headers in asyncUpload by caolanm · Pull Request #11936 · CollaboraOnline/online · GitHub - coolwsd assert seen in ci logs
→ move _socket in SocketDisposition::execute by caolanm · Pull Request #11935 · CollaboraOnline/online · GitHub - clipboard unexpectedly truncated on arrival, debug
- find where clipboard data is getting truncated/missing
when ServerSession shutdowns socket before flushing data
→ ServerSession may shutdownConnection on socket before all data gets sent by caolanm · Pull Request #11952 · CollaboraOnline/online · GitHub - null deref in ossfuzz after image filter reworks
→ https://gerrit.libreoffice.org/c/core/+/185353 - suggest dumping coolwsd std output log on cypress fail
→ dump coolwsd console log on failure by caolanm · Pull Request #11960 · CollaboraOnline/online · GitHub - clipboard pr for review
- accumulate POSTs in a temp fstream instead of growing
SocketBuffer to fit entire content - pass clipboard in/out of kit as a file argument instead
of streaming their content over connection - serve clipboards with ServerSession backed by clipboard
file
→ Private/caolan/save large clipboard to disk by caolanm · Pull Request #11485 · CollaboraOnline/online · GitHub - co-25.04 crash fix
→ https://gerrit.libreoffice.org/c/core/+/185386 - ofz#415190397 avoid OOM
→ https://gerrit.libreoffice.org/c/core/+/185408 - Have another go at finding out why tcmalloc never seems to
release memory back to OS- Maybe madvise(… MADV_FREE) and the kernel doesn’t yet need
to actually reclaim it so tcmalloc presents to the tool as a
complete memory hog - experiment with an upstream patch to disable MADV_FREE and
just use MADV_DONTNEED instead
- Maybe madvise(… MADV_FREE) and the kernel doesn’t yet need
Mike
- Missing table border when importing ReqIF-XHTML
- Autoformat application special case when cells are merged till end
- Already was special-cased for single-cell tables (Justin)
- Done
- Loading times for Writer documents increases nonlinear for many bookmarks in tables
- Implemented a mode for MarkManager to avoid checking mark names on creation; this uses a map to speed up
eventual names deduplication in the end of the mode - Michael S noticed a problem when SwReader::Read is used to insert content to an existing document
- Fixed; done
- Implemented a mode for MarkManager to avoid checking mark names on creation; this uses a map to speed up
- Regression fixing: tdf#166620
Tomaz
Collabora Online - impress -PPTX - image resied : the ratio isn’t kept
- The PPTX document was provided and the instructuons how to reproduce it
- But that’s more or less the same as we already knew
- Looked into the dialog code and everything seems to be fine
- Couldn’t really reproduce this consistently enough to properly analyze the issue
- Checked the jsdialog code to notice if there is something that stands out why the checkbox doesn’t trigger the dialog code
- Noticed the dialog in co-25.04 is different and doesn’t seem to have the issue
- Looked through commits, but Szymon noticed that a patch is missing in 24.04
- looks like this fixed the issue, at least I don’t seem to notice it anymore
PPTX – font embedding
- Issue with the embedded font when the text box is in edit mode
- gets cut off at the top
- Doesn’t happen in desktop LibreOffice
- Seems to be an unrelated issue with the font embedding so created a new issue in github [1]
- unrelated because it also happens when embedded into ODP document
- probably a bug when using the font and editeng rendering
[1] https://github.com/issues/created?issue=CollaboraOnline|online|11980
Miklos
Worked on: