Caolan
clicking hyperlink in comments breaks session
- dompurify stripped target, even “_blank”
→ '_blank' target stripped during sanitize by caolanm · Pull Request #11716 · CollaboraOnline/online · GitHub - all hands
- rework RequestVettingStation socket transfer thing
→ Don't share ownership of Socket with RequestVettingStation by caolanm · Pull Request #11610 · CollaboraOnline/online · GitHub - merge Noel’s clang plugin
- dig around at what might be eating memory
- we save convert-to clipboards, but those are basically blank
but is a waste of effort:
→ Don't save clipboards of convert-to conversions by caolanm · Pull Request #11737 · CollaboraOnline/online · GitHub - We accumulate a FILE* per document we open as there a
persistent Admin::Document stored for everything opened.
(We do close the fd, but not the FILE*, so there are unneeded
buffers kept around. But that’s probably not the issue
either
→ close Admin::Document smaps file when document is expired by caolanm · Pull Request #11741 · CollaboraOnline/online · GitHub - The very similar warnings in our share logs to their warnings
that looks like pen tests are from “nanitor” - manager 1 on 1
- shrink the size of Admin::Documents
→ Private/caolan/shrink admin documents by caolanm · Pull Request #11747 · CollaboraOnline/online · GitHub - “per-user a11y enabled setting in iframe”
- suggested mini spec for impl
- suggested reword of title of xcu settings
→ xcu settings affect the document for all users by caolanm · Pull Request #11750 · CollaboraOnline/online · GitHub - various followup for socket transfer
→ explicitly clear these here to drop any captures by caolanm · Pull Request #11755 · CollaboraOnline/online · GitHub
→ rework SocketPoll::takeSocket to use transferSocketTo by caolanm · Pull Request #11757 · CollaboraOnline/online · GitHub - crashtesting, clear a low hanging failure to reimport
doc with unusual equation in it
→ https://gerrit.libreoffice.org/c/core/+/184668
Chris
- #11710 - Fix build error with new libpoco
- #11587 - Don’t try to create an ImageBitmap when delta application fails
- #11712 - Clear canvas when resizing to a larger canvas
- #11719 - Backport fix double-resize on canvas (again)
- (wip) #11752 - Scroll performance optimisations
Next:
- #11752 - Scroll performance optimisations
Mike
-
Loading times for Writer documents increases nonlinear for many bookmarks in tables
- Two days of additional debugging
- Estimated the fix
- Have an encouraging idea
- Name lookup is surprisingly expensive
-
LibreOffice wrapped in SWT does not react to scaling settings when moved to other displays
- Done the PoC work as they requested
- Menu drawing code is very stubborn
- Couldn’t make menu draw correctly in the time frame
- Related to font caching, and to MenuBar object relations to MenuBarWindow
-
tdf#166210
- Regression from hidden section rework
-
tdf#166260
- Regression from justified line rework
Tomaz
PPTX – font embedding
- Added a ModelTraverser to gather all the of fonts used in a document
- Only embed those when EmbedUsedFontsOnly is true
- Also take into account different scripts
- Disabled font substitution when embedded fonts are used
- Maybe we can combine substitution with embedding
- Only embed fonts that aren’t common in MSO and have a known metric compatible font in LibreOffice (Times New Roman,…)
- Changed --enable-eot to --disable-eot, so libeot is used by default
- Fixing the CI issues and getting into master, then CO-25.04
Miklos
Worked on 166319 – Interdependent change tracking improvements