Caolan
- a11y sidebar/dialog test coverage
- some cypress stability efforts
→ https://gerrit.collaboraoffice.com/c/online/+/2850
→ https://gerrit.collaboraoffice.com/c/online/+/2849
→ https://gerrit.collaboraoffice.com/c/online/+/2855
→ https://gerrit.collaboraoffice.com/c/online/+/2857
→ https://gerrit.collaboraoffice.com/c/online/+/2859 - a11y
- complete writer-specific a11y dialog coverage
→ https://gerrit.collaboraoffice.com/c/online/+/2889 - fix annoying deadlock on adding user dictionaries at lazy-create
→ https://gerrit.collaboraoffice.com/c/online/+/2960 - crashtesting: fix ScParameterClassification::GetExternalParameterType crashes
→ https://gerrit.collaboraoffice.com/c/online/+/2951 - crashtesting: fix divide-by-zero on rotated zero-width/height shape
→ https://gerrit.collaboraoffice.com/c/online/+/3016 - cypress: patch cypress-visual-regression to wait for screenshot file
→ https://gerrit.collaboraoffice.com/c/online/+/2949 - unset ReadOnlyDoc on sc slots that mutate doc or shared view-data
→ https://gerrit.collaboraoffice.com/c/core/+/3061 - debug ccache oddness in our ci, doesn’t seem to do as much as
expected- file bug for findings at:
Depend mode becomes write-only when direct mode is disabled by multi-arg -Wp,-U,-D, · Issue #1743 · ccache/ccache · GitHub - split fortify -Wp, into two args to work around ccache bug
→ https://gerrit.collaboraoffice.com/c/online/+/3155
- file bug for findings at:
- experiment with check-desktop-mobile-multi, 20 minute full
cypress run, but then over an hour with load, curious, faster than
current targets with light load, worse with higher.
Mike
-
“PPTX 1st page background missing on open and after save”
- Placeholder on slide round-trip done
- Document model support for clip polyline done (to be submitted)
- ODT round-trip for clip polyline done (to be submitted)
- TODO: OOXML round-trip for clip polyline
- TODO: render for clip polyline
- Optional TODO: hit test for clip polyline
- A problem encountered while working on this: stale fasttokenhandler.cxx when changing tokens.txt on Windows with long paths
- made me go back and forth several times
- will fix later (have a plan)
-
handling of empty-argument comment insertion from PostMessage; CSP for comment_avatar
- Implemented (Make the comment_avatar URL pass the iframe CSP by mikekaganski · Pull Request #15832 · CollaboraOnline/online · GitHub is to be reviewed for 25.04)
Tomaz
Calc: Pre-View Spreadsheet Filtering
- Fixing issues with sheet view invalidation
- Patch is merged
- Issue when the user gets thrown into “Default view” if another user creates a new sheet view
- Not obvious what’s wrong - still investigating
- Somewhere there must be a command to change the sheet
- TODO: backport to 25.04
- Partially done..
Vector rendering for online:
- Adding more primitives to client rendering
- Test - engine creates test reference JSON files, client tests the rendering with those
- Added JsonPath - similar usage to XPath for XML
- makes tests more sueful
- Mocha tests that work on an COOL instance (like cypress)
- Can run commands, so we can use that to trigger UNO command to vector primitive tree
- Surely useful for other testing as well
- But currently not decided to go that route - I have a patch however
- Got patches for most polypolygon primitives
- Needed to get the testing groundwork done, so now it will go faster
Carlito Font issue:
- In process: Calc EditEng migrator for cells
- There is no flag here for font independent line spacing, so need to create one
- Need to code review this
- Next charts