Caolan
- a11y testing stuff
- get backlog of additional common/writer dialogs patches merged
- support local builds without thesaurus support from
dictionaries submodule
→ https://gerrit.libreoffice.org/c/core/+/198142
→ Private/caolan/a11y test without dictionaries by caolanm · Pull Request #14225 · CollaboraOnline/online · GitHub - a11y testing
- the “other” category of pdf dialogs, digital signing, etc
dialogs - clear a set of non-async dialogs to get a warning dialog
free path for testing the dialogs.
→ Private/caolan/testa11ypdfdialogs by caolanm · Pull Request #14241 · CollaboraOnline/online · GitHub - I believe that to be all the jsenabled dialogs that writer
can launch - sidebar support, writer-specific is in place, add math in
sidebar and other common support. Poke at chart sidebars - navigating chart to get sidebars visible is problematic,
there is keyboard support to traverse the elements
but something is unreliable here wrt chart in core and capturing
sidebar appearaing in cypress. - ci, push a few efforts to
improve that in general - speculate on some things that might make ci skip whatever is the
part of the npm install that often hangs. - skipping audit for the npm in the cypress_tests case might be
helpful
→ skip npm audit for the cypress tests by caolanm · Pull Request #14278 · CollaboraOnline/online · GitHub - getting shrinkpack working again might be useful for the browser
case
→ debug npm by caolanm · Pull Request #14276 · CollaboraOnline/online · GitHub - first chart sidebar more
Mike
-
LO Draw shapes are rendered differently when created while locking document controllers
- Found the issue: the object used during ODF export to get text properties relied on broadcasting of changes, which was disabled by model lock
- Implemented delay-broadcasting after unlocking model
- There was a case where dropping broadcasts was used as a “feature”: in Calc, when object is anchored “to cell, resize with cell”, it keeps two “anchor points” for top-left and bottom-right corners, as if it wasn’t transformed; and hiding rows/columns (which may change the final geometry of shapes covering the hidden cells) must not re-calculate the anchoring
- Fixed, reported.
-
Comments in the margin of a Writer document are “cut off” or truncated when exported to PDF format
- Found the problem
- Discussed the UX expectations (thanks Pedro and Caolan for feedback!)
- Implemented the fix
Tomaz
Calc: Pre-View Spreadsheet Filtering
- Added Operation framework so it’s easier to deal with code duplication
- ScDocFunc and similar are hard to extend
- we also have multiple of that, e.g. ScDBDocFunc
- each undoable operation should be a class which extends from Operation class
- added delete content, delete cell and sort operations for now, adding more one by one
- easier to implement checks if an operation can be run on sheet view
- will also be used for syncing too
- Implemented OverwriteContent ScDocument function
- takes content of sheet source and overwrites the content in target sheet
- test for that
- useful at syncing
- Implemented syncing for delelte cell
- easy to do - we delete content of one cell only
- readds sorting and filtering
- added test for that
- Implemented syncing for delete content
- multiple selections - can be done for default view only, disallowed for sheet view for now
- complex to figure out, which cells to delete if autofilter is sorted
Miklos
Worked on: