Caolan
- accessiblity
- “accordion” markup for expanders
- deprecate urp
→ deprecate URP by caolanm · Pull Request #14633 · CollaboraOnline/online · GitHub - missing slide previews in 26.04
→ https://gerrit.libreoffice.org/c/core/+/200093 - accessibility
- sidebar accordion expander implementation
→ Wrap expander button in heading for screen reader navigation by caolanm · Pull Request #14646 · CollaboraOnline/online · GitHub - forward port the missing co-25.04 accessibility etc patches
to co-26.04. - second go at accordion expander, wasn’t quite right
- some ci fixing
→ cypress: update follow_me_slideshow_spec.js base screenshots by caolanm · Pull Request #14686 · CollaboraOnline/online · GitHub - accesssibility, missing title for calc sidebar function page
combobox
→ https://gerrit.libreoffice.org/c/core/+/200735 - accessibility
- nested accordion expander support, extra h levels
for each expander inside another. Hit a few existing branches
on the ugly tree on the way through that. - completed forwardports, ci generally works again in co-26.04,
requirement for ci to be green before merge reenabled - poke at some ci failures
- a javascript->typescript conversion made some intended statics
not static - Private/caolan/statics is just a name by caolanm · Pull Request #14750 · CollaboraOnline/online · GitHub
- “Kit unassigned Processes”, suspiciously large number of
subforkits. A thought that the config might be not
cached/recognized causing extra ones. But there appears to
genuinely be 130 separate wopi servers seen by that coolwsd
in the window of time shown in the log. - peaks at 46 subforkits alive, 27 with active documents,
15 recently used. - lets just keep a sensible amount of recently used, but
idle subforkits alive
→ A single coolwsd with at least 130 wopi servers by caolanm · Pull Request #14727 · CollaboraOnline/online · GitHub - we could reduce the spare kits of idle subforkits down
to 1, and let it spin the rest back up if that one gets
consumed
→ wip: Private/caolan/reduce idle subforkit spares by caolanm · Pull Request #14763 · CollaboraOnline/online · GitHub - Avoid capturing “this” in finishedCallback for logging only
- so the potential for a use-after-free isn’t there
→ this captured in finishedCallback for logging only by caolanm · Pull Request #14434 · CollaboraOnline/online · GitHub
Mike
-
Crash when changing table cell background color in Collabora Office Impress 25.4.x
- More cases of incorrect VclPtr usage found and fixed
-
Preview and print orientation are incorrect (Portrait instead of Landscape) after choosing another printer destination.
- They reported it’s still unfixed
- Found another problem, using the new testcase
- The “use settings from dialog” feature introduced in Making sure you're not a bot! is highly problematic
- Created a change (not using “settings from dialog” when using automatic orientation; could also be problematic - asked Tibor to review)
-
TTT (gave a talk on VclPtr)
Tomaz
Calc: Pre-View Spreadsheet Filtering
- Fixed OverwriteContent, so it handles tab relative (and absolute) references correctly
- In Calc it is possible to have relative tab references
- For example “=Sheet1.A1” is a relative tab reference and “$Sheet1.A1” would be an absolute one
- Not supported in MSO - all are absolute
- So the issue is when ding OverwriteContent, the relative reference have to be changed
- If you have a value in Tab0.A1 and Tab3.A1 and you use in Tab1 this values in a formula (=Tab0.A1 + Tab3.A1 for example)
- In Tab0 would be written as relative ref -1 and Tab3 would be +2
- If you run OverwriteContent Tab1 to Tab2 the relative references would be copied unmodified
- So in Tab2 the reference would point to -1 = Tab1 and to +2 Tab4 if it exists - this is a problem
- We need to modify the relative references to point to correct tabs
- Added tests for OverwriteContent tab references
- Added same tests for CopyTab, which shares the content with OverwriteContent
- Found an issue with CopyTab referencing to a backward reference
- With CopyTab it’s a similar scenario
- Tab0.A1 and Tab2.A1 are cells with a value - again in Tab1 =Tab0.A1 + Tab2.A1
- You copy Tab1 into a new tab - Tab1_1, so now the relative references in Tab1 and Tab1_1 need to be adjusted + the absolute references
- In this scenario Tab0.A1 relative reference was not adjusted
- Fixed that
- In Calc it is possible to have relative tab references
- Removed redirection in ViewData
- Now all the sheet views are just tabs with some additional meta-data
- Invalidation doesn’t need to be specially handled anymore
- Only thing is on the UI we need to do the hiding and showing of the correct tabs when you add / switch to sheet views
- Import and Export almost fully done
- Can load and save the sheet view specific sort and filter data
- Removed obsolete functionality
- No more going to previous / next sheet view
- We have the combo box to select the sheet view, so this is not needed anymore
Miklos
Worked on: