Caolan
- spreadsheet with comments fast on desktop, slow in online
- looks like it is all browser side
- various efforts with:
→ Private/caolan/comment perf by caolanm · Pull Request #12544 · CollaboraOnline/online · GitHub
- installing fonts seems to cause subforkit problems
→ Private/caolan/reset terminated subforkits by caolanm · Pull Request #12551 · CollaboraOnline/online · GitHub - make asyncRequest shutdown issue more obvious
→ add an argument to asyncRequest to enforce decision on when to shutdown by caolanm · Pull Request #12571 · CollaboraOnline/online · GitHub - spreadsheets are blank
→ app.activeDocument seen as undefined: by caolanm · Pull Request #12575 · CollaboraOnline/online · GitHub - ofz Segv on unknown address
→ https://gerrit.libreoffice.org/c/core/+/189643 - tdf#141033 a regression of mine
→ https://gerrit.libreoffice.org/c/core/+/189808 - figure out how to get coverity to check/report c++ and javascript
issues in online. - coverity capture --dir cov-int --language c-family
–language javascript --file-include-regex browser/src – make - Enable “Secondary” in web ui, select javascript. Otherwise upload
fails with unhelpful “analysis failed”, ~50 javascript issues - some low hanging straight forward initial fixes
→ cid#548375 Typo in identifier by caolanm · Pull Request #12595 · CollaboraOnline/online · GitHub
→ Private/caolan/jscoverity20250818 by caolanm · Pull Request #12596 · CollaboraOnline/online · GitHub
Mike
- display issues on Templates
- Finished the long chain of changes
- In testing
- pptx heading strike through instead of underline
- We need to ignore empty lines, when calculating text box scaling; but suddenly, have to take them into account when doing layout
- Need to have correct text height, including the empty lines - meaning that they must get personal heights (ImpEditEngine::FormatParagraphs / ImpEditEngine::CalcHeight / ImpEditEngine::isInEmptyClusterAtTheEnd)
- Paper height is limited in ImpEditEngine::CheckAutoPageSize, and that excludes trailing empty chunk (truncated to maMaxAutoPaperSize in ImpEditEngine::SetValidPaperSize) - needed for proper scale calculation; but SdrTextObj::impDecomposeAutoFitTextPrimitive needs the total height including the trailing chunk.
- Working on it.
- We need to ignore empty lines, when calculating text box scaling; but suddenly, have to take them into account when doing layout
Tomaz
Calc: Pre-View Spreadsheet Filtering
- Tried to make it work by creating and handling the ScTable inside ScDocument
- so it would be transparent to the outside which table is used
- but you would still identify which sheet view by sending the SheetViewID into the ScDocument methods
- then FetchTable would have the logic to return the correct ScTable
- ScTable would be stored in SheetView inside the default ScTable
- Unfortunately this would be a much bigger change than anticipated
- it would require to change a lot of methods, then also change where they are used to decide if we can send in a SheetViewID or not
- after trying for some time to make it work even for a simple test I had to give up…
- previous approach was simpler and it already worked with less things that need to change
- reverted all the changes, but I did learn some things at least
- Made the sheet for the sheet view invisible (like with scenarios)
- used can still unhide it
- Looked into Sort to find out the reordering positions
- seems this is straightforward to get, but now need to remember and create tests for all the cases here
- then integrate this into the synchronization between sheet views
- Looked into protection
- most of it is implemented in ScEditableTester
- but we always put up an message box, which is annoying in this case
- will need to refactor to make ScEditableTester have the responsibility to send the UI notification
- or another class that wraps ScEditableTester
Miklos
Worked on 167761 – ODT filter: format redline char properties are lost