Collabora Online Weekly Meeting #180
Date: 08/08/2024
All minutes published on: https://forum.collaboraonline.com/tag/meeting-minutes
Attendees (write your name):
- Pedro, Bayram, Darshan, Ezinne, Hub, Andras, João, Méven, Anna, Michael, Aron, Caolán, Skyler, Vivek, Gökay, Attila, Szymon, Timur, Gulsah, Nick, Sven, Ankush
A.I. Pedro: Remove all the additional paragraph styles for the next meeting → now done
Testing
-
Files
-
https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/f/240797
-
https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/5rotwStfb2Jdjga -Calc file
-
https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/HWn6aXkss2xCtQ4 -Impress
-
https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/9CmfWJsqXEBnzWC -Writer file
- Read-only mode link: https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/XLSNfgpGdRQerXB
-
[Password: coolmeeting]
-
Impress: Accounting firm services.odp
-
-
Features, user flows (Anyone can add here the things they need to test)
-
[Application] [Requester]: what to test
-
[Impress] [Lily]: Basic presentation flows such as creating/removing slides and reordering them Tested last time
-
[Impress] [Ezinne]: Run Presentation and Presentation in Window tested last time
-
[Impress] [Pedro]: Create object shadow and test it in presentation (slide-show) both full screen and in window tested last time
-
[Impress] [Pedro]: Resize shape (default line and area color); Resize shape with transparent area and with line set to purple and thickness to 3 pt
-
[Any App] [Darshan]: Dark mode in read-only document. Check the menubuttons works or not. Do they perform operations properly or not ? Read-only shared link tested last ime
-
Invert background button should be enabled
-
View > Hide menu: should not be there since it doesn’t work (or be disabled)
- Skyler: I suspect this is related to one of my old commits
-
Click in a row/column header right click > non-read-only operations shouldn’t be accessible
-
Help > Server Audit, does nothing and shouldn’t be enabled/visible => need to file this on GH
-
-
[All apps] [Skyler]: Inverted background in dark mode. Check that it doesn’t share between users …
- [non-calc] [Skyler]: also nice to see if inverted background can save/load properly when you refresh your page. This is known not to work in calc, so don’t bother testing it there…
-
- Release Schedule
-
CODE (Red) 24.04.6.1 August 1st
-
stuck in release: Aron created the tag but thtaske packages aren’t in the expected place
-
Looking to fix this asap so we can continue he release process
- Mitch is on this.
-
-
COOL 24.04.6.2 supposed to happen next but maybe we will slow down a bit.
-
Mobile releases 24.04.4 (stable branch) Next week
-
iOS 24.04 is released, another release is supposed to happen after android release
-
Android 24.04 is in test session
-
Blocker: android: some parts don’t render at some zoom levels (Rash will look at it) => Blocker is fixed and now being tested by QA team.
-
Some regressions are found and Skyler is working on those and as soon as those are fixed we will do Android 24.04
-
-
Online Activity
-
PRs in need for attention (Please add here any PR that needs attention)
-
PRs without reviewer https://github.com/orgs/CollaboraOnline/projects/3/views/2 now 6
-
Added method to disable spell check if document is read-only #9674
- Fixes Spell correction annoyingly turned on for read-only users #7935 => Gokay
-
Skyler
-
gokay
-
caolanm
-
-
Nicolas
-
.
-
Ankush
-
coder – working in finance industry
-
working on providing them with a tool here
-
started learning about COOL – two to three weeks back.
-
-
Some questions in the forum
-
Interested in improving finance bits …
- once setup – will be looking at features …
-
Forum discussion :
-
-
Gabriel
-
Working now on something related to CSV and probably will backport it but I’m waiting for some feedback → https://gerrit.libreoffice.org/c/core/+/165905
-
this was mostly useful for converting CSV → PDF – because separators were not found
-
idea was to detect automatically at conversion.
-
First patch – adds character-set and separator settings
-
can use these when you pass the filter parameters.
-
Instead of separator & character set put ‘detect’
-
-
Would be nice to use it in the import dialog.
-
-
Would love to help out with design for serializing settings (Michael)
-
Julius
-
Getting much more frequent races causing a download of the file … when clicked. (Michael)
-
seems like a richdocuments / Nextcloud race… perhaps more plugins installed …
-
now have draw.io/BPMN/etc. etc. in the list here … probably related to this.
-
Finally have a reproducer on our instance
-
Seems the viewer API has a design flaw in that regard
-
Our files engineering-team is looking into having a work around
-
-
Small bugfix release of richdocuments later (probably today)
-
branding customization fix for logo
-
iframe accessibility
-
Fix issue where files were locked during preview generation with network timeouts which could have lead to failed saves
- There is still a risk, but less likely, currently thinking about better ways to handle this
-
-
Nextcloud 30 upcoming, currently in beta
-
Integration with extract/transform document API
-
Create new documents with form from templates
-
-
Nextcloud Conference is happening Sept 14-15, contributor week afterwards
-
Nightly CODE docker image for easier testing
-
Maybe we should have --enable-experimental in here by default in the online configure line to match what I think we build CODE with by default (Caolán)
-
Thorsten
- [No update]
-
Attila
No update
-
Andras
-
Szymon
-
Following the users
-
Fixed another one with generic approach – we didn’t use correct position for cursor in Writer after enabling new following
-
Calc address bar didn’t jump to the cursor – also fixed
-
-
Reviews
-
Working on Impress and Image insertion from integrator problem
-
Next: Pedro’s report - now unotoolbuttons are being enable/disable but the inner child is not being enabled or disabled: search previous and search next
-
Darshan
-
Typescript conversion of ruler.js
-
Aron
- nothing to add
-
Caolan performance
-
Working on extending async DNS
-
https://github.com/CollaboraOnline/online/tree/private/caolan/more_async_dns
-
more progress there
-
-
Reduce tilecombine duplicates during scrolling
-
Fix for a tricky to reproduce crash
- https://github.com/CollaboraOnline/online/pull/9731 (merged master, backport 24.04)
-
Auto committed Watchdog profiles
-
Bayram
-
(In Progress) - Enhancement - tdf#158857: Keep Power Query when saving XLSX
-
core (PR1): https://gerrit.libreoffice.org/c/core/+/164290 (Merged)
-
core (PR2): https://gerrit.libreoffice.org/c/core/+/170691 (WIP)
-
submitted patchset 7:
- refactor: use GrabBag for “macro”, “textlink”, “fLocksText” and “fPublished” attributes of element.
-
now: import child elements.
-
-
-
Skyler
-
Have been away from Monday until Today…
-
Have various changes in review:
-
Calc inverted background restore: https://github.com/CollaboraOnline/online/pull/9697
-
Failing CI, test does not fail locally so looking into that
-
Waiting for review from Gülşah…
-
-
Pasting into jsdialogs on mobile fix: https://github.com/CollaboraOnline/online/pull/9693
- Waiting for review from Szymon…
-
https://github.com/CollaboraOnline/online/pull/9680
- Do not have a reviewer yet, need one … (possibly Szymon?)
-
-
Now looking into some context menu bugs…
-
Issue with empty context menu popping up: https://github.com/CollaboraOnline/online/issues/9740 (https://github.com/CollaboraOnline/online/pull/9741)
-
Issues with desktop-style context menus displaying on mobile…
-
-
Elliot
- On holiday
-
Pranam
-
Gökay
Continues:
- Various bug fixes.
Done:
- Smart guides for Impress shapes. In review.
Next:
-
Biggest commit is merged for separating JS code from HTML. Will continue with the next steps.
-
Hunting for leaflet bits
-
Copy text with comments issue. Has a PR but needs to check the tests also.
-
Hubert
-
Working on Drupal module fixes
-
Investigating https://github.com/CollaboraOnline/online/issues/9699
-
-
Gulsah
-
Changing dark mode affects other users link colors.
-
Ready to review
-
core patch: https://gerrit.libreoffice.org/c/core/+/169984 → needs reviewer while Szymon is out
-
online patch is not needed any more
-
-
-
Calc: Other users automatic font color affecting after one user inverts document background.
- Paused to work.
-
Add Invert background button to mobile view
-
Writer: Invert Background does not invert comments (GH#9629)
- Currently working on this.
-
Next: https://github.com/CollaboraOnline/online/pull/6725
- I’ll re-check that feature
-
Vivek
-
Sven
-
Impress properties dialog now async (cool#7710)
-
Now working on cool#9621 – trying to re-use a socket after sending.
- Learning unit tests …
-
-
Timur
-
Just observing.
-
Méven
- Working on symbol insertion dialog regression caused by https://github.com/CollaboraOnline/online/pull/8011
-
Nick
-
Worked on enabling context menu
-
Have enabled it in online
-
However further keyboard navigation of the context menu doesn’t work yet
-
Arrow keys, esc, enter, etc.
-
-
GH Issues and Forum Topics
- Easy hack:
- Add Prettier fail check on pre-commit #9601 => Completed , Thanks Chase Nelson:)
- Save “Invert Background” preference in JS storage #9538 => Skyler
-
-
Top forum topics from last week:
-
Closed total 82 resolved issues on forum last week
Questions:
- Karthik
I am happy to share that I completed building Mobile project for iOS and able to run in my device successfully. My requirement is to convert office files like docx, xlsx and ppt to PDF files completely offline in my current project. I tested the same feature in Mobile project from cool and it is working like a pro.
Could you please suggest how exactly to link this Mobile project to my current project to have that functionality in my project.
-
AI Darshan to drop here the SDK and simple example repository files with some text
-
IOS build info: https://collaboraonline.github.io/post/build-code-ios/
-
repository file:https://github.com/collaboraonline/online/tree/master/ios
-
Next events
Next meeting
- 15/08/2024