Date: 15/08/2024
All minutes published on: https://forum.collaboraonline.com/tag/meeting-minutes
Attendees (write your name):
- Pedro, Bayram, Darshan, Ezinne, Hub, Andras, João, Méven, Anna, Michael, Aron, Caolán, Skyler, Gökay, Attila, Szymon, Timur, Gulsah, Nick
Testing
-
Files – ( password is coolmeeting)
-
Calc File - https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/ia9mEPxDGXKFAXZ
-
Impress File - https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/exNqYG5bit8ZWFZ
-
Writer File - https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/eYZoHcEXqX8kcDo
-
Read-only mode link - https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/XLSNfgpGdRQerXB
-
Impress: Accounting firm services.odp
-
-
Features, user flows (Anyone can add here the things they need to test)
- Format => [Application] [Requester]: what to test
-
[Impress] [Pedro]: Resize shape (default line and area color); Resize shape with transparent area and with line set to purple and thickness to 3 pt
- Help > Server Audit, does nothing and shouldn’t be enabled/visible => need to file this on GH
-
[Impress] [ Ezinne] : Add, reorder, remove slides
-
[Impress] [Ezinne] : Add Animations and Play Presentation
- Release Schedule
-
COOL 24.04.6.2
- Aron started a build yesterday but was not completed due to some build errors
-
Mobile releases 24.04.4 (stable branch) Next week
-
Android 24.04 package has been tested
- Some issues were found and Skyler has been notified and is working on those and as soon as those are fixed we will do Android 24.04
-
Online Activity
-
PRs in need for attention (Please add here any PR that needs attention)
-
PRs without reviewer https://github.com/orgs/CollaboraOnline/projects/3/views/2 now 1
- Hubert’s https://github.com/CollaboraOnline/online/pull/9814 → Szymon to review
-
Nicolas
-
.
-
Gabriel
-
Working now on something related to CSV and probably will backport it but I’m waiting for some feedback → https://gerrit.libreoffice.org/c/core/+/165905
-
this was mostly useful for converting CSV → PDF – because separators were not found
-
idea was to detect automatically at conversion.
-
First patch – adds character-set and separator settings
-
can use these when you pass the filter parameters.
-
Instead of separator & character set put ‘detect’
-
-
Would be nice to use it in the import dialog.
-
-
Would love to help out with design for serializing settings (Michael)
-
Julius
-
Getting much more frequent races causing a download of the file … when clicked. (Michael)
-
seems like a richdocuments / Nextcloud race… perhaps more plugins installed …
-
now have draw.io/BPMN/etc. etc. in the list here … probably related to this.
-
Finally have a reproducer on our instance
-
Seems the viewer API has a design flaw in that regard
-
Our files engineering-team is looking into having a work around
-
-
Small bugfix release of richdocuments later (probably today)
-
branding customization fix for logo
-
iframe accessibility
-
Fix issue where files were locked during preview generation with network timeouts which could have lead to failed saves
- There is still a risk, but less likely, currently thinking about better ways to handle this
-
-
Nextcloud 30 upcoming, currently in beta
-
Integration with extract/transform document API
-
Create new documents with form from templates
-
-
Nextcloud Conference is happening Sept 14-15, contributor week afterwards
-
Nightly CODE docker image for easier testing
-
Maybe we should have --enable-experimental in here by default in the online configure line to match what I think we build CODE with by default (Caolán)
-
Thorsten
- [No update]
-
Attila
No update
-
Andras
-
Szymon
-
Working on Impress and Image insertion from integrator problem
-
found bug in richdocuments: https://github.com/nextcloud/richdocuments/issues/3902
-
added ad fix and more logging to coolwsd
-
-
Calc switching the view didn’t refresh grid layout
- have fix, but not complete – has some issues
-
Reported and fixed error on context change after classic mode switch https://github.com/CollaboraOnline/online/issues/9816
-
Found bug in moving shape on iOS: https://github.com/CollaboraOnline/online/issues/9780
-
Next: Pedro’s report - now unotoolbuttons are being enable/disable but the inner child is not being enabled or disabled: search previous and search next
-
Darshan
-
Fix: Remove non-read-only context menu options in read-only mode #9756
-
Accessibility :
-
Make JSDialog close button accessible via keyboard #9789
-
WIP: Keyboard navigation in color-picker.
-
-
Aron
- nothing to add
-
Caolan performance
-
Extending async DNS for use with Session::asyncRequest
- https://github.com/CollaboraOnline/online/pull/9786 (ready for review)
-
Reduce tilecombine duplicates during scrolling
-
Fix for a tricky to reproduce crash
- https://github.com/CollaboraOnline/online/pull/9731 (merged master, backport 24.04)
-
Auto committed Watchdog profiles
-
Bayram
-
(In Progress) - Enhancement - tdf#158857: Keep Power Query when saving XLSX
-
core (PR1): https://gerrit.libreoffice.org/c/core/+/164290 (Merged)
-
core (PR2): https://gerrit.libreoffice.org/c/core/+/170691 (WIP)
-
submitted patchset 8:
-
import “r:id”, “invalidUrl”, “action”, “tgtFrame”, “tooltip”, “history”, “highlightClick”, “endSnd” attributes of
-
now: export them
-
-
-
-
(In Progress) - Enhancement - calc: when filling a range of cells, display the largest value in the range
-
Skyler
-
Calc inverted background restore: https://github.com/CollaboraOnline/online/pull/9697
- Merged
-
Pasting into jsdialogs on mobile fix: https://github.com/CollaboraOnline/online/pull/9693
- Merged
-
Fix rangeerror in long pan: https://github.com/CollaboraOnline/online/pull/9680
- Merged
-
Context menu bugs
-
And android bits…
-
Making it easier to build for different architectures…: https://github.com/CollaboraOnline/online/pull/9779
-
Android Gradle Plugin upgrade: https://github.com/CollaboraOnline/online/pull/9546
-
This one required a CI change that is tightly coupled to this change: if your pull requests are failing the Android app build with “org.codehaus.groovy.vmplugin.v7.Java7”, please rebase them
- I know of another CI failure here – some of the VMs do not have the right java version installed altogether – I will fix it
-
-
Impress failing to let you type
- Two patches on the way – I have what I believe to be most of a fix … after this, we should be able to test then release Android!
-
-
Elliot
- On holiday
-
Pranam
-
Gökay
Continues:
-
Various bug fixes.
-
Biggest commit is merged for separating JS code from HTML. Will continue with the next steps.
Done:
- Smart guides for Impress shapes. Merged into master branch.
Next:
-
Hunting for leaflet bits
-
Copy text with comments issue. Has a PR but needs to check the tests also.
-
Hubert
-
Working on Drupal module fixes
-
Online
-
Added Distribute objects to Draw/Impress: https://gerrit.libreoffice.org/c/core/+/171830 and https://github.com/CollaboraOnline/online/pull/9796
-
Fixed https://github.com/CollaboraOnline/online/issues/9801 ChangeBezier button label was incorrect in Draw
-
Related: https://github.com/CollaboraOnline/online/issues/9813 ChangeBezier context menu is incorrect in Draw. Not sure if https://github.com/CollaboraOnline/online/pull/9814 is the best fix. → now merged
-
-
Gulsah
-
Changing dark mode affects other users link colors.
-
Ready to review
-
core patch: https://gerrit.libreoffice.org/c/core/+/169984 → needs reviewer
-
online patch is not needed any more
-
-
-
I was on vacation last week.
-
Currently working on a feature that provides to insert a new slide to specific position in online
-
I’ve rebased that old PR
-
Trying to find how to detect position when slide order is changed.
- Slide numbers are not secure to use. I need to find another way.
-
Vivek
-
Sven
-
Impress properties dialog now async (cool#7710)
-
Now working on cool#9621 – trying to re-use a socket after sending.
- Learning unit tests …
-
-
Timur
-
Just observing.
-
Méven
-
Working on symbol insertion dialog regression caused by https://github.com/CollaboraOnline/online/pull/8011
-
Ctrl + insert copy (approved) https://github.com/CollaboraOnline/online/pull/9794/files → maybe we could also add this info into the Help tab > keyboard shortcuts dialog
-
Cursor pointer for notebookbar buttons https://github.com/CollaboraOnline/online/pull/9811/files → reviewed please rebase because of Android fail
-
-
Nick
-
Not much to report
-
Working on
-
removing the dependency on Leaflet from sidebar: https://github.com/CollaboraOnline/online/pull/9658
-
Keyboard navigation in context menu
-
Opening navigator in a detached window – later to be in the left sidebar
-
-
GH Issues and Forum Topics
-
GH issues:
-
Calc : Add Data Labels in Charts for Spreadsheets #9478 => Patch is ready need review on this https://github.com/CollaboraOnline/online/pull/9702
-
Inability to Add Comments in Read-Only Mode #9804 => Feature needed
-
Help > Server Audit Does Nothing and Should Be Disabled/Hidden in Read-Only Mode #9750 => patch is ready needs review
-
Add toggle Show menubar icon option in compact view #9749 => CodingWithKetan has aksed to assign this issue, he is working on this
-
Remove “Hide Menubar” Option from View Tab in read only mode #9746
-
-
Top forum topics from last week:
-
Failed to open larger file such as 7.5M PDF with Docker V22.05.14.3.1 : User is facing issues while opening a large pdf file. He added error logs in forum topic thread.
https://forum.collaboraonline.com/t/failed-to-open-larger-file-such-as-7-5m-pdf-with-docker-v22-05-14-3-1/2858 -
How to copy HTML formatted data and paste it into a PPT formatted document
https://forum.collaboraonline.com/t/how-to-copy-html-formatted-data-and-paste-it-into-a-ppt-formatted-document/2857 -
How to add comments in read-only mode for documents (word/Excel/PPT)
https://forum.collaboraonline.com/t/how-to-add-comments-in-read-only-mode-for-documents-word-excel-ppt/2859/3 -
Going through the old installation and configuration issues and closing them if that is not reproducible in current version Same with GH closing old ones and trying to organize tickets
Next events
Next meeting
- 22/08/2024