Collabora Online Weekly Meeting #155
Date: Feb 14th 2024
All minutes published on: Topics tagged meeting-minutes
Please update your section
Please update your section or create a new one if needed.
Attendees (write your name):
- Andras, Ezinne, Timur, Attila, Gulsah, Darshan, Bayram, Hub, Mike D, Michael M, Vivek, Szymon, Julius, Méven Car, Caolán, Pedro, Skyler, Gökay, Anna, Antranig V, Neil Guertin Anna, Pranam
Making the call shorter
- Please update your section relating in the document before we read through it.
- Then only go over anything we need to share / get input on
Release Schedule
- CODE 23.05.8.4 was released
- CODE 23.05.9.1 is going to be released next week
- Mobile releases
- Android 23.05.7 Delay in Android release
Antranig Vartanian
- Representing FreeBSD community
- Trying to pick WRT FreeBSD port
- Wants to contribute any FreeBSD work
- Andras Timar: Another contributor was working on that → Gleb P. was the community maintainer
- So we ended up disabling the Cirrus CI (FreeBSD) because the service was broken
- Antranig: it seems the image you were using was removed from Cirrus community
Julius
-
New release of richdocuments
- Went out end of last week
-
Open in new tab by default (?)
- No news on internal discussions yet
-
WASM
- For now only in development branch of richdocuments, targetting Nextcloud 29
-
Discussion with Pedro around open locally
- General problem that we have no mechanism to “inform” Collabora about lock/permissions changes from the Nextcloud server
- Notify Collabora around changed document metadata · Issue #3421 · nextcloud/richdocuments · GitHub
- Ongoing discussion, probably continued next week with Michael
-
Very large file access? (Michael)
- WOPI end-point not supporting range requests (Julius)
- is done for the webdav endpoints.
- WOPI end-point not supporting range requests (Julius)
-
Issue affecting Android users now fixed and released in the lastest RC : Releases · nextcloud/android · GitHub
- Collabora not loading existing documents in app v3.27.0 · Issue #12338 · nextcloud/android · GitHub and the fix was merged last month: Fix collabora files not loading by JonasMayerDev · Pull Request #12349 · nextcloud/android · GitHub
- (AI: Aron) Chasing when the Android main release will be out → ping Julius or Szymoin
-
Reset access token: #3462 : fix: Handle Reset_Access_Token to generate a new token and reload by juliushaertl · Pull Request #3462 · nextcloud/richdocuments · GitHub
- (AI: Hub) Chase when the next richdocuments is released
Online activity
-
Bugs caught during this meeting
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
- Issue: AI(Pedro): To file bug → it stopped to occur. Re-test it for multiple users
- Error during post message handler
Object { msgId: “Views_List”, args: (25) […], deprecated: false }
TypeError: e.UserId is undefined
showEditor document.js:485
showEditor document.js:484
handlePostMessage postMessage.tsx:91
handlePostMessage postMessage.tsx:85
e postMessage.tsx:29
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
-
Attila
- Checked again macOS keyboard shortcut issues…
It seems to work fine mostly … - Working on: PPTX: text renders horizontally instead of vertically
151102 – FILEOPEN PPTX: text renders horizontally (and condensed) instead of vertically
Mostly working (with some problems)… it can import / export the stacked property. But have to make it less hacky, and test for regressions…
- Checked again macOS keyboard shortcut issues…
-
PRs without reviewer 11 → now 7
-
Szymon
- Fixing load balancing issues:
- Regression in 23.05: Load balancing fix by eszkadev · Pull Request #8183 · CollaboraOnline/online · GitHub
- Tested fixes from Ash for copy-paste from closed document in HAProxy setup
- Asked for server-side check for unescaped WOPISrc which causes issues
- WIP More TypeScript in master:
- Upgrade language version ES5 → ES6
- Add imports/exports to connect modules together and check used types
- Broken date format in XLSX after save
- Problem: After export wrong cell format is used (wrong id)
- I was able to reproduce duplicated entries for formats:
- requires DE language (different than system one) + type manually the number format which exists as a standard format in EN
- Still investigating main issue
- Fixing load balancing issues:
-
Darshan
- Fix cropped userlist popup #8097 => Merged
- Close autofilter popovers when click or change the sheet tab #8059 => Merged
- Calc: Freeze pane lines (dividers) add visual hint for when there are covered cells #8077 => Merged
- Freeze column and row options are not consistent in notebook bar and in compact view. Plus need to do some enhancement by adding this option into context menu in Calc sheet => WIP
- Strange option
Separatoris added to widgetTree view of auto-filter. This case also needs to be handled from core side. As the Separator is not an entity it is just a visual representation. => Will start next
-
Vivek
- Work in progress - Scroll bar animation on mouse hover event (pause)
- [PR] Chart properties dialog: Make Chart insert menu and other dialogs async
- https://gerrit.libreoffice.org/c/core/+/162824 => Merged
- Follow Up https://gerrit.libreoffice.org/c/core/+/162975 => Merged
- Difficulties with delayed document title (Add loading indicator for document title saving)
- Renaming becomes available after rename by another user (Renaming becomes available after rename by another user · Issue #1450 · CollaboraOnline/online · GitHub)=> WIP.
- Make chart properties dialogs async: Part 2 => Not Started.
-
Michael / Caolan – Performance
- FOSDEM presentations
- Usability Optimization FOSDEM 2024 - Collabora Online usability optimization
- WASM FOSDEM 2024 - Collabora Online: WASM
- Caught a calc perf regression seen last week
- Merged Disabled Menubar Notifications in 24.04 online now
- Next up chasing different width editing vs viewing in calc cell
- FOSDEM presentations
-
Testing results:
- Dark mode now working nicely.
- Found some good problems from calc:
- https://github.com/CollaboraOnline/online/isues/6893 – getTextSelection
- may be a red-herring.
- https://github.com/CollaboraOnline/online/isues/6893 – getTextSelection
-
Bayram
- (In Progress): Bug (Enhancement) “Support Power Query in XLSX”
- Bugzilla: 158857 – Keep Power Query when saving XLSX
- STATUS : Researching the missing/modified files.
- Copy/paste of missing files and tags&references to Calc xlsx file worked well on Excel.
- Copied xl/* folder from Excel xlsx file to Calc xlsx file. Copied following lines from -original Excel xlsx file- [Content_Types].xml to the Calc (xlsx) file (those lines/references were missing in the Calc [Content_Types].xml file - which make sense because /xl/connections.xml and /xl/queryTables/* were not exist on Calc):
- <Override PartName=“/xl/connections.xml” … connections+xml"/>
- <Override PartName=“/xl/queryTables/queryTable1.xml” … queryTable+xml"/>
- <Override PartName=“/xl/queryTables/queryTable2.xml” … queryTable+xml"/>
- Opened the -modified- Calc (xlsx) file in Excel and Power Query were there. So, Excel can be able to find and use those missing streams now.
- Now, I am checking every single xml files under the
xl/*folder to detect which files are related to Power Query - so that we won’t need to move the whole folder. Most likely we need to do some modifications inside the files under the xl/* directory - as I did for [Content_Types].xml.- step 1 : find missing xml references
- step 2 : check if missing references are needed for Power Query, if they are not related to Power Query, then we don’t need to save&recover them, so we will leave them as they are.
- More research on the missing and/or modified files might needed.
- After we make sure that which files/xml references we need to save and/or change -to make the Power Query work after saving it on the Calc-; then we can go with the next step: implementing the new feature - coding…
- (In Progress): Bug (Enhancement) “Support Power Query in XLSX”
-
Skyler
- I’ve been at FOSDEM!
- Hackfest
- I’ve worked on typing global.js (it’s global.ts now)… this relies on some work from Szymon which you can find in pull request 2^13
- My typing is in WIP: global.js: convert to typescript by Minion3665 · Pull Request #8221 · CollaboraOnline/online · GitHub
- Hackfest
- Touchscreen bugs
- Pinch position in Calc
- Working on this
- I know where the problem occurs and I’m untangling the surrounding area to find out how to fix it
- Pinch position in Calc
- Video in iOS
- Was not able to reproduce the video failing to play
- Waiting on Anna getting back to me on the results of her testing…
- Video positioning
- Sign in to GitHub · GitHub I believe we should merge this, as Szymon notes it doesn’t fix present in window mode but it is strictly an improvement over what we have now. Please may I have someone review it?
- Szymon has approved → now merged
- Next is: present in window, but I’m working on higher-priority tasks than this currently
- Sign in to GitHub · GitHub I believe we should merge this, as Szymon notes it doesn’t fix present in window mode but it is strictly an improvement over what we have now. Please may I have someone review it?
- Was not able to reproduce the video failing to play
- Android PDF export
- Disabled advanced PDF export as a stopgap solution: Hide exportpdf command in the android app by Minion3665 · Pull Request #8140 · CollaboraOnline/online · GitHub
- I’ve been at FOSDEM!
-
Pranam
- Revamp comment autosave feature
- Reverted all the previous patches of the feature
- More simple implementation using existing workflow
- Hopefully will remove comment regressions
- Then new cypress test for autosaved comments (multiple users) will also be needed
- Revamp comment autosave feature
-
Gökay
- Checking “deletion of comments while tracking changes” issue.
- Handed over to Pranam.
- Pranam: mostly done, it will be pushed today
- Handed over to Pranam.
- Working on a read only mode feature that will allow clicking on a hyperlink.
- Done.
- Current:
- Readonly view for Online.
- Checking “deletion of comments while tracking changes” issue.
-
Hubert
- Some of the Draw (and by extension Impress) improvement work.
- Working on Draw: Select+Drag make drag without feedback · Issue #7821 · CollaboraOnline/online · GitHub : selection & move bug. It happen that triggering the bug is a workaround for other bugs
- Moving restriction draw: Don't force the shape be inside the page by hfiguiere · Pull Request #8165 · CollaboraOnline/online · GitHub – seem that Impress and Draw can have object outside page bounds, but need the tile area expanded (as needed). Work around with #7821.
- Looking at Drupal integration
- Some of the Draw (and by extension Impress) improvement work.
-
Gulsah
-
Overwrite follow up PR of configurable override mode
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
- I triggered the cypress test several time but failed on unrelated part.
- Cypress tests locally failed too but couldn’t return back to work this.
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
-
Calc formula input: Users miss automated support of input: tooltip
- Core has the feature. I’m working on to transfer tooltip to online and show in a better format.
-
-
Andras
- No update
-
Pedro
- Prs reviews backporting fixes to 23.05
-
Neil
- Automated User/Debug Tools
- Moved debug code
- Automated user task queue
- Added several tasks – add/delete cells, resize/delete rows
- Mostly backported to 23.05
- Looking at tinderbox failures
- Automated User/Debug Tools
-
Méven
- Working on the custom properties dialog
- rebasing broke other MR, WIP
- Misc
- browser: move impl of savecomments command to Toolbar dispatch by meven · Pull Request #8125 · CollaboraOnline/online · GitHub (in review) moving code to toolbar.js
- Working on the custom properties dialog
-
Mike D
- Spotted LO 24.2.0 has a major corruption bug if any Math (or OLE?) object is included:
- Me and Kaganski made some progress on Calc “200% Zoom” bug:
- and LO core #159554: “BackgroundParaOverDrawings” compatibility thing
- Copying/Pasting text with “Red background” + Frames = Turned “Orange”
- Retesting old Github bugs + did lots of tagging:
- #8064 = Calc horizontal scrollbar jumping + jerking left
- Probably related to #7838 that I reported before (moving vertical scrollbar caused odd movement of horizontal bar).
- Retested 5 old ones:
- #2856: Vertical Text button in Impress/Draw does not work, Calc/Writer fine.
- Clicking button gets “Property name does not match: CreateDirectly”.
- #5412: If Right-Click menu was also active in document, couldn’t type spaces into Comments.
- (Seems like it works now.)
- #4862: Calc = AutoFilters + Copy/Paste wasn’t working.
- (Seems like it works now.)
- #4416: Android: Collabora listed when using mail app to open ODT+ODS… ODP no.
- #1501: Calc: Text not saved in cell if don’t finish typing and click X.
- #2856: Vertical Text button in Impress/Draw does not work, Calc/Writer fine.
- #8064 = Calc horizontal scrollbar jumping + jerking left
Forum (Mike D)
11 posts this week.
Key topics:
2 Updates:
- Can not localize Collabora Code - #13 by TurabG
- Turkish dictionary got updated in LO core.
- Turkish dictionary got updated in LO core.
- After editing calc sheet in iPad Collabora, it opens in Windows Libre at 200% - #7 by Tex
- Calc “200% zoom” topic.
and a very positive reaction from the “iOS can’t type” thread:
- iPad mini: collabora office text/calc editing not working - #17 by AWA
- “Now [I opened…] the app and could edit the text and the calculation file. Obviously the app was updated in the background. Thank you very much to all who have managed this.”
1 User Support:
- Real-time cursor tracking not working - #2 by Tex
- User had a Collabora 23.05.8.4 + Nextcloud 28.0.2 issue with Calc.
- (Told to submit to Github + gave About > Triple-Click info based on Meeks’s recommendation.)
And 7 Installation issues answered:
- Failure after CODE update to 23.05.8.4 deb Package
- Updated Collabora with Nextcloud + Reverse Proxy, wouldn’t work.
- → Pointed to Nextcloud’s nice “Collabora Integration” wiki:
- Mostly just Docker/Podman/container + Nextcloud setup issues.
- I directed towards documentation/threads or tried to get more basic info (OS, versions, etc.).
9 → 9 - zero replies in user support:
→ User Support - Collabora Online
39 → 38 - zero replies in installation and config:
→ Installation & Configuration - Collabora Online
Next events
- COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – COOL Days 2024 - 8-10 April - Cambridge, UK - Collabora Office and Collabora Online
- We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
- What to do next
- Passport & VISA
- Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
- Apply for a VISA if needed.
- Register for the event: https://eventyay.com/e/0512424d
- Submit a talk:
- https://eventyay.com/e/0512424d/cfs
- Is there an odp template we should use?
- What to do next
Next meeting
- 15/02/2024