Community Weekly Meeting #157

pedro.silva · March 7, 2024, 9:00am

Collabora Online Weekly Meeting #157

Date: Feb 22nd 2024

All minutes published on: Topics tagged meeting-minutes

Please update your section

Please update your section or create a new one if needed.

Calc testing: Nextcloud pass: coolmeeting

Attendees (write your name):

Andras, Darshan, Gulsah, Anna, Attila, Pedro, Szymon, Mike D, Méven, Timur, Pranam, Hub, Caolán, Bayram, Ezinne, Skyler, Vivek, Cosmin

Making the call shorter,

Please update your section relating in the document before we read through it.
Then only go over anything we need to share / get input on

Release Schedule

CODE 23.05.9.2 to be released on Tuesday
Mobile releases
- Android 23.05.7 Delay in Android release

Antranig Vartanian

Representing FreeBSD community
Trying to pick WRT FreeBSD port
Wants to contribute any FreeBSD work
Andras Timar: Another contributor was working on that → Gleb P. was the community maintainer
- So we ended up disabling the Cirrus CI (FreeBSD) because the service was broken
- Antranig: it seems the image you were using was removed from Cirrus community

Julius

Open in new tab by default (?)
- No news on internal discussions yet → Pedro: I think it was agreed to have it as a setting
WASM
- For now only in development branch of richdocuments, targetting Nextcloud 29
Discussion with Pedro around open locally
- General problem that we have no mechanism to “inform” Collabora about lock/permissions changes from the Nextcloud server
- Notify Collabora around changed document metadata · Issue #3421 · nextcloud/richdocuments · GitHub
- Ongoing discussion, probably continued next week with Michael
Very large file access? (Michael)
- WOPI end-point not supporting range requests (Julius)
  - is done for the webdav endpoints.
Issue affecting Android users now fixed and released in the latest RC: Releases · nextcloud/android · GitHub
- Collabora not loading existing documents in app v3.27.0 · Issue #12338 · nextcloud/android · GitHub and the fix was merged last month: Fix collabora files not loading by JonasMayerDev · Pull Request #12349 · nextcloud/android · GitHub
- Released this week → awaiting for user feedback
  - @Nnamani Ezinne Martina was testing: Ezinne: I tested the 3.28.0 version which was released on 13th Feb. Opening documents works using COOL 23.05.9.1
Reset access token: #3462 : fix: Handle Reset_Access_Token to generate a new token and reload by juliushaertl · Pull Request #3462 · nextcloud/richdocuments · GitHub
- (AI: Hub) Chase when the next richdocuments is released

Online activity

Bugs caught during this meeting
- Error during post message handler
  Object { msgId: “Views_List”, args: (25) […], deprecated: false }
  TypeError: e.UserId is undefined
  showEditor document.js:485
  showEditor document.js:484
  handlePostMessage postMessage.tsx:91
  handlePostMessage postMessage.tsx:85
  e postMessage.tsx:29
- Fixed UI backporting: Avatar list: set Unknown user avatar with 0 margin, fix alignment by pedropintosilva · Pull Request #8160 · CollaboraOnline/online · GitHub
- Still would be nice to make sure integrator doesn’t send undefined id
Attila
- Working on: PPTX: text renders horizontally instead of vertically
  151102 – FILEOPEN PPTX: text renders horizontally (and condensed) instead of vertically
  fixed some review issue, fixed kerning problem, and a regression, and merged it…
  now fixing a vertical alignment problem now.
- Working on: PPTX display placeholder in slideshow
  159258 – A picture placeholder with a background, imported from PPTX, is not shown when presenting
  still debugging to find where should we implement the missing render.
PRs without reviewer 7 → now 4
- Collabora Online · GitHub
- PRs for 23.05 should have 2 reviewers
Szymon
- Calc view jumping:
  - fixed case with comment hover
  - found smaller issues on joining the file, missing comment marker on screen
  - trying to reproduce “jump on click”
- Fixed message dialog in 24.04
- Fixed “conflict” after rename in COOL in richdocuments:
  - probably it is a bug we had on this call previously
  - Fixes #3492 joining after document is renamed inside editor by eszkadev · Pull Request #3493 · nextcloud/richdocuments · GitHub
- WIP More TypeScript in master
Darshan
- Document Repair does not work with non-English UI 8322 => In Review
- Add filter content with entry widget in help tab for online-help dialogue => 8211 => In Merged
- Handle separator case for tree Widget 8315 => Merged
- Calc: Freeze pane lines (dividers) add visual hint for when there are covered cells #8077 => Merged
- Backport PR:
  - Back port : Add search content in help dialog and fix document repair for non-Eng UI to 23.05 by Darshan-upadhyay1110 · Pull Request #8353 · CollaboraOnline/online · GitHub => In Review
  - Backport to 23.05: Handle sperator case for tree Widget by Darshan-upadhyay1110 · Pull Request #8324 · CollaboraOnline/online · GitHub => Merged
- Freeze column and row options are not consistent in notebook bar and in compact view. Plus need to do some enhancement by adding this option into context menu in Calc sheet => WIP
Vivek
- Work in progress - Scroll bar animation on mouse hover event (pause)
  - Calc: Implement JavaScript animation on mouse event by codewithvk · Pull Request #7218 · CollaboraOnline/online · GitHub
- Renaming becomes available after rename by another user (disable file renaming in readonly mode by codewithvk · Pull Request #8264 · CollaboraOnline/online · GitHub )=> Merged.
- Document Not Reloading After Rename (Issue : Document Not Reloading After Rename [ Only in Debug Mode ] · Issue #8303 · CollaboraOnline/online · GitHub ) => Fix: Multiple Encoding of wopiSrc During Document Renaming by codewithvk · Pull Request #8326 · CollaboraOnline/online · GitHub => Merged
- Make chart properties dialogs async: Part 2 => Remaining Few. => WIP
Michael / Caolan – Performance
- reduce unnecessary theme changes during document loading
  - https://gerrit.libreoffice.org/c/core/+/163650 (merged to 24.04)
    - init document theme during load by caolanm · Pull Request #8320 · CollaboraOnline/online · GitHub (online part, merged)
  - https://gerrit.libreoffice.org/c/core/+/163666 (pending 24.04)
    - set the initial rendering state before the first invalidateCanonicalId by caolanm · Pull Request #8329 · CollaboraOnline/online · GitHub (online part)
- slow scrolling in Calc with comments
  - getComputedStyle is very slow, but we don't need it for LTR comments by caolanm · Pull Request #8304 · CollaboraOnline/online · GitHub (merged, 23.05)
- reduce subarray usage, potential candidate for Firefox scrolling perf issue
  - Private/caolanm/reduce subarray usage by caolanm · Pull Request #8333 · CollaboraOnline/online · GitHub (merged, 24.04)
- Next up chasing different width editing vs viewing in calc cell
Testing results:
- Dark mode now working nicely.
- Found some good problems from calc:
  - https://github.com/CollaboraOnline/online/isues/6893 – getTextSelection
    - may be a red-herring.
Bayram
- (In Progress): Bug (Enhancement) “Support Power Query in XLSX”
  - Bugzilla: 158857 – Keep Power Query when saving XLSX
  - STATUS : Research of missing files was completed.
  - Missing files/folders: xl/connections.xml , xl/queryTables/ *, xl/tables/_rels/ *
  - We must keep
    - [Content_Types].xml - (add missing lines)
      - <Override PartName=“/xl/connections.xml” … />
      - <Override PartName=“/xl/queryTables/queryTable1.xml” … />
      - <Override PartName=“/xl/queryTables/queryTable2.xml” … />
    - – – – – – – – – – – – – xl/* – – – – – – – – – – – –
    - xl/connections.xml - (missing - copy/paste)
    - xl/_rels/workbook.xml.rels - (add missing lines)
      - <Relationship Id=“rId7” … Target=“connections.xml”/>
      - <Relationship Id=“rId8” … Target=“…/customXml/item1.xml”/>
    - xl/drawings/ * - (add missing lines)
      - copy <xdr:sp macro=“” textlink=“”> from original to calc
    - xl/queryTables/ * - (missing - copy/paste)
    - xl/tables/ *
      - table1.xml, table2.xml, table3.xml (they are exist - but order is wrong - don’t touch)
        
        xl/tables/_rels/* - (do not exist → copy/paste)
    - table2.xml.rels → table1.xml.rels (rename)
    - table3.xml.rels → table2.xml.rels (rename)
      - add tableType=“queryTable” to (table1 and 2.xml)
      - add uniqueName=“X” to (table1 and 2.xml)
      - add queryTableFieldId=“X” to (table1 and 2.xml)
      - add under (table1, 2 and 3.xml)
      - Reference table
        
        sheet1.xml → sheet1.xml.rels → table1.xml
        
        sheet2.xml → sheet2.xml.rels → table2.xml → table2.xml.rels → queryTable1.xml
        
        sheet3.xml → sheet3.xml.rels → table3.xml, drawing1.xml → table3.xml.rels → queryTable2.xml
      - NEXT : Start to implement the feature (Mentor: Caolán)
        
        investigate the GrabBag example to get an idea how to start : https://gerrit.libreoffice.org/c/core/+/70933 (tdf#124810: Roundtrip pivot table style info from XLSX)
      - Skyler
        
        Typescript
        
        I’ve been working on typescript, eslint and so forth
        
        Not much to report, except that I’m looking to tighten eslint rules
        
        I’m also working on:
        
        updating some of our outdated node packages
        
        putting everything under our tsconfig
        
        Hack week!
        
        I started my hack week yesterday
        
        I’m going to work on the user list/following, I have some plans already (see https://www.figma.com/file/earjlYT05PGIYUYDGy4lQ4/Collabora-Online-following?type=design&node-id=7%3A36&mode=design&t=O2ZEktT7cvCgPERl-1) but if you have any apps that you know of which you particularly like the following features in I’d love to know about them!
        
        To start with I’m cleaning up some of the code and reordering what we have so you’re always first rather than at a random point [simplification, this isn’t actually the whole of it but it’s close enough] – this will make it easier to unfollow people
      - Pranam
        
        Done:
        
        Visual feedback for operations of tracked comments (show/hide changes, indication of delete)
        
        Current:
        
        Moving shapes in impress while editing texts inside
        
        Fixing issues with comments layout in writer
      - Gökay
        
        Current:
        
        Readonly view for Online.
        
        Sent the first 2 PRs for core side. Will check Calc and Impress apps.
        
        Then a general check + Online side.
      - Hubert
        
        Looking at Drupal integration
        
        Done with backports
      - Gulsah
        
        Overwrite follow up PR of configurable override mode
        
        Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
        
        I triggered the cypress test several time but failed on unrelated part.
        
        Cypress tests locally failed too but couldn’t return back to work this.
        
        Calc formula input: Users miss automated support of input: tooltip
        
        Fixed
        
        Core patch: https://gerrit.libreoffice.org/c/core/+/163594 (co-23.05)
        Core patch: https://gerrit.libreoffice.org/c/core/+/163721 (co-24.04)
        Core patch: https://gerrit.libreoffice.org/c/core/+/163651 (master)
        Online patch: Show tooltips over the cell while typing a function in a cell. by GulsahKose · Pull Request #8310 · CollaboraOnline/online · GitHub (master)
      - Andras
        
        No update
      - Neil
        
        Automated User/Debug Tools
        
        Moved debug code
        
        Automated user task queue
        
        Added several tasks – add/delete cells, resize/delete rows
        
        Mostly backported to 23.05
        
        Looking at tinderbox failures
      - Méven
        
        Getting MR for impress autoplay ppsx/pps support ready
        
        https://gerrit.libreoffice.org/c/core/+/163652
        
        Impress: Allow to autostart in presentation mode by meven · Pull Request #8321 · CollaboraOnline/online · GitHub
      - Mike D
        
        #8285: “LEFT ARROW while typing text in a cell = jumps to next cell over”
        
        Oddly, only happens when typing in a NEW cell, doesn’t happen with cells that already have info inside.

Topic	Replies	Views
Community Weekly Meeting #158 Development meeting-minutes	128	March 7, 2024
Community Weekly Meeting #156 Development meeting-minutes	114	March 7, 2024
Community Weekly meeting #155 Development meeting-minutes	162	February 8, 2024
Community Weekly Meeting #154 Development meeting-minutes	135	February 2, 2024
Community Weekly Meeting #153 Development meeting-minutes	104	February 2, 2024

Community Weekly Meeting #157

Attendees (write your name):

Making the call shorter,

Release Schedule

Antranig Vartanian

Julius

Online activity

Calc formula input: Users miss automated support of input: tooltip

Forum (Mike D)

Next events

Next meeting

Next events

Community Weekly Meeting #157

Attendees (write your name):

Making the call shorter,

Release Schedule

Antranig Vartanian

Julius

Online activity

Calc formula input: Users miss automated support of input: tooltip

Forum (Mike D)

Next events

Next meeting

Next events

Related topics