INFOBAR creation should be part of the DELETE event

Development
1

I have finally created a patch (video and patch supplied) which solves this issue -
unfortunately the code creates a separate UNDO stack - meaning to UNDO the DELETE operation it’s necessary to click UNDO twice

  • UNDO the infobar
  • UNDO the DELETE
    which is confusing and not production ready
    the DELETE event and INFOBAR event should reside in the same UNDO - HELP needed.

FYI - my first C++ contribution heavily supported by Gemini.
hence the code is definitely not “professional” grade
and I will remove my comments and beautify the code etc once the double UNDO issue is fixed

1 Like
2

Hi @ferdiga,

Thanks a lot for sharing the patch, really appreciate the contribution!

I just wanted to check, I don’t see a PR on GitHub yet, was the intention to share it only as a .patch file?

If possible, could you please open a Pull Request for this issue? That way the contribution will be properly attributed to you, and we can review and get it merged upstream.

If you run into any difficulty while creating the PR, feel free to reach out, I’d be happy to help you through the process :slightly_smiling_face:

Thanks again!

3

is it OK to create a pull request for a “dirty” working patch with lots of comments and fprints ?

4

@ferdiga Of course, nothing is dirty, it’s all your great work :wink:

7

I have created a pull request

8

@ferdiga can you share link i do not see any PR from your side in GH Pull requests · CollaboraOnline/online · GitHub

9

sharing a link is not allowed

10

github com ferdiga core pull 1

11

Addingg the ref patch here thanks @ferdiga https://gerrit.collaboraoffice.com/c/core/+/816