Caolan
- bootstrap something semi-functional for slide copying
- remove findOrCreateDocBroker extra arg
- memory issue debugging efforts
- some dumpstate changes
- robust socketpoll lifecycle
→ pass SocketPoll around as shared_ptr for asyncConnect by caolanm · Pull Request #11411 · CollaboraOnline/online · GitHub - explore “loading still” thought
- “loading still” might be bogus, just means DocumentBroker poll
hasn’t started yet, might be 1ms ago or an hour, need
longer log to prove they are really stuck at never loading - more robust socketpoll lifecycle follow up
→ enforce SocketPoll is created via shared_ptr by caolanm · Pull Request #11442 · CollaboraOnline/online · GitHub - longer log from demo.eu does strongly suggest that if a
ClientRequestDispatcher::handleClientWsUpgrade never arrives we
can have DocumentBrokers that don’t ever get loaded, and so
stay around permanently. Forcing that problem seems to reproduce. - initial effort at a fix for that
→ Private/caolan/drop never loaded docbrokers by caolanm · Pull Request #11443 · CollaboraOnline/online · GitHub - better iteration at fix to timeout DocBroker if there is never
a handleClientWsUpgrade
→ Private/caolan/drop never loaded docbrokers by caolanm · Pull Request #11443 · CollaboraOnline/online · GitHub - but unsatisfactory explanation for general DocBroker leak
- ~2000 fds and 998 Unauthorized warnings looks better, forcing
an authorization error there reproduces 2 extra fds per attempt - fix fd leak on unauthorized sessions and add test
→ Private/caolan/fdleak3 by caolanm · Pull Request #11453 · CollaboraOnline/online · GitHub - tdf#165881 upstream regression claim
→ https://gerrit.libreoffice.org/c/core/+/183462 - memory use sometimes spikes
- “final” clipboard entries sometimes appear to be out of scale
with usual ones. - file format used for clipboard cache of jpg from writer document is massive · Issue #11470 · CollaboraOnline/online · GitHub as
a placeholder for something reproducible around that - some apparent inefficiency on checking the format of some of
these large clipboard entrues
→ we only care if these match at the start by caolanm · Pull Request #11468 · CollaboraOnline/online · GitHub
Chris
-
Reviewed #11392, #11395, #11396, #11437, #11441
-
Tidied and rebased #11389 (fix tile GC) - merged
- #11457 - Re-implemented for 24.04 - merged
-
Other backports
-
#11422 - Don’t cache null canvases - reverted as part of tiles refactor revert
-
#11423 - Fix handling of double-resize on CanvasSectionContainer
-
-
#11447 - Consolidate some tiles-updating code in TileManager
Mike
- Loading times for Writer documents increases nonlinear for many bookmarks in tables
- Initial empty nodes are created in table cells; they get removed at cell import finalizing
- At node removal, the correction is done, including bookmarks correction
- But for these nodes, we know that there are no bookmarks that needs correction
- Implemented a fix by passing the flag to skip bookmarks correction (hidden property)
Tomaz
- Implementing the HTTP server using boost::beast
- fixed shutdown
- implemented test for the web server
- Looked into oCIS WebDav support
- they provided access to a test server
- login using Google
- need to figure out how to authenticate
Miklos
Worked on Track changes: ability to reinstate a change · Issue #11357 · CollaboraOnline/online · GitHub