Caolan
- add a test to reproduce the asyncdns callback after docbroker
poll dtor that tries to add callback to the poll
→ test for presets not installed yet at doc dtor time by caolanm · Pull Request #11543 · CollaboraOnline/online · GitHub - limit what can call Socket’s setThreadOwner/resetThreadOwner
→ limit what can call Socket's setThreadOwner/resetThreadOwner by caolanm · Pull Request #11556 · CollaboraOnline/online · GitHub - add some basic notes on socket ownership
→ socket ownership notes by caolanm · Pull Request #11558 · CollaboraOnline/online · GitHub - rename server::Session to ServerSession
→ rename server::Session to ServerSession by caolanm · Pull Request #11562 · CollaboraOnline/online · GitHub - expand “Must be the last member” comment
→ expand "Must be the last member" comment by caolanm · Pull Request #11563 · CollaboraOnline/online · GitHub - return std::weak_ptr in DocumentBroker::getPoll
→ return std::weak_ptr in DocumentBroker::getPoll() by caolanm · Pull Request #11564 · CollaboraOnline/online · GitHub - expand ASSERT_CORRECT_THREAD to ProtocolHandlers
→ merge SocketPoll::InhibitThreadChecks and Socket::InhibitThreadChecks by caolanm · Pull Request #11578 · CollaboraOnline/online · GitHub - Check if anything “reuses” http::Session, apparently not
- Session “disconnect” methods aren’t used
→ disconnect methods of Session/ServerSession are unused by caolanm · Pull Request #11580 · CollaboraOnline/online · GitHub - consider socket ownership of RVS, we’re transferring a
Socket from one poll to another, but in two steps. Out
of the original poll when that opportunity is available,
and into the dest poll when that is created later. - ofz Use-of-uninitialized-value calc issue
→ https://gerrit.libreoffice.org/c/core/+/183947 - 25.04 bg save timeouts, Missing “,” seperator in json save message
→ Missing "," seperator in json save message by caolanm · Pull Request #11603 · CollaboraOnline/online · GitHub - use SocketDisposition::setTransfer instead of
SocketDisposition::setMove
→ use SocketDisposition::setTransfer instead of SocketDisposition::setMove by caolanm · Pull Request #11611 · CollaboraOnline/online · GitHub - Don’t share ownership of Socket with RequestVettingStation
Leave the Socket in the original SocketPoll until we have
the destination SocketPoll created. To do that add something
similar to checkTimeout to allow a SocketPoll to be transferred
outside of a handler reading from the socket.
→ Don't share ownership of Socket with RequestVettingStation by caolanm · Pull Request #11610 · CollaboraOnline/online · GitHub - crashtesting, out of bounds
→ https://gerrit.libreoffice.org/c/core/+/184013 - scan noel’s clang plugin output for low hanging issues
- plugin: enforce Socket shared_ptr semantics by grandinj · Pull Request #11593 · CollaboraOnline/online · GitHub
→ Don't store Socket outside SocketPoll by caolanm · Pull Request #11621 · CollaboraOnline/online · GitHub
→ Don't store Socket in a non-SocketPoll Object by caolanm · Pull Request #11622 · CollaboraOnline/online · GitHub - debug a test failure that triggers with a planned reorg
→ add a WaitLoad phase to this test by caolanm · Pull Request #11619 · CollaboraOnline/online · GitHub - more RequestVettingStation socket ownership
- reorganize commits
→ Don't share ownership of Socket with RequestVettingStation by caolanm · Pull Request #11610 · CollaboraOnline/online · GitHub
Mike
- markdown export for Writer
- Reading CommonMark spec
- Using HTML export filter as template
- filter/Configuration_filter.mk
- Need to escape leading / trailing spaces, special sequences like —, etc.
- For now, keep exporting page breaks as form feed (\f), but may want to use HTML
- For now, skipping headers/footers/frames entirely
- In progress
Tomaz
PPTX – font embedding
- Returning to this issue - got the code from gerrit and compile in master
- Changed to use “Liberation Mono” for the font to test
- MSO did compress the font, eotinfo shows wrong information
- Removed the font in Windows and it uses the font as expected from the MSO exported document
- So it works as expected with MSO document, now need to do the same with LO document
- Exported the document in LibreOffice - limited to only “Liberation Mono” (4 variants)
- For some reason the font changed to “Courier New” - maybe because it is substituted for that font? Annoying
- Changed the font to “Liberation Mono” manually - didn’t work (MSO reports if font is missing when you save the document again)
- Added missing properties (panose, pitchFamily, charset,..) - didn’t help
- Added the font binaries from the MSO document - still didn’t work
- There must be something preventing MSO to load the document, but not sure what.
- Maybe the App Version…
- Continuing with trying to get it work…
Miklos
Worked on: