Caolan
- address urp review items
- some more coverity online warnings
- perf some sample long running calc processes on demo.eu
- long running processes are often idle and doing little
- but some runs shows 5% of time is drawing simple rectangles
→ optimize cairo drawrect for fill and no line color
https://gerrit.libreoffice.org/c/core/+/157499 - ofz#62935 avoid negative numbers in olHanglJaso
- finally merge urp stuff
Add support for URP messages in COOLWSD by Minion3665 · Pull Request #6992 · CollaboraOnline/online · GitHub - make pr for jodconverter to support it
→ add support for websocket urps available >= LibreOffice 24.2 by caolanm · Pull Request #355 · jodconverter/jodconverter · GitHub
→ “will merge this week”, sounds promising. - online build seems broken after hebrew translation update
→ Fix JSON syntax error for some Hebrew strings by caolanm · Pull Request #7356 · CollaboraOnline/online · GitHub - bisect latest crashtesting failures
- debug quarantine failures
- if not uploading/saving then it uses orig Filename which doesn’t
exist, rather than the jail path which does - forkLibreOfficeKit is run regularly and can remove a jail before
docbroker gets a chance to quarantine any document from it - if a crash happens during load, then that won’t be considered as
a “data loss”, so no quarantine happens
→ Private/caolanm/fixquarantine by caolanm · Pull Request #7364 · CollaboraOnline/online · GitHub
- bisect of new crash test failure seems to indicate the recent
detection of crash is more to do with rebase to latest toolchain
finding an older problem than seeing a new one appear - fix that new crashtesting crash on exit
→ https://gerrit.libreoffice.org/c/core/+/157573 - figured out the crash in online bullets and numbering
Format > "Bullets and Numbering" > Outline = Crash · Issue #7254 · CollaboraOnline/online · GitHub
→ https://gerrit.libreoffice.org/c/core/+/157610 - crash seen during weekly calc test
→ https://gerrit.libreoffice.org/c/core/+/157611 - found use of an uninitialized variable on export of ods during that
→ https://gerrit.libreoffice.org/c/core/+/157613 - flamegraph from weekly test has a huge amount of calc sidebar
navigator updating in it - cool#7373 spreadsheet perf from cool call
- notice that new drawings don’t appear immediately in navigator
→ https://gerrit.libreoffice.org/c/core/+/157608 to fix that - consider for a while making the calc navigator act like the
writer navigator as the best solution, but its fairly tightly
bound to doing it its own weird way, doable, but the problem
is only really for online, so a one-liner gets all the benefit
→ https://gerrit.libreoffice.org/c/core/+/157622 - though there is some low hanging unused code in the calc
navigator that can be removed, maybe it began life as a copy
and paste of the original writer one, or some abandoned idea
that never happened. Oddness was already in initial commit
→ https://gerrit.libreoffice.org/c/core/+/157649 etc - fix new coverity warnings
Mike
- Superfluous rows in table when exported to ReqIF
- The first (original) problem fixed
Tomaz
First-page header and footer from and to DOCX:
- setting the first, left/right properties to the page style can work
for each use case- but doesn’t work when combined
- can also be influenced in other way, like the order and different
combinations of first/left/right properties set - interesting it is influenced at what order the properties are set
to the page style- need to set shared to false and later re-enable to work properly
- need to figure this out - probably need to first figure out what
kind of headers/footers are in the document- then set them in second pass
- it worked when we only had left/right, because first was a separate
page style so this case could be worked around - but now this can’t be done in this way anymore
Miklos
- 157119 – Third part of multi-page floating tables “Third part of multi-page floating tables”
- see the bug for details