Collabora Online Weekly #114

Development
1

Collabora Online Weekly Meeting #114

Date: Apr 6th 2023

All minutes published on: Topics tagged meeting-minutes

Attendees (write your name):

  • Pedro, Andras, Cosmin, Szymon, Timur, Thorsten, Gabriel, Justin, Nicolas, Einne

Release schedule (Andras)

  • Last week COOL Days
  • Maybe next week bug fix release
  • Probably, shortly we will have new iOS release

Nicolas

  • Trying to setup CO with oCIS but a bit difficult, documentation seems small
  • Pedro: Yes, I had the same problem also looking into this
    • Nicolas: I got it working but I needed to get an older CODE docker image and it now works.
      • Sent Email. Thanks!
  • Spent some time testing iOS
    • So far looks nice, still some work is needed
    • still some rough edges. We need to maybe address some blockers (need to double check the saving)
    • Produce a list of the last blockers to fix before releasing over 21.11 form Testflight.
  • Testing dialogs and reporting on GitHub:
  • Next: test the languageTool improvements from Mike
    • logging and the possibility to have multiple languages in the same document
    • Also inlcude fallback in the case that particular locale is non existent. Example: PT-PT → PT-BR
    • Still building from master

Community (Pedro)

Community: Dark mode

  • Dark mode branch was rebased → it should get merged after releases provided that we have the toggle working
  • Paris got the rendering working for multiple views with different settings
    • not just dark mode, but non-printing characters etc.
    • nice new features coming for 23.05
    • so far writer only – Calc & Impress/Draw need some rendering re-factoring …
    • Online dark mode branch is now merged

GitHub activity (Pedro)

  • Szymon
    • JSDialog conversion: a couple more dialogs
    • Accessibility improvements
    • Fix grid alignments on JSDialogs
  • Pranam is working on converting the char formatting dialog
    • Done, more 5 or 6 on writer to go
    • Fix writer dialog now maybe 4 left
  • Gokay
    • Improving now the keyboard navigation
      • Tabs were converted to button, additional UI polishing is needed
  • CI
    • Rash is looking at the possibility of using the cypress gh integration (bot) GitHub Apps - Cypress · GitHub
      • Andras: we will see how the whole process of building online works, probably we need to send the already build binaries
    • Pedro will modify the PR github action text to include there a note of all the tests that are not covered by cypress → AI Pedro
  • Gulsah
    • Is looking at why sometimes device-tablet.css is used instead of device-mobile.css (JS)
  • Richdocumentscode
    • Comments with special characters ã á : string length VS byte length
    • bisecting to find why it crashes on start (proxy.php)
  • It seems there are ways to test things without using the ui, using the cypress app actions

Design bits (Pedro and others)

  • Pedro
    • JS, fix button being generated with an extra button container
    • JS, fix button text content being generated inside of spans and at the same level of button instead of part of it
    • CSS: fix vex removal regression
    • Fix box-sizing for element in sidebar an dtabs

Gabriel (1&1)

  • I look into browser: add last modification timeout setting by alessioalex-1and1 · Pull Request #4195 · CollaboraOnline/online · GitHub I will then rebase
  • Multiple savings (in unmodified documents) in between very short chunks of time (seconds. there is no pattern. The document is identical, identical metadata. Connection closes and then reopens → then it saves. Is not something continuous (maybe between the browser and our infrastructure, maybe the client keep trying to connect)
    • Cosmin: I was able to reproduce this sometimes by closing the socket
  • Dynamic change to the log level
    • it takes some time to go online
    • Admin console module is now enabled and we will use it to trigger the dynamic change
    • nothing unusual showed up
  • Save on exit is activated → due to an issue we detected on calc (when editing a cell) and it seems it was the easiest way to “fix it”
    • The document is save inside of core and then an identical version (just the timestamp differs) is uploaded, still unsure why this is happening
    • Michael: is it doing repeated save from the core process? Or is a repeated upload? For the look of it it could be an issue with coolwsd process
  • Save at the fix intervals scenarios disappeared
  • Now added extra flags in the console so we can try to identify/understand better what is happening
    • Michael: Where is it? Can you push it, it seems very useful
  • Added extra information re: log-level etc. … for Kit & coolwsd …
    • would be nice to log just for one specific DocumentBroker (Michael)
      • currently not possible – due to Poco logging.
  • Fix re: slow-start of COW bits … (Gabriel)
    • some topology number of pods / pictures of infra would be great too ! (Michael)
  • Cosmin: we were able to deploy a new version and now we have the dynamic log level change
    • Discussed with Ash during COOL Days hackfest, it seems Ash is already working on some improvements that will most likely fix this saving issues
    • Gabriel: it can be reproduced when we delay the save → resulting in multiple files uploads

LibreOffice conference (Gabriel)

COOL Days 2023

Next meeting

13/04/2023