Collabora Online Weekly Meeting #162
Date: Mar 28th 2024
All minutes published on: Topics tagged meeting-minutes
Please update your section
Please update your section or create a new one if needed.
- Testing
Making the call shorter
- Please update your section relating in the document before we read through it.
- Then only go over anything we need to share / get input on
Release Schedule
- CODE Release plan
- CODE Beta release will happen on April 4th
- CODE Final release on April 18th
- CODE/COOL 23.05.10.1 released today
- Mobile releases (23.05 still)
- Supposed to happen next week but depends on the testing results
Attendees (write your name):
- Gulsah, Anna, Attila, Pedro,Vivek, Méven, Skyler, Nicolas, Darshan, Cor, Bayram, Mike D, Timur, Caolán, Hub, Neil
Sections
Nicolas
- Nothing to share
- Will check the new iOS version that landed in the testflight
Cosmin
Julius
- Bugs from last meeting: shared url with password not working sometimes
- Open in new tab by default (?)
- No news on internal discussions yet
- Pedro: It was agreed to have it as a setting
- No news on internal discussions yet
- WASM
- For now only in development branch of richdocuments, targetting Nextcloud 29
- Discussion with Pedro around open locally
- Julius pushed “Fix open locally with files lock and wopi allow list” , thanks!
- Furthermore we have added a config value for disabling but also address that unlocking the file was no longer working with a WOPI allow list. We now move this to a separate endpoint to handle any prepare steps we need to do before moving to the local editor.
- occ config:app:set richdocuments open_local_editor --value=“no”
- Those 2 fixes got published in the following versions:
- Nextcloud 26: Release v8.0.9 · nextcloud-releases/richdocuments · GitHub
- Nextcloud 27: Release v8.2.6 · nextcloud-releases/richdocuments · GitHub
- Nextcloud 28: Release v8.3.3 · nextcloud-releases/richdocuments · GitHub
- Very large file access? (Michael)
- WOPI end-point not supporting range requests (Julius)
- is done for the webdav endpoints.
- WOPI end-point not supporting range requests (Julius)
- Issue affecting Android users now fixed and released in the latest RC: Releases · nextcloud/android · GitHub
- Collabora not loading existing documents in app v3.27.0 · Issue #12338 · nextcloud/android · GitHub and the fix was merged last month: Fix collabora files not loading by JonasMayerDev · Pull Request #12349 · nextcloud/android · GitHub
- Released this week → awaiting for user feedback
- @Nnamani Ezinne Martina was testing: Ezinne: I tested the 3.28.0 version which was released on 13th Feb. Opening documents works using COOL 23.05.9.1
- Reset access token: #3462 : fix: Handle Reset_Access_Token to generate a new token and reload by juliushaertl · Pull Request #3462 · nextcloud/richdocuments · GitHub
- New version of Richdocuments will be released
very soon→ released 3 days ago: chore(release): Bump version to 8.3.2 by juliushaertl · Pull Request #3507 · nextcloud/richdocuments · GitHub chore(release): Bump version to 8.2.5 by juliushaertl · Pull Request #3508 · nextcloud/richdocuments · GitHub
Online activity
Attila
- merged: PPTX display placeholder in slideshow
159258 – A picture placeholder with a background, imported from PPTX, is not shown when presenting
PR: https://gerrit.libreoffice.org/c/core/+/165087 - worked (working?) on a slide transition performance issue:
153162 – 8s delay before being able to transition to slide from empty slide (- preparing animated GIF?)
merged PR: https://gerrit.libreoffice.org/c/core/+/165261
replaced aAlphaMask.Invert() with a simple color flip (transparent and non-transparent colors)
have a plan to make most of the work later in small parts… (but that means I should refactor gifload a bit) - working on: comment size issue in online writer
bigger comments use small window with scrollbar, even if there is enough space.
I was able to make it bigger, but still working to make is resize based on if there is enough space - PRs without reviewer Collabora Online · GitHub
- 6 PRs need chasing (Pedro)
- browser: fix scroll tab when loading document #8643
- fix : Format → Conditional Menu Button Not Working #8652
- Calc: fix drop zone indicator regression #8657
Szymon
- Fixing CI tests
- More TypeScript in master:
- removed w2ui: formulabar, sheets bar, presentation bar
- in review: statusbar, compact mode toolbar
- next: mobile toolbars
- trying to fix: view jumping after adding row in calc, cell format broken we reproduced last week
Darshan
- Various issues with paragraph formatting options in mobile view
- Accessibility: replace span tag with header tag in modal(js dialog) title #8581
- Accessibility: change table layout in toolbar #8587
- Fix image path for line spacing #8596
- Direct Label Association 8646
- User avatar should be consistent after mode change 8640
- improvement in filter by color submenu 8604
- Working on following topics
- Accessibility improvements
- Improve ‘filter by color’ dialog styling. Filter by color dialog in autofilter gives list of color codes that user can use to filter columns BUT it is difficult to filter by seeing only color codes. Need to add some bg color in that table for more usability
Vivek
- Removing conditional formatting tunneled dialog. => WIP
- Added more specified dialogues for CF
- Added more simplified conditional formatting dialog menus
- Add more options like create, edit, remove conditional from “Manage Conditional Formatting” dialog it self so we can remove tunneled dialog => WIP
- Format → Conditional Menu Button Not Working
- Sidebar: style dropdown: “clear formatting” is not a style, it should be removed
- Sidebar: style dropdown: active/selected style has no preview and is misplaced in the dropdown ( Sidebar: style dropdown: active/selected style has no preview and is misplaced in the dropdown · Issue #8562 · CollaboraOnline/online · GitHub ) => Pause
- Add Animation to scroll bar => Pause
Antony (Welcome!)
- Verification of Alt tags for controls
- Researching on implementing aria for color selector
- Probably moving that for later and will start to work on other low hanging fruits
- Started working on EditStyle button on Sidebar not having alt text. data.text variable empty
Michael Performance
- Background saving for 24.04
- Now working – but leaking files on disk …
- Pending several push requests
- Lots more testing & robustness work needed
Caolan performance:
- Worked on making SvNumberFormatter lockless
- https://gerrit.libreoffice.org/c/core/+/165146 merged to upstream master
- waiting for crashtesting run to give results on testing asserts
- Speed up for ScDocument::GetColDefault
- https://gerrit.libreoffice.org/c/core/+/165346 (Noel, merged 24.04)
- Testing results:
- Dark mode now working nicely.
- Found some good problems from calc:
- https://github.com/CollaboraOnline/online/isues/6893 – getTextSelection
- may be a red-herring.
- https://github.com/CollaboraOnline/online/isues/6893 – getTextSelection
Bayram
- (In Progress) : Bug (Enhancement) : “Support Power Query in XLSX”
- Bugzilla: 158857 – Keep Power Query when saving XLSX
- Patch (WIP) : https://gerrit.libreoffice.org/c/core/+/164290 (Mentor: Caolán)
- sent patch set 6
- done:
- import&export and
- add Relationship::CONNECTIONS
- add support for xr16 namespace
- now: write the -nested- child elements of into the stream
- (CI passed - merged) : [backport] use getentropy() for BSD systems #8591 (backported to online-23.05)
- (Under Review) : Calc: fix drop zone indicator regression #8657 - (waiting for CI…)
- Calc: Receive the sheet protected status #8266
Skyler
- Pinch zoom position
- calc: Fix pinch zoom positioning by Minion3665 · Pull Request #8647 · CollaboraOnline/online · GitHub
- Still a few things need to be done, but first PR is there!
- Weird panning freezes
- Edges of the document do not add a pinch offset
- Would be nice for this to feel a little more fluid
- Other misc stuff
- Attended an SC/34 WG6 (an ISO subcommittee that specializes in ODF) meeting
Pranam
- Done:
- Fixed Paste remembers only the first text copied after comment autosave
- Directly edit textbox after insertion
- Online isn’t in dark mode when system and nextcloud both are dark by default
- Fixed impress reply undo
- Fixed comments overlapping with scaling
Gökay
- Done:
- Readonly view mode for Online.
- Can select & copy text. Can select & copy cells etc.
- Readonly view mode for Online.
- Continues:
- Replace lat & long logic with twips / pixels.
- Readonly view mode next:
- We will add commenting ability on readonly documents. Core side is ready for this feature.
Hubert
- Implement JSLevelBar
- Fixes the Sheet protection dialog in 24.04
- https://gerrit.libreoffice.org/c/core/+/165168
- https://gerrit.libreoffice.org/c/core/+/165236 (master cherry-pick)
- Still Working on a Drupal integration
Gulsah
- Automatic font color problem in dark mode when we have background color
- Fixed:
- https://gerrit.libreoffice.org/c/core/+/165017 (master) has problem on libreoffice CI waiting for verification
- https://gerrit.libreoffice.org/c/core/+/165024 (co-24.04) waiting for review
- Reviewed, and detected a regression when one user is dark other user light mode.
- Currently working on that, then it will be merged.
- Fixed:
- Writer: Rotation Angle tooltip “stuck” (GH#8045)
- Merged : Fix permanent tooltips on dialogs by GulsahKose · Pull Request #8594 · CollaboraOnline/online · GitHub
- Reviewed: Chrome is ok but firefox still problematic I’ll turn back here.
- Paused to working on Calc “Edit Current Style” gear on sidebar. Present on Writer but not in Calc.
- It doesn’t implemented on core. So I need to work on core first
Neil
- Working on performance tests
- As always, making cypress tests more reliable and more maintainable
- Cypress calc helper: make assertDataClipboardTable retryable Cypress calc helper: make assertDataClipboardTable retriable by neilguertincollabora · Pull Request #8608 · CollaboraOnline/online · GitHub
Andras
- CI seems now complete
- android job is completed and seems working https://cpci.cbg.collabora.co.uk:8080/job/github_android_app_co-24.04/
- But recently I saw some C++ tests failing… needs checking
Pedro
Timur
- No update
Méven
- Documentation about &startPresentation in 24.04 Sign in · GitLab approved, can land after 24.04 release
- Ported a message on the wire from text to JSON https://gerrit.libreoffice.org/c/core/+/165094
Forum (Mike D)
8 posts done this week.
Key Topics:
- Review Menu - Accept/Reject all buttons - #2 by Tex
- Feature Request: “Accept” + “Reject” button in “Review” tab.
- Currently, there’s “Next”/”Previous”… and “Accept All”+“Reject All”.
and then more from previous topics:
- Font not preserved · Issue #6382 · CollaboraOnline/online · GitHub
- User from June 2023 reappeared to ask about old bug.
- Writer Lists = Different Font+Font Size at very first spot after bullet.
- Happens in COOL, but not in LO.
- Bugs in the input interface
- iOS + physical keyboard + Chinese
- 2 photos of bugs added.
- Bug 1: When typing Chinese, you get a “popup” of potential word suggestions. 1st word is invisible.
- Bug 2: Pressing on icons with mouse broken (for example: Help > About), but pressing with finger works.
- iOS + physical keyboard + Chinese
9 → 9 - zero replies in user support:
→ User Support - Collabora Online
36 → 36 - zero replies in installation and config:
→ Installation & Configuration - Collabora Online
Next events
- COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – COOL Days 2024 - 8-10 April - Cambridge, UK - Collabora Office and Collabora Online
- We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
- What to do next
- Passport & VISA
- Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
- Apply for a VISA if needed.
- Register for the event: https://eventyay.com/e/0512424d
- Submit a talk:
- What to do next
Next meeting
- 04 /04/2024