Collabora Online Weekly Meeting #161
Date: Mar 21st 2024
All minutes published on: Topics tagged meeting-minutes
Please update your section
Please update your section or create a new one if needed.
- Testing
Attendees (write your name):
- Méven,Ezinne , Darshan, Hub, Caolán, Pedro, Mike D, Anna, Szymon, Skyler, Meven, Bayram, Timur, Attila, Gulsah, Cor, Lars Hoeger, Gökay, Lily, Vivek, Michael, Nicolas, Cosmin
Making the call shorter
- Please update your section relating in the document before we read through it.
- Then only go over anything we need to share / get input on
Release Schedule
- CODE Beta 24.04 some delays here
- CODE Beta release will happen in 4 th of April
- CODE Final release18 th of April
- Mobile releases
- Not well-planned
Nicolas
- Nothing to share
Julius
- Bugs from last meeting: shared url with password not working sometimes
- Open in new tab by default (?)
- No news on internal discussions yet
- Pedro: It was agreed to have it as a setting
- No news on internal discussions yet
- WASM
- For now only in development branch of richdocuments, targetting Nextcloud 29
- Discussion with Pedro around open locally
- General problem that we have no mechanism to “inform” Collabora about lock/permissions changes from the Nextcloud server
- Notify Collabora around changed document metadata · Issue #3421 · nextcloud/richdocuments · GitHub
- Ongoing discussion, probably continued next week with Michael
- Very large file access? (Michael)
- WOPI end-point not supporting range requests (Julius)
- is done for the webdav endpoints.
- WOPI end-point not supporting range requests (Julius)
- Issue affecting Android users now fixed and released in the latest RC: Releases · nextcloud/android · GitHub
- Collabora not loading existing documents in app v3.27.0 · Issue #12338 · nextcloud/android · GitHub and the fix was merged last month: Fix collabora files not loading by JonasMayerDev · Pull Request #12349 · nextcloud/android · GitHub
- Released this week → awaiting for user feedback
- @Nnamani Ezinne Martina was testing: Ezinne: I tested the 3.28.0 version which was released on 13th Feb. Opening documents works using COOL 23.05.9.1
- Reset access token: #3462 : fix: Handle Reset_Access_Token to generate a new token and reload by juliushaertl · Pull Request #3462 · nextcloud/richdocuments · GitHub
- New version of Richdocuments will be released
very soon→ released 3 days ago: chore(release): Bump version to 8.3.2 by juliushaertl · Pull Request #3507 · nextcloud/richdocuments · GitHub chore(release): Bump version to 8.2.5 by juliushaertl · Pull Request #3508 · nextcloud/richdocuments · GitHub
Online activity
-
Bugs while in the text document
- Well, I was testing the comment feature, at some point I couldn’t add the comment, then I scrolled down and saw lots of white tiles, the file became very slow for me, people’s mouses behaved strange. I have record (Anna )
- Help > About “Copy” button not working (on Share)
- Chrome 122.0.6261.94 + 23.05.9.2snapshot (git hash: 9831402)
-
Attila
- Working on: PPTX display placeholder in slideshow
159258 – A picture placeholder with a background, imported from PPTX, is not shown when presenting
PR: https://gerrit.libreoffice.org/c/core/+/165087
worked on review issues, made a second solution (but not finished), then Armin joined and asked for a 3. solution … I think it is working, lets hope it will be ok to Armin. - working on a slide transition performance issue:
153162 – 8s delay before being able to transition to slide from empty slide (- preparing animated GIF?)
Tried to make it load gif parallel, but got deadlock in bitmap creation. (will try later with more stable smaller steps)
Tring to optimize the aAlphaMask.Invert(). (40% of time is wasted here)
- Working on: PPTX display placeholder in slideshow
-
PRs without reviewer Collabora Online · GitHub
- Fix permanent tooltips on dialogs Fix permanent tooltips on dialogs by GulsahKose · Pull Request #8594 · CollaboraOnline/online · GitHub
- cool#8465 clipboard: fix skipping the header of the complex case in JS [co-23.05] cool#8465 clipboard: fix skipping the header of the complex case in JS by vmiklos · Pull Request #8586 · CollaboraOnline/online · GitHub
- Use escape in removeShapeSelection Use escape in removeShapeSelection by neilguertincollabora · Pull Request #8585 · CollaboraOnline/online · GitHub
- Rewrite desktopHelper.insertComment() Rewrite desktopHelper.insertComment() by neilguertincollabora · Pull Request #8580 · CollaboraOnline/online · GitHub
- clipboard: do no compare wth invalid metapath clipboard: do no compare wth invalid metapath by JaumePujantell · Pull Request #8572 · CollaboraOnline/online · GitHub
- config: remove scheme document background color config: remove scheme document background colors by hcvcastro · Pull Request #8564 · CollaboraOnline/online · GitHub
- annotation: resize comment list section on view size change(backport) annotation: resize comment list section on view size change(backport) by lpranam · Pull Request #8548 · CollaboraOnline/online · GitHub
- Private/timar/testandroidci Private/timar/testandroidci by timar · Pull Request #8515 · CollaboraOnline/online · GitHub
- add parameter “theme” to load a document add parameter "theme" to load a document by hcvcastro · Pull Request #8332 · CollaboraOnline/online · GitHub
-
Szymon
- Fixing CI tests
- More TypeScript in master:
- removing w2ui: formulabar, sheets bar, presentation bar,
- trying to fix: cell format broken we reproduced last week
-
Darshan
- Various issues with paragraph formatting options in mobile view
- Accessebility: replace span tag with header tag in modal(js dialog) title #8581
- Accessibility: change table layout in toolbar #8587
- Fix image path for line spacing #8596
- Mobile-view: paragraph section fixes #8492
- Backport PR for RTL/LTR icon fix:Backport: Improve Update state of uno Tool button state on stateChanged 8541
- Working on following topics
- Accessibility improvments
- Improve ‘filter by color’ dialog styling. Filter by color dialog in autofilter gives list of color codes that user can use to filter columns BUT it is difficult to filter by seeing only color codes. Need to add some bg color in that table for more usability
- Various issues with paragraph formatting options in mobile view
-
Vivek
- Work in progress - Scroll bar animation on mouse hover event (Pause)
- Heading 1 and Heading 2 font colour is static for Calc => Merged
- Conditional formatting: there are only format presets available and no discernable way to edit them => WIP
- Remove “Conditional Formatting for” tunneled dialog
- Calc: Enable Cell Styles dialog in online => Gulsah will be working on it.
- Sidebar: style dropdown: “clear formatting” is not a style, it should be removed (Sidebar: style dropdown: "clear formatting" is not a style, it should be removed · Issue #8561 · CollaboraOnline/online · GitHub )=> WIP
- Sidebar: style dropdown: active/selected style has no preview and is misplaced in the dropdown ( Sidebar: style dropdown: active/selected style has no preview and is misplaced in the dropdown · Issue #8562 · CollaboraOnline/online · GitHub ) => Not Started
-
Michael Performance
- Background saving for 24.04
- Buried in admin currently …
- Background saving for 24.04
-
Caolan performance:
- comphelper::rng takes a mutex for every random number https://gerrit.libreoffice.org/c/core/+/164382
- Fun optimization to avoid atomic increment/decrement on calc hot path
- Working on making SvNumberFormatter lockless
- Nearly there, working locally
-
Testing results:
- Dark mode now working nicely.
- Found some good problems from calc:
- https://github.com/CollaboraOnline/online/isues/6893 – getTextSelection
- may be a red-herring.
- https://github.com/CollaboraOnline/online/isues/6893 – getTextSelection
-
Bayram
- (In Progress) : Bug (Enhancement) : “Support Power Query in XLSX”
- Bugzilla: 158857 – Keep Power Query when saving XLSX
- Patch (WIP) : https://gerrit.libreoffice.org/c/core/+/164290 (Mentor: Caolán)
- will send a new patchset
- Status : Implementing the feature
- DONE → write into xl/connections.xml by using GrabBag (not manually)
- now
- add missing XML_xr16 attribute in the codebase to use it during import&export
- put the pieces together with GrabBag and write the correct contents into xl/connections.xml
- next → add missing <Relationship … /> into xl/_rels/workbook.xml.rels
- (CLOSED) : Bug (Enhancement) : use getrandom function #5851
- (In Progress) : Bug (Enhancement) : “Support Power Query in XLSX”
-
Skyler
- Waiting for review:
- Fix panning with RTL by Minion3665 · Pull Request #8565 · CollaboraOnline/online · GitHub – RTL Panning (Pedro to test it)
- following-ui: Improve compatibility with dark mode by Minion3665 · Pull Request #8574 · CollaboraOnline/online · GitHub – Dark mode w/ new following
- Done:
- Stop following text overflowing chip by Minion3665 · Pull Request #8481 · CollaboraOnline/online · GitHub – Following text overflowing following chip
- Typescript
- Convert ColorPicker.js to ColorPicker.ts by Minion3665 · Pull Request #8544 · CollaboraOnline/online · GitHub - Converting colorpicker.js → ts to be used as an example
- https://gerrit.libreoffice.org/c/core/+/164661 – SVG bullet animation fixes merged!
- Current
- Pinch Zoom Positioning
- Still giving me some trouble
- May be good to convert some things to TypeScript around the place (e.g. work on the coordinate types task) so this is easier?
- Pinch Zoom Positioning
- Waiting for review:
-
Pranam
- Done:
- Fixed Paste remembers only the first text copied after comment autosave
- Directly edit textbox after insertion
- Online isn’t in dark mode when system and nextcloud both are dark by default
- Fixed impress reply undo
- Fixed comments overlapping with scaling
- Done:
-
Gökay
- Last week worked on also iOS context menus.
- Current:
- The first commits for read only Online features are in.
- Now working on follow up tasks.
- 2 of them are in. Continuing the work.
- The first commits for read only Online features are in.
-
Hubert
- Still Working on a Drupal integration
-
Gulsah
- Automatic font color problem in dark mode when we have background color
- Fixed:
- https://gerrit.libreoffice.org/c/core/+/165017 (master) has problem on libreoffice CI waiting for verification
- https://gerrit.libreoffice.org/c/core/+/165024 (co-24.04) waiting for review
- Fixed:
- Writer: Rotation Angle tooltip “stuck” (GH#8045)
- Currently working on Calc “Edit Current Style” gear on sidebar. Present on Writer but not in Calc.
- It doesn’t implemented on core. So I need to work on core first
- Automatic font color problem in dark mode when we have background color
-
Andras
- No update
-
Pedro
- Without w2ui this probably needs to be updated Overflow icons: Switch from scroll button to dropdown #2005 Overflow icons: Switch from scroll button to dropdown · Issue #2005 · CollaboraOnline/online · GitHub
- Old improvement: Navigator to be moved to another place (free up toolbar space and make it more as user expects to work): Enable document Navigator · Issue #6248 · CollaboraOnline/online · GitHub
-
Neil
- Looking at tinderbox failures
- Fixed a horrible unit-test problem with racing between
kit_spare startup and tests - hopefully a long-term stability win for unit-test parallelisation
- Fixed a horrible unit-test problem with racing between
- Looking at tinderbox failures
-
Timur
-
Méven
- impress autoplay ppsx/pps support was merged
- Sign in · GitLab approved once, can land after 24.04 release
- impress autoplay ppsx/pps support was merged
-
Mike D
- Comments covering the vertical scrollbar on narrow (half-screen) browse (it happened on 23.05 instance, writer)
Forum (Mike D)
5 posts done this week.
Key Topics:
- Bugs in the input interface
- iOS + physical keyboard + Chinese
- iPad pro 10.5inch + iPadOS 17.4 + Collabora Office (23.05.7.4)
- May be some weird interactions here with Chinese input + mixed English keyboards → Waiting for screenshots.
- iOS + physical keyboard + Chinese
- Atteindre des cellules d' un fichier.ods sur Nextcloud
- Calc: Asking about links to external cells/files.
- → No, not supported yet. Linked to previous 2 topics discussing details.
- Calc: Asking about links to external cells/files.
9 → 9 - zero replies in user support:
→ User Support - Collabora Online
36 → 36 - zero replies in installation and config:
→ Installation & Configuration - Collabora Online
Next events
- COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – https://www.collaboraoffice.com/cool-days-2024/
- We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
- What to do next
- Passport & VISA
- Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
- Apply for a VISA if needed.
- Register for the event: https://eventyay.com/e/0512424d
- Submit a talk:
- What to do next
Next meeting
- 28 /03/2024