Collabora Online Weekly Meeting #163
Date: Apr 04th 2024
All minutes published on: https://forum.collaboraonline.com/tag/meeting-minutes
Please update your section
Please update your section or create a new one if needed.
• Testing
◦ Calc Testing: https://share.collabora.com/index.php/s/A4Y7qtKQto9rDNi
▪ pass: coolmeeting
◦ Writer Testing: https://share.collabora.com/index.php/s/xc5mzDbsTpqTDF8
▪ Minutes #161 doc: https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/ixBAKWaPJSNNBoC
▪ pass: coolmeeting
▪ https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/bdezLaf3WY6DoRy
Making the call shorter
• Please update your section relating in the document before we read through it.
• Then only go over anything we need to share / get input on
Release Schedule
• CODE Release plan
◦ CODE Beta release will happen on April 4th-April 5 th → this week but it will be internally
◦ CODE Final release on April 18th
• CODE released last week: 23.05.10
• Mobile releases is in testing mode ……
◦ Builds created
▪ available in the testflight
▪ Android via apk snapshot: https://www.collaboraoffice.com/downloads/Collabora-Office-Android-Snapshot/
Attendees (write your name):
• Gulsah, Ezinne, Anna, Attila, Pedro,Vivek, Méven, Skyler, Nicolas, Darshan, Cor, Bayram, Mike D, Timur, Caolán, Hub, Neil, Cosmin, Cor
Sections
Nicolas
• Nothing to share
• Will check the new iOS version that landed in the testflight
Cosmin
• Nothing to share
Julius
• Bugs from last meeting: shared url with password not working sometimes
◦ Update: [Bug]: CSRF check failed on public share with password there is already a PR: https://github.com/nextcloud/server/pull/44369
• Open in new tab by default (?)
◦ No news on internal discussions yet
▪ Pedro: It was agreed to have it as a setting
• WASM
◦ For now only in development branch of richdocuments, targetting Nextcloud 29
• Very large file access? (Michael)
◦ WOPI end-point not supporting range requests (Julius)
▪ is done for the webdav endpoints.
• Issue affecting Android users now fixed and released in the latest RC: https://github.com/nextcloud/android/releases
◦ https://github.com/nextcloud/android/issues/12338 and the fix was merged last month: https://github.com/nextcloud/android/pull/12349
◦ Released this week → awaiting for user feedback
▪ @Nnamani Ezinne Martina was testing:
Ezinne: I tested the 3.28.0 version which was released on 13th Feb. Opening documents works using COOL 23.05.9.1
• Reset access token: #3462 : https://github.com/nextcloud/richdocuments/pull/3462
• New version of Richdocuments will be released very soon → released 3 days ago: https://github.com/nextcloud/richdocuments/pull/3507 https://github.com/nextcloud/richdocuments/pull/3508
• Better handling of error messages so to avoid generic messages.
◦ Good if we would send more info within the response messages that we send to the server
Online activity
• PRs without reviewer https://github.com/orgs/CollaboraOnline/projects/3/views/2
◦ 8 PRs need chasing (Pedro) (a couple are test PR)
◦ https://github.com/CollaboraOnline/online/pull/8548 → needs 2 reviewers
◦ Font Color (Dark view) #8692 https://github.com/CollaboraOnline/online/pull/8692 → needs a reviewer / tester
Attila
• worked: comment size issue in online writer
PR: https://github.com/CollaboraOnline/online/pull/8663
resize comments based on space around them…
Pranam is reviewing it.
• Probably I will still work on the slide transition performance issue:
https://bugs.documentfoundation.org/show_bug.cgi?id=153162
To make gif load do only most essential parts at first, and do all other work later in small parts.
Szymon
• More TypeScript in master:
◦ removed w2ui: statusbar, compact mode toolbar, mobile toolbars
◦ last patch in review: https://github.com/CollaboraOnline/online/pull/8682
◦ fixing browser console errors in 24.04, missing bits (idle popup on mobile)
• Current, trying to fix: view jumping after adding row in calc, cell format broken we reproduced last week
Darshan
• Various issues with paragraph formatting options in mobile view
◦ Accessibility:
▪ Remove Redundant Linkage: aria-labelled by #8676 => Merged
▪ Direct Label Association #8646 => Merged
▪ Accessibility: change table layout in toolbar #8587 => In review
• Done some re-work and tested for all devices after removal of w2ui lib
◦ Add read-only option for other application in mobile view => In Review
▪ https://github.com/CollaboraOnline/online/pull/8688
◦ Hide unwanted toolbar buttons for read-only in mobile => In review
◦ User avatar should be consistent after mode change 8640 => Approved / Waiting for CI
◦ Working on Accessibility Writer: Label Without Association to a Form Element
◦ improvement in filter by color submenu 8604 => On Hold
▪ https://gerrit.libreoffice.org/c/core/+/165298
Vivek
• Removing conditional formatting tunneled dialog. => WIP
◦ Added more specified dialogs for CF => Merged
▪ https://gerrit.libreoffice.org/c/core/+/165290 [24.04]
▪ https://gerrit.libreoffice.org/c/core/+/165325 [23.05]
◦ Added more simplified conditional formatting dialog menus => Merged
▪ https://github.com/CollaboraOnline/online/pull/8650
◦ Add more options like create, edit, remove conditional from "Manage Conditional Formatting" dialog it self so we can remove tunneled dialog => WIP
• Format -> Conditional Menu Button Not Working => Merged
◦ Issue : https://github.com/CollaboraOnline/online/issues/8651
◦ PR : https://github.com/CollaboraOnline/online/pull/8652
• fix : Present in the window button hides only for mobile apps => Merged
◦ https://github.com/CollaboraOnline/online/pull/8687
• Sidebar: style dropdown: "clear formatting" is not a style, it should be removed
◦ ( https://github.com/CollaboraOnline/online/issues/8561 ) => Pause
• Sidebar: style dropdown: active/selected style has no preview and is misplaced in the dropdown ( https://github.com/CollaboraOnline/online/issues/8562 ) => Pause
• Add Animation to scroll bar => Pause
Antony (Welcome!)
• Verification of Alt tags for controls
• Researching on implementing aria for color selector
◦ Probably moving that for later and will start to work on other low hanging fruits
• Started working on EditStyle button on Sidebar not having alt text. data.text variable empty
Michael Performance
• Background saving for 24.04
◦ Working – but still WIP – patch with it disabled failing CI
◦ Need to get it merged & iterate.
Caolan performance
• Worked on making SvNumberFormatter lockless
◦ https://gerrit.libreoffice.org/c/core/+/165146 merged to upstream master
◦ fixed up some rounds of crashtesting asserts
◦ Notably crashtesting run has gone from 3 days to 36 hours
• Chasing multiple disjoint invalidations on changes with multiple users on different zooms in calc that gets worse the further to bottom right
• “Watchdog” enabled on perf-staging to attempt to automatically get profiles of just when the areas that we stall.
◦ https://github.com/CollaboraOnline/online/pull/8662
Bayram
• (In Progress) : Bug (Enhancement) : "Support Power Query in XLSX"
◦ Bugzilla: https://bugs.documentfoundation.org/show_bug.cgi?id=158857
◦ Patch (WIP) : https://gerrit.libreoffice.org/c/core/+/164290 (Mentor: Caolán)
▪ will send patch set 7
◦ almost done:
▪ export missing references to xl/_rels/workbook.xml.rels
▪ write the -nested- child elements of <connection> into the stream
◦ next: add missing elements into xl/drawings/*
• (Under Review) : https://github.com/CollaboraOnline/online/pull/8657 - Calc: fix drop zone indicator regression #8657 (CI is green)
◦ requested a review -> Pedro
Skyler
• Pinch zoom position
◦ https://github.com/CollaboraOnline/online/pull/8647 merged!
◦ Followup needed for document edge offsetting
• Working on user list/join message formatting
◦ Regressions caused by W2UI replacement
◦ Some issues due to sizing have been introduced – I will look for where the regression was introduced
Pranam
• Done:
◦ Fixed Paste remembers only the first text copied after comment autosave
◦ Directly edit textbox after insertion
◦ Online isn’t in dark mode when system and nextcloud both are dark by default
◦ Fixed impress reply undo
◦ Fixed comments overlapping with scaling
Gökay
• Done:
◦ Readonly view mode for Online.
▪ Can select & copy text. Can select & copy cells etc.
• Continues:
◦ Replace lat & long logic with twips / pixels.
• Readonly view mode next:
◦ We will add commenting ability on readonly documents. Core side is ready for this feature.
Hubert
• Hide the edit button if file open read-only
◦ Issue https://github.com/CollaboraOnline/online/issues/8686 – PR https://github.com/CollaboraOnline/online/pull/8693
• Investigating memory use with 1.4GB CSV file (80M cells)
◦ Uses 10GB of RAM. Including in LO.
• Still Working on a Drupal integration
◦ https://github.com/CollaboraOnline/collabora-drupal
Gulsah
• Automatic font color problem in dark mode when we have background color
◦ Fixed:
▪ https://gerrit.libreoffice.org/c/core/+/165017 (master) has problem on libreoffice CI waiting for verification
▪ https://gerrit.libreoffice.org/c/core/+/165024 (co-24.04) waiting for review
▪ Reviewed, and detected a regression when one user is dark other user light mode.
• Currently working on that, then it will be merged.
• Writer: Rotation Angle tooltip "stuck" (GH#8045)
◦ Merged : https://github.com/CollaboraOnline/online/pull/8594
◦ Reviewed: Chrome is ok but firefox still problematic I’ll turn back here.
• Paused to working on Calc “Edit Current Style” gear on sidebar. Present on Writer but not in Calc.
It doesn’t implemented on core. So I need to work on core first
Neil
• Working on performance tests
• As always, making cypress tests more reliable and more maintainable
◦ Cypress calc helper: make assertDataClipboardTable retryable https://github.com/CollaboraOnline/online/pull/8608
Andras
• New Linux CI machine: 192 cores, 384 threads!
◦ Something is not OK with coolwsd C++ unit tests there, needs investigation
◦ some of these fail – which are good on other CI machines.
◦ Should parallelize the make check there … (Michael)
▪ C++ tests run 8x wide for me.
Pedro
•
Timur
• No update
Méven
• Documentation about &startPresentation in 24.04 https://gitlab.collabora.com/productivity/sdk/-/merge_requests/83 approved, can land after 24.04 release
• No update apart from that
Forum (Mike D)
3 posts done this week.
Key Topics:
• https://forum.collaboraonline.com/t/how-to-use-filter-in-collabora-online-problem-in-filtering/2518
◦ Calc: Filtering (in first row?) adds a big spacing gap above row 1.
▪ → Asked for sample file.
• https://forum.collaboraonline.com/t/review-menu-accept-reject-all-buttons/2484/13
◦ "Accept" + "Reject" button in "Review" tab added.
◦ Added to 24.04 thanks to bearon!
▪ https://github.com/CollaboraOnline/online/commit/47fcdd0cbcbd4028cc14266a4664fbebc9920678
9 → 9 - zero replies in user support:
→ https://forum.collaboraonline.com/c/user-support/11?order=activity
36 → 36 - zero replies in installation and config:
→ https://forum.collaboraonline.com/c/installation-configuration/10?ascending=true&order=posts
Next events
• COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – https://www.collaboraoffice.com/cool-days-2024/
• We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
◦ What to do next
▪ Passport & VISA
▪ Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
▪ Apply for a VISA if needed.
◦ Register for the event: https://eventyay.com/e/0512424d
◦ Submit a talk:
▪ https://eventyay.com/e/0512424d/cfs
Next meeting (postponed since on the 11th COOL Days is still happening)
• 18/04/2024