Collabora Online Weekly Meeting #151
Date: Jan 11th 2024
All minutes published on: Topics tagged meeting-minutes
Please update your section
Please update your section or create a new one if needed.
Calc testing: Nextcloud pass: coolmeeting
Better logging for cy.cGet() by neilguertincollabora · Pull Request #7877 · CollaboraOnline/online · GitHub Better logging for cy.cGet() #7877
Attendees (write your name):
Andras, Cosmin, Timur, Attila, Gulsah, Darshan, Bayram, Hub, Mike D, Michael, Vivek, Szymon, Julius, Méven Car, Caolán, Pedro, Skyler, Gökay, Anna
testing paste unformatted textr ctrl + alt + shift + v please update your section
please update your section
pasting from staging perf : ctrl + v:
Making the call shorter
Please update your section relating in the document before we read through it.
Then only go over anything we need to share / get input on
Release Schedule
CODE 23.05.7.2 Will be released on Monday
we have to respin to add Armin’s patch there: calc performance
https://gerrit.libreoffice.org/c/core/+/161912/1
Mobile releases
iOS 23.05.7 planning to release in Jan Week 3
TestFlight link: https://testflight.apple.com/join/TEnBWi68
Tester count: 1346 – so people know this link!
Android 23.05.7 planning to release in Jan Week 3
need to fix insert → comments on Mobile.
Vivek Has some improvements here
now merged
AI: Test view jump again next time
Julius
-
New release of richdocuments
- Releases got delayed due to some missed backports
- One still missing, releases will go out afterwards, hopefully today
- Spreadsheet status bar show by default
- Version access for shared files (server release 27.1.5 pending next Thursday)
- For Nextcloud 28 additional things landed (new major version coming next week)
- Improved setup checks to make setup errors easier to fix for admins
- Additional option to configure URL for internal communication between Nextcloud/online
- Releases got delayed due to some missed backports
-
Open in new tab by default (?)
- Ctrl-Click was fixed with fix(files): Allow Ctrl/Command click on file entries to open in a new tab by juliushaertl · Pull Request #42457 · nextcloud/server · GitHub Jan 25th
- Julius brought up having a config flag again internally as this would make users happy and is relatively low effort and can be covered with tests easily
-
WASM
- WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
- richdocuments pull request ready, what version is wasm expected for?
- No pressing needs, let’s just merge this for main branch
- Question: Any release timeframe? Not any time soon, for now a PoC
- WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
-
Discussion with Pedro around open locally
- General problem that we have no mechanism to “inform” Collabora about lock/permissions changes from the Nextcloud server
- Julius will try to come up with a draft concept for how this could be implemented
- For a single file this can work but … (Michael)
- for a whole folder hierarchy – it’s a problem.
- With some extra functionality …
- On the act of changing permissions – can notify …
- Tell me all the WOPISRC’s you have open – and filter in PHP ?
- AI: encourage Michael to come to next Nextcloud/Collabora call (Pedro)
- discuss there.
- Slam-dunk for synchronizing locking from Nextcloud
Online activity
-
Bugs caught during this meeting
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
- Issue: AI(Pedro): To file bug
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
-
Attila
- Working on PPTX export / import problem
134401 – FILESAVE PPTX: vertical alignment inverted (bottom<->top) when saving textbox with link
Impress settings “Fit width to text” and “Fit height to text” should be converted to Powerpoint setting: “Wrap Text in shape” - Fixed hyperlink color problem
PR: https://gerrit.libreoffice.org/c/core/+/161836
154248 – FILEOPEN PPTX: multiline field wrapping breaks rendering of links (and font changes)
still need to work on the break issue, but that is risky - merged a fix for a language warning problem
https://gerrit.libreoffice.org/c/core/+/161836
Calc: Sidebar Changes Language · Issue #7492 · CollaboraOnline/online · GitHub
- Working on PPTX export / import problem
-
PRs without reviewer 4
- Collabora Online · GitHub
- old PR “replace Poco in StreamSocket::send #7534 “ replace Poco in StreamSocket::send by grandinj · Pull Request #7534 · CollaboraOnline/online · GitHub
- Collabora Online · GitHub
-
Szymon
- Working on autofilter cypress test
- merged
- Fixed regression – idle state was not present in 23.05
- Now trying to add cypress test
- Improved color picker
- Added Theme colors palette in Calc and Impress
- Added Document colors palette (colors used in document)
- Made layout more unified with core
- Used JSDialog styling
- Working on autofilter cypress test
-
Darshan
- Fix all major issue Calc autofilter
- More cypress test “AutoFilter” 7879 => Merged
- Small fix for typing text in font and style input dropdown dark in Dark mode https://github.com/CollaboraOnline/online/pull/7867=> Merged
- Add bg color for active sheet tab in Calc #7979 => Merged
- Improvment in spinfield conatiner class 7937=> In Review
- AI: Pedro ^
- Child popup in auto-filter always comes to a fix place on screen ( on left side in middle of the screen ). it should not behave like this. Child-pop-ups should be positioned according to parent position. https://github.com/CollaboraOnline/online/pull/8008
- Strange option
Separator
is added to widgetTree view of auto-filter. This case also needs to be handled from core side. As the Separator is not an entity it is just a visual representation. => Will start next
-
Vivek
- Work in progress - Scroll bar animation on mouse hover event (pause)
- Comment dialogue looking odd in mobile view
- Mobile: Insert comment layout is too narrow and doesn't occupy full height by codewithvk · Pull Request #7719 · CollaboraOnline/online · GitHub => Merged
- Mobile: Resolve issue where busy popup covers the whole document ( Mobile: Change the full height of the busy popup to narrow by codewithvk · Pull Request #7891 · CollaboraOnline/online · GitHub ) => In Review
- Make format condition, chart delete and pivot table error async - https://gerrit.libreoffice.org/c/core/+/160557 - Merged
- jsdialog: enable calc formula error dialog - https://gerrit.libreoffice.org/c/core/+/161592 => Merged
- make formula entry dialogs async => WIP
- Difficulties with delayed document title => WIP
-
Michael / Caolan – Performance
- Exciting kernel bug in smaps_rollup detected
- Calc invalidation for user #1 when user #2 join
- Potential optimization for menubar updating seen in COOL call where we probably don’t need that effort
- https://gerrit.libreoffice.org/c/core/+/160465 to review, after current release :-), now thinking next major release
- Mystery case of another apparent viewid mismatch with a single user and new calc document outstanding
-
Testing results:
- Dark mode now working nicely.
- Found some good problems from calc:
- generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
- may be a red-herring.
- generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
-
Bayram
- (Merged) (High Priority) - Bug: “Calc: Impossible to create same level groups #7811” - Calc: Impossible to create same level groups · Issue #7811 · CollaboraOnline/online · GitHub
- Fix: Calc grouping: find parent groups correctly by bayramcicek · Pull Request #7961 · CollaboraOnline/online · GitHub
- commit #1: Calc grouping: find parent groups correctly
- commit #2: Calc grouping: fix overlapping issue
- the patch is also fixes Bug: “Calc: collapsing groups does not hide its child groups”
- Fix: Calc grouping: find parent groups correctly by bayramcicek · Pull Request #7961 · CollaboraOnline/online · GitHub
- (Merged) - Bug: “Calc: collapsing groups does not hide its child groups”
- (Merged) - Bug: “Calc: Ctrl+Alt+PageUp and Ctrl+Alt+PageDown are swapped”
- Next
- Bug: “Calc: Group/ungroup minus in place of plus”
- Bug: “[Calc][Online][UI] Nested Grouped rows-indicators (vertical lines) and controls (+/-) not fully drawn in online”
- (Merged) (High Priority) - Bug: “Calc: Impossible to create same level groups #7811” - Calc: Impossible to create same level groups · Issue #7811 · CollaboraOnline/online · GitHub
-
Skyler
- The following are now merged
- Calc keyboard pop-down core https://gerrit.libreoffice.org/c/core/+/160313
- Calc keyboard pop-down online Stop onscreen keyboards closing when used to move by Minion3665 · Pull Request #7797 · CollaboraOnline/online · GitHub
- Touchscreen unification followup Followup to unified touch handling by Minion3665 · Pull Request #7712 · CollaboraOnline/online · GitHub
- Touchscreen unification draw fixes bind noManualDrag in Path.Drag.js by Minion3665 · Pull Request #7860 · CollaboraOnline/online · GitHub
- Old safari contenteditable fixes safari: fix contenteditable on old versions by Minion3665 · Pull Request #7874 · CollaboraOnline/online · GitHub
- eslint/prettier
- eslint now has less-strict settings in development (e.g. debugger statements will not fail local builds) Add a lint workflow to fail on eslint warnings by Minion3665 · Pull Request #7850 · CollaboraOnline/online · GitHub
- prettier needs us to update our node version in CI Add prettier by Minion3665 · Pull Request #7857 · CollaboraOnline/online · GitHub, we’ll be adding incrementally when we do add it (so old files will not be immediately under prettier)
- mobile apps
- iOS
- Public Testflight URL Join the Collabora Office beta - TestFlight - Apple
- Branding fixes for tablet mode selections merged [no PR because branding is private, but you should be able to test it on the latest testflight build by selecting some text in writer]
- working on broken sidebar buttons when keyboard is down (e.g. bold when keyboard is down does not work, a workaround is to keep the keyboard up)
- I’ve been deploying fixes to testflight, please update and test them if you have an iOS device
- android: I’m working on building android, I’m currently having some issues with compilation (jni.h not being found)… the instructions here are poor so when I get it working I’ll put some time into improving them
- chromebook: ditto
- when I’ve built Android I’ll be making sure that https://gerrit.libreoffice.org/c/core/+/161692 fixes the problem it did on iOS OR making another patch that works on Android
- iOS
- safari video playback issues
- presentation mode still broken, made Fix video position in safari presentation mode by Minion3665 · Pull Request #7618 · CollaboraOnline/online · GitHub but have had some issues reported on it by Szymon which I’m struggling to reproduce…
- there seems to be an issue where video playback doesn’t always start
- The following are now merged
-
Pranam
- Revamp comment autosave feature
- Reverted all the previous patches of the feature
- More simple implementation using existing workflow
- Hopefully will remove comment regressions
- Then new cypress test for autosaved comments (multiple users) will also be needed
- Revamp comment autosave feature
-
Gökay
- Working on a read only mode feature that will allow clicking on a hyperlink.
- Writer is done.
- Working on Calc and Impress implementations.
- Also tests to be added.
- Next:
- Will check Duden Corrector.
- Working on a read only mode feature that will allow clicking on a hyperlink.
-
Hubert
- Still some of the Draw (and by extension Impress) improvement work.
- WIP draw: constrain object move with Shift by hfiguiere · Pull Request #7958 · CollaboraOnline/online · GitHub – Constrain object move with shift
- Minor UI fix Click on a resume message to dismiss it by hfiguiere · Pull Request #7993 · CollaboraOnline/online · GitHub
- Still some of the Draw (and by extension Impress) improvement work.
-
Gulsah
-
Overwrite follow up PR of configurable override mode
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
- I triggered the cypress test several time but failed on unrelated part.
- Cypress tests locally failed too but couldn’t return back to work this.
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
-
Calc: Columns and rows are not activated on mouseDown
- 0.34 sec to complete for each column selection. Problem is not exist in core because mousebuttondown is handling quickly there. In online we send uno commands for each selected column. Discussed with szymon and he thinks we should keep the uno command and find a way to speed up that method.
- I paused to work on, will turn back again.
-
Calc: Conditional formatting dialog title is too large
- Sent a patch: https://github.com/CollaboraOnline/online/pull/7968
- Pedro reviewed and detected a regression.
- I’ll update
-
Spell check window blows up text size of the text being evaluated
- Sent a patch: Make drawing area image render delay solution to specific by GulsahKose · Pull Request #7995 · CollaboraOnline/online · GitHub
- Szymon doesn’t like the solution, trying to find another solution
- Currently working on this.
-
-
Andras
- No update
-
Pedro
-
Méven
- Making some dialogs async in CORE and expose them in COOL
- Edit section context menu : https://gerrit.libreoffice.org/c/core/+/161828 context menu: allow edit section for Writer text sections by meven · Pull Request #7990 · CollaboraOnline/online · GitHub and hiding the link section in LOK https://gerrit.libreoffice.org/c/core/+/161878 being reviewed
- Document properties custom properties tab, on progress
- Making some dialogs async in CORE and expose them in COOL
Forum (Mike D)
5 new posts this week.
Key topics:
- Weblate Stats: December 2023
- Latest Weblate Stats
- Disable spell correction permanently - #2 by Tex
- User in “read-only” XLSX cannot turn off spellchecking, so everything was underlined in red squigglies.
- → Told them to submit to Github.
- Note: Spellchecking should probably be allowed in “read-only”.
And then a few more normal posts that need more debug info:
- Can't Save on Mobile
- another person on mobile where files don’t save modifications.
- Can't load file in collabora online
- Nextcloud user “can’t load” certain files "unless he restarts service".
11 → 11 - zero replies in user support:
→ https://forum.collaboraonline.com/c/user-support/11?order=activity
37 → 38 - zero replies in installation and config:
→ https://forum.collaboraonline.com/c/installation-configuration/10?ascending=true&order=posts
Next events
- COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – https://www.collaboraoffice.com/cool-days-2024/
- We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
- What to do next
- Passport & VISA
- Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
- Apply for a VISA if needed.
- Register for the event: https://eventyay.com/e/0512424d
- Submit a talk:
- What to do next
Next meeting
-
11/01/2024
- passport & VISA
- Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
- Apply for a VISA if needed.
- Register for the event: https://eventyay.com/e/0512424d
- Submit a talk:
- https://eventyay.com/e/0512424d/cfs
- Passport & VISA
- Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
- Apply for a VISA if needed.
- Register for the event: https://eventyay.com/e/0512424d