Collabora Online Weekly Meeting #164
Date: Apr 18th 2024
All minutes published on:
https://forum.collaboraonline.com/tag/meeting-minutes
- Hubert, Gulsah, Ezinne, Anna, Pedro, Attila, Bayram, Gökay, Andras,
Vivek, Pranam, Michael, Caolan, Szymon
- Calc Testing:
Feedback-18Apr2024.ods - Writer Testing:
sample-file.odt - Impress Testing:
bear.odp
(with video)
-
CODE Release plan
- CODE Beta Release is done
- CODE Final release on April 23^th^
-
Mobile releases is in testing mode …
-
Builds created
- available in the testflight
- 1 blocker to go for Android hopefully to have this fixed
-
<!-- -->
- PRs without reviewer
https://github.com/orgs/CollaboraOnline/projects/3/views/2 - What is stopping us from merging: Fix failing test
desktop/calc/top_toolbar_spec.js #8784
https://github.com/CollaboraOnline/online/pull/8784 - remove-w2ui: css
https://github.com/CollaboraOnline/online/pull/8740 needs
rebasing/solve conflicts - Hide outline format button for mobile #8796
https://github.com/CollaboraOnline/online/pull/8796
@darshan
please move it so there is no need for additional if statement - improvment in filter by color submenu #8604
https://github.com/CollaboraOnline/online/pull/8604 needs rebasing
(so to take the latest CI changes)
<!-- -->
<!-- -->
<!-- -->
<!-- -->
<!-- -->
<!-- -->
-
Bugs from last meeting: shared url with password not working
sometimes- Update: [Bug]: CSRF check failed on public share with
password
there is already a PR:
https://github.com/nextcloud/server/pull/44369 → merged will
be available in the NC 29
- Update: [Bug]: CSRF check failed on public share with
-
WASM
- For now only in development branch of richdocuments, targetting
Nextcloud 29
- For now only in development branch of richdocuments, targetting
-
Very large file access? (Michael)
-
WOPI end-point not supporting range requests (Julius)
- is done for the webdav endpoints.
-
-
Reset access token: #3462 :
https://github.com/nextcloud/richdocuments/pull/3462 → needs
rebase -
Better handling of error messages so to avoid generic messages.
- Good if we would send more info within the response messages
that we send to the server. Issue:
- Good if we would send more info within the response messages
<!-- -->
<!-- -->
- Merged to 23.05: comment size issue in online writer
PR: https://github.com/CollaboraOnline/online/pull/8663
ported to master (not uploaded to PR yet) - working on slide transition performance issue:
https://bugs.documentfoundation.org/show_bug.cgi?id=153162
tried on openSuse (similar to reporter system)
optimizing getAnimationFromGraphic(), it seems to be slow on high
resolution
<!-- -->
<!-- -->
-
More TypeScript in master:
- removed w2ui usage from our JS
- fixed icons
- prepared for removing w2ui CSS
-
Current: cell format broken
- managed to reproduce with Aron
- related to language used, we use translated names for styles
<!-- -->
<!-- -->
<!-- -->
<!-- -->
-
Removing conditional formatting tunneled dialog. => WIP
-
Added more specified dialogs for CF => Merged
-
Added more simplified conditional formatting dialog menus =>
Merged -
Add more options like create, edit, remove conditional from
"Manage Conditional Formatting" dialog it self so we can
remove tunneled dialog => WIP
-
-
Format -> Conditional Menu Button Not Working => Merged
-
fix : Present in the window button hides only for mobile apps =>
Merged -
Sidebar: style dropdown: "clear formatting" is not a style, it
should be removed -
Sidebar: style dropdown: active/selected style has no preview and is
misplaced in the dropdown (
https://github.com/CollaboraOnline/online/issues/8562 ) => Pause -
Add Animation to scroll bar => Pause
<!-- -->
<!-- -->
<!-- -->
<!-- -->
-
Background saving for 24.04
- Unit tests passing with all saves forced to background but …
- Modified state tracking needs finishing.
- More testing and unit tests required.
- Needs to be enabled by default before this evening.
<!-- -->
<!-- -->
-
Worked on making more threaded formula calculation improvements
- https://gerrit.libreoffice.org/c/core/+/165259
- and some more misc in that theme
-
Chasing multiple disjoint invalidations on changes with multiple
users on different zooms in calc that gets worse the further to
bottom right- debugged, understanding of the issue logged as
https://github.com/CollaboraOnline/online/issues/8792
- debugged, understanding of the issue logged as
-
various fixes for watchdog to get better results and fix it
- “Watchdog” enabled on demo.eu to automatically get profiles of
just when the areas that we stall.
- “Watchdog” enabled on demo.eu to automatically get profiles of
-
Chasing compiler hardening bits for 24.04
<!-- -->
<!-- -->
-
(In Progress) : Bug (Enhancement) : "Support Power Query in XLSX"
- Bugzilla:
https://bugs.documentfoundation.org/show_bug.cgi?id=158857 - Patch (WIP) : https://gerrit.libreoffice.org/c/core/+/164290
(Mentor: Caolán) - now: write the -nested- child elements of <connection> into
the stream - next: export missing references to xl/_rels/workbook.xml.rels
- Bugzilla:
-
(Merged) : https://github.com/CollaboraOnline/online/pull/8657 -
Calc: fix drop zone indicator regression #8657
<!-- -->
<!-- -->
-
Pinch zoom position
- Working on frozen frames not properly sticking to their bounds
mid-zoom, and cursor missing frozen frames
- Working on frozen frames not properly sticking to their bounds
-
Comment avatar when user not in document issue
- Fixed, see https://github.com/CollaboraOnline/online/pull/8791
- Darshan will be backporting this and related fixes when he is
back from leave (2pm UTC today).
<!-- -->
<!-- -->
-
Done:
- Fixed file properties showing incorrect size and date
- Working on long threads in comment scroll backs to root comment
on different actions (I.e: reply) which makes actionable comment
go out of view - Some document doesn’t show threaded comments as thread but
individual comments - fixed zotero dialogs (not loading)
<!-- -->
<!-- -->
-
Continues:
- Replace lat & long logic with twips / pixels.
-
Some small fixes and reviews.
-
Copy text with comments issue. Has a PR but needs to check the tests
also.
<!-- -->
<!-- -->
-
Hide the edit button if file open read-only
- Issue https://github.com/CollaboraOnline/online/issues/8686 –
PR https://github.com/CollaboraOnline/online/pull/8693 - Finally merged
- Issue https://github.com/CollaboraOnline/online/issues/8686 –
-
Still Working on a Drupal integration
<!-- -->
<!-- -->
-
Automatic font color problem in dark mode when we have background
color-
Fixed:
-
https://gerrit.libreoffice.org/c/core/+/165017 (master)
has problem on libreoffice CI waiting for verification -
https://gerrit.libreoffice.org/c/core/+/165024 (co-24.04)
waiting for review -
Reviewed, and detected a regression when one user is dark
other user light mode.- Currently working on that, then it will be merged.
-
-
-
Writer: Rotation Angle tooltip "stuck"
(GH#8045)- Merged : https://github.com/CollaboraOnline/online/pull/8594
- Reviewed: Chrome is ok but firefox still problematic I’ll turn
back here.
-
Paused to working on Calc “Edit Current Style” gear on sidebar.
Present on Writer but not in Calc.- It doesn’t implemented on core. So I need to work on core first
<!-- -->
<!-- -->
<!-- -->
<!-- -->
- CI is OK 80% of the time, still some issues with make parallelism
(or with restrictions in container wrt. bind mounting jails)
<!-- -->
<!-- -->
- Chasing PRs, some fixes to go
<!-- -->
<!-- -->
<!-- -->
<!-- -->
<!-- -->
<!-- -->
- **25/04/2024 **