Community Weekly Meeting #150

[pedro.silva]

Collabora Online Weekly Meeting #150

Date: Jan 4th 2024

All minutes published on: Topics tagged meeting-minutes

Attendees (write your name):

1. Andras, Cosmin, Timur, Attila, Gulsah, Darshan, Bayram, Hub, Mike D, Michael, Vivek, Szymon, Julius, Krish Aryan, Méven Car, Thorsten

Making the call shorter

• Please update your section relating in the document before we read through it.
• Then only go over anything we need to share / get input on

Release Schedule

1. CODE 23.05.6 Week 50 Released!
2. Preparing new CODE 23.05.7 in 1-2 weeks (bugfixes)
3. Mobile releases
4. iOS 23.05.7 planning to release in Jan
   1. TestFlight link: Join the Collabora Office beta - TestFlight - Apple
   1. Tester count: 1346 – so people know this link!
5. Android 23.05.7 planning to release in Jan
6. need to fix insert → comments on Mobile.
   1. Vivek Has some improvements here
   1. now merged

AI: Test view jump again next time

Julius

• New release pending for later today
  • Spreadsheet status bar show by default
  • Version access for shared files (server release 27.1.5, released)
  • For Nextcloud 28 additional things landed (new major version coming next week)
    • Improved setup checks to make setup errors easier to fix for admins
      • Improve setup checks and url handling with separate callback url by juliushaertl · Pull Request #3315 · nextcloud/richdocuments · GitHub
    • Additional option to configure URL for internal communication between Nextcloud/online
• Sidebar concerns:
  • [stable27] fix: Avoid triggering a defered sidebar open if openFile is already handling that by juliushaertl · Pull Request #41636 · nextcloud/server · GitHub merged
    • Now released with 27.1.5
• Open in new tab by default (?)
  • UX testing feedback tells us that files in new tabs is a serious issue
    • Plan to tackle all the things that are not working (middle click etc)
  • Google opens in a new tab by default (Nicolas)
  • A website that is an application: a “file explorer” (Pedro)
    • user expects, the file opens – something new happens.
  • May be needed inside the Nextcloud server – not in richdocuments (Julius)
  • Update: Discussion in our weekly meeting with designers
    • We’ll as a first step look into making ctrl click/middle mouse click/back buttons in the browser work/behave correctly
• WASM
  • WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
    • richdocuments pull request ready, what version is wasm expected for?
    • No pressing needs, let’s just merge this for main branch
• Issue with renaming documents failed, opening was no longer possible afterwards
  • Julius will check logs and report at online with more details

Nicolas

Cosmin

• Discovered that the menu is truncated in narrow windows, while the toolbar is scrollable.
  • The behaviour is the same in LibreOffice.
  • Is this worth a feature-request, or is it by design?
    • No, it’s in compact mode which is to be deprecated

Online activity

• Bugs caught during this meeting

  • Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
    • Issue: AI(Pedro): To file bug

• Attila

  • Working on PPTX Align problem
    134401 – FILESAVE PPTX: vertical alignment inverted (bottom<->top) when saving textbox with link
    It is not really an align problem, hopefully exporting/importing an other setting will help here.
    Note: (the root of the problem: The same text in Powerpoint ~1% wider then in Impress)
  • Working on PPTX Hyperlink problem
    154248 – FILEOPEN PPTX: multiline field wrapping breaks rendering of links (and font changes)
    fixed the color change problem (not made PR yet)
    tried to replace field with simple text for render case… it seems to work, but broke a lot of things… hopefully I can fix the regressions.
  • Language problems:
    found the createView Problem… maybe it is not important? (at local server it don’t use language option in default case (doc_createViewWithOptions) but maybe in release will it always filled?
    Miklos plan to take this task.

• PRs without reviewer 8

  • Collabora Online · GitHub
    • Don't select columns, when clicks are over resize area by mikekaganski · Pull Request #7910 · CollaboraOnline/online · GitHub
    • browser: fix triple click event by hcvcastro · Pull Request #7931 · CollaboraOnline/online · GitHub
    • browser: adjust initial annotation height by hcvcastro · Pull Request #7873 · CollaboraOnline/online · GitHub

• Szymon

  • Worked on view jumping
    • fixed jumps on click on large cell
  • Fixed dropdown closing on sidebar (previously needed to click twice to open again)
  • Working on autofilter cypress test
    • it was not working due to “inactive user”, some regression from vex removal
  • Fixed GH#7885: Crash after updating to 25.05.6.4 · Issue #7885 · CollaboraOnline/online · GitHub warn when lok_allow has incorrect host defined
  • Improved logs in case of “syntax” error so we can debug and fix the problem

• Darshan

  * More cypress test “AutoFilter” [7879](https://github.com/CollaboraOnline/online/pull/7879) => **Merged**
  * Small fix for typing text in font and style input dropdown dark in Dark mode [7867](https://github.com/CollaboraOnline/online/pull/7867)=> **Merged**
  * Dark mode fix for read only mode :https://github.com/CollaboraOnline/online/pull/7906 Resolves: https://github.com/CollaboraOnline/online/issues/7888 => **Merged**
  * tunnelling jsdialogbox fix for OLE object: https://gerrit.libreoffice.org/c/core/+/161582 => **Merged**
  * working on line breaking and spacing issue for some jsDialog boxes.
    * already added fix for radio buttons which are not fully visible
    * Improvement in spinfield container class. #[7937](https://github.com/CollaboraOnline/online/pull/7937) => **In review**
  * WIP: Calc: Dark-on-Dark '=' Icon + Groups #7752
  * Filled android issue : https://github.com/CollaboraOnline/online/issues/7936
  

• Vivek

  • Work in progress - Scroll bar animation on mouse hover event (pause)
    • Calc: Implement JavaScript animation on mouse event by codewithvk · Pull Request #7218 · CollaboraOnline/online · GitHub
  • Comment dialogue looking odd in mobile view
    • Mobile: Insert comment layout is too narrow and doesn't occupy full height by codewithvk · Pull Request #7719 · CollaboraOnline/online · GitHub => Merged
    • Mobile: Resolve issue where busy popup covers the whole document ( Mobile: Change the full height of the busy popup to narrow by codewithvk · Pull Request #7891 · CollaboraOnline/online · GitHub ) => In Review
  • Android Insert Cell Menu Misaligned Radio Button => Merged
    • Android: Insert Cells Menu Misaligned Radio Buttons by codewithvk · Pull Request #7736 · CollaboraOnline/online · GitHub
  • Many Icons Not Inverting Color In Dark mode cool-help => Merged
    • Fix: Many Icons Not Inverting Color In Dark mode cool-help by codewithvk · Pull Request #7796 · CollaboraOnline/online · GitHub
  • Make format condition, chart delete and pivot table error async - https://gerrit.libreoffice.org/c/core/+/160557 - In Review
  • Make ‘File > Repair’ date and time human-readable - Make 'File > Repair' date and time human-readable by codewithvk · Pull Request #7911 · CollaboraOnline/online · GitHub => Merged
  • jsdialog: enable calc formula error dialog - https://gerrit.libreoffice.org/c/core/+/161592 => Merged
  • make formula entry dialogs async => WIP
  • wasteful commandvalues CharFontNAme – WIP
  • Difficulties with delayed document title => WIP

• Michael / Caolan – Performance

  • Potential optimization for menubar updating seen in COOL call where we probably don’t need that effort
    • https://gerrit.libreoffice.org/c/core/+/160465 to review, after current release
  • Mystery case of another apparent viewid mismatch with a single user and new calc document outstanding

• Testing results:

  • Dark mode now working nicely.
  • Found some good problems from calc:
    • generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
      • may be a red-herring.

• Bayram

  • Calc: sheet drop zone is too small · Issue #7813 · CollaboraOnline/online · GitHub - Calc: sheet drop zone is too small #7813
    • Status: Closed – Fixed
    • (Merged) Calc: improve drag&drop functionality of sheet tabs by bayramcicek · Pull Request #7846 · CollaboraOnline/online · GitHub
    • (Merged) Calc tabs: remove drop zone indicator after drop by bayramcicek · Pull Request #7855 · CollaboraOnline/online · GitHub
  • (WIP) Bug: “Calc: collapsing groups does not hide its child groups”
  • (WIP) Bug: “Calc: Impossible to create same level groups #7811” - Calc: Impossible to create same level groups · Issue #7811 · CollaboraOnline/online · GitHub (High priority bug)
    • Patch is almost done. The patch will fix these two -similar but different- grouping bugs - because the root of the problem for the two bugs are the same (indexing issue, some groups are failing to find their parent group). There are some edge cases need to be fixed.

• Skyler

  • Got a few changes which need review, all tests have passed on all of them. Bold ones are more important
  • Calc keyboard popping down
    • Waiting for review on https://gerrit.libreoffice.org/c/core/+/160313 → someone to test it before merging it
    • May be nice to get another review on Stop onscreen keyboards closing when used to move by Minion3665 · Pull Request #7797 · CollaboraOnline/online · GitHub
  • Touchscreen fixes
    • Need reviews on Followup to unified touch handling by Minion3665 · Pull Request #7712 · CollaboraOnline/online · GitHub
    • May want second followup to investigate 2 more dubious lines from the first commit, out-of-scope for this followup as I think they’ll take longer than I want to wait to merge this

• Pranam

  • Revamp comment autosave feature
    • Reverted all the previous patches of the feature
    • More simple implementation using existing workflow
    • Hopefully will remove comment regressions
    • Then new cypress test for autosaved comments (multiple users) will also be needed

• Gökay

  • Working on a read only mode feature that will allow clicking on a hyperlink.
    • Writer is done.
    • Working on Calc and Impress implementations.
  • Impress mobile view:
    • Long press and select “cut” from the context menu.
    • Done. To be tested by QA.

• Hubert

  • Started some of the Draw (and by extension Impress) improvement work.
    • No change
    • Bug Draw: Select+Drag make drag without feedback · Issue #7821 · CollaboraOnline/online · GitHub will need to be tackled.
  • Merged More postmessage test harness: framed.doc: Added postmessage for Get_User_State by hfiguiere · Pull Request #7876 · CollaboraOnline/online · GitHub

• Gulsah

  • Editing a cell without exiting the cell edit mode and then clicking the ‘+’ to insert a new sheet moves the entered content into that new sheet.

    • Fixed: https://gerrit.libreoffice.org/c/core/+/160758
    • Backported: https://gerrit.libreoffice.org/c/core/+/161583

  • Overwrite follow up PR of configurable override mode

    • Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
      • I triggered the cypress test several time but failed on unrelated part.
      • Cypress tests locally failed too but couldn’t return back to work this.

  • Calc: Columns and rows are not activated on mouseDown

    • 0.34 sec to complete for each column selection. Problem is not exist in core because mousebuttondown is handling quickly there. In online we send uno commands for each selected column. Discussed with szymon and he thinks we should keep the uno command and find a way to speed up that method.
    • I paused to work on, will turn back again.

  • Calc: Conditional formatting dialog title is too large

    • I’m about to solve this.

• Andras

  • No update

• Pedro

• Mike D

  • LanguageTool: a strange/interesting bug on LO. Will look into this.
    • New LanguageTool extension for LO just got released yesterday.

• Méven

  • Newcomer, reading bits here and there

Forum (Mike D)

5 new posts this week.

Key topics:

• Weblate Stats: December 2023
  • Latest Weblate Stats
• Disable spell correction permanently - #2 by Tex
  • User in “read-only” XLSX cannot turn off spellchecking, so everything was underlined in red squigglies.
  • → Told them to submit to Github.
  • Note: Spellchecking should probably be allowed in “read-only”.

And then a few more normal posts that need more debug info:

• Can't Save on Mobile
  • another person on mobile where files don’t save modifications.
• Can't load file in collabora online
  • Nextcloud user “can’t load” certain files "unless he restarts service".

11 → 11 - zero replies in user support:

→ User Support - Collabora Online

37 → 38 - zero replies in installation and config:

→ Installation & Configuration - Collabora Online

Next events

• COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – COOL Days 2024 - 8-10 April - Cambridge, UK - Collabora Office and Collabora Online
• We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
  • What to do next
    • Passport & VISA
    • Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
    • Apply for a VISA if needed.
  • Register for the event: https://eventyay.com/e/0512424d
  • Submit a talk:
    • https://eventyay.com/e/0512424d/cfs

Next meeting

• 11/01/2024