Collabora Online Weekly Meeting #130
Date: Aug 3rd 2023
All minutes published on: Topics tagged meeting-minutes
Attendees (write your name):
- Darshan, Szymon, Anna, Mike D (Tex), Shehr, Gulsah, Pedro, Timur, Nicolas, Pranam, Oli, Caolán, Thorsten, Aron, Gokay, Andras, Ezinne
Release schedule (Andras)
- Mobile releases probably at the end of August
- Next iOS testflight – Attila is on it;
- no clear date when to release yet
- Atilla found 2 bugs related to navigator (probably affects Android also):
- Double click not working
- Safari normally uses double click to another function maybe that is why the click function is never called
- it tries to use combobox that we don’t use (will be fixed on core)
- Double click not working
- Android
- same as iOS
- Next iOS testflight – Attila is on it;
Forum (Mike D)
Answered a few more forum questions. (This time I ventured into the “Installation & Configuration” section + dabbled in a few docker questions.)
These were the key topics:
16->16 - zero replies in user support:
→ User Support - Collabora Online
62->62 - zero replies in installation and config:
→ Installation & Configuration - Collabora Online
Dark mode
- Missing slide previews
- We request the previews but get an error instead form the server side
- We have some error in the server side and doesn’t correspond tot he request → Szymon prepared a workaround: Mark slide preview as fetched when it arrives by eszkadev · Pull Request #6942 · CollaboraOnline/online · GitHub
- But Paris will look at the root cause. Now has a PR ready: Draw dark mode fixes by OFFTKP · Pull Request #6985 · CollaboraOnline/online · GitHub
Online activity (Pedro)
-
PRs without reviewer ~8 of them
- Collabora Online · GitHub
- Add action for detecting code duplicates #6802 Szymon will check this
- Collabora Online · GitHub
-
Oli
- Next → Up and down arrow keys should move focus up/down a level · Issue #6933 · CollaboraOnline/online · GitHub → Darshan reviewed , waiting for requested changes
-
Gokay
- Button-ids are non-deterministic; will make them deterministic. So we don’t randomly generate unique IDs but instead use a more semantic approach based configuration file. Szymon requested changes: Provide unique ids for notebookbar buttons. by gokaysatir · Pull Request #6801 · CollaboraOnline/online · GitHub
- Big changes, we need to wait
- a11y fixes:
- Tabbed view: Dropdown menus and color pickers
- Now insert table
- Darshan: Claimed Reset access key when focus goes away : Add reset accessibilityKey by Darshan-upadhyay1110 · Pull Request #6979 · CollaboraOnline/online · GitHub
- Button-ids are non-deterministic; will make them deterministic. So we don’t randomly generate unique IDs but instead use a more semantic approach based configuration file. Szymon requested changes: Provide unique ids for notebookbar buttons. by gokaysatir · Pull Request #6801 · CollaboraOnline/online · GitHub
-
Attila
- Now working on iOS → now debugging
- Working on navigator related bugs
-
Szymon
- PPTX import bugs (master slide formatting inside of shapes)
-
Darshan
- Allow insert_button postmessage to take an additional value: tablet: Add check for Insert_buttons to display in tablet view by Darshan-upadhyay1110 · Pull Request #7005 · CollaboraOnline/online · GitHub
- Then on richdocuments side make sure open_with_local_editor button is inserted with tablet:false →Add tablet parm for Insert_Button by Darshan-upadhyay1110 · Pull Request #3094 · nextcloud/richdocuments · GitHub
-
Michael / Caolan – Performance
- Found some good problems from calc:
- calc performance with large selections - copy/paste · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection nightmare which we try to do on keypresss – consuming vast memory & time.
- Performance improvements for comments in spreadsheets → ready to review :
- Found some good problems from calc:
-
Shehr Pushed
-
UITreeview doesn’t use all the available spaceCould reproduce when change orientation: ui-treeview doesn't extend the avaialble vertical space · Issue #6977 · CollaboraOnline/online · GitHub
- Pedro helped reproduce this.
- Has PR with the commit fix but needs to be clean (multiple commits)
-
-
Skyler
- Busy with using UNO with websocket
- https://gerrit.libreoffice.org/c/core/+/154680
- websocket we already use the prefixes so I didn’t want to change that. Rather than using uno I use URP. Lets me send messages between core and the java URP client through COOLWSD!
-
- Why not Java/C++? I though it would be easier to get it going.
- Now → Trying to understand why I’m getting protocol violations: I’ve now got a document that I wrote using my Java client over URP over websockets!!
- it’s a basic hello world document and it’s trapped inside the jail right now but it exists and it works
-
Pranam
- Now adding accessibility identifiers to some elements: FAB (pencil button) on touch devices → reviewed → requested changes accessibilty: added accessibilty fields to the mobile edit button by lpranam · Pull Request #6973 · CollaboraOnline/online · GitHub
-
Gulsah
- Waiting for reviews
- Impress: slide sorter: enabling context menu (to insert slide and paste slide) merged
- Improvement: allow insert new slide in between existing slides → postponned for now
- trouble with referring to slides with numbers, since they get invalidated on reorder or insert or delete
- Difficult to know where the slide reordering happens → so, paused for now
- Comparing now the drag n drop status and the insert new slide
- Trying to find slide id
- Improvement: allow insert new slide in between existing slides → postponned for now
- Switched to avoid multiple child dialogs to be open → a core side problem
- Now → Trying to understand why full screen presentation freezes when using Firefox
- Web Browser Console: warning message fullscreen denied. Maybe related to invoke method
- warning is “Fullscreen request denied, not called from inside a short running user-generated event handler.
- Web Browser Console: warning message fullscreen denied. Maybe related to invoke method
- Impress: slide sorter: enabling context menu (to insert slide and paste slide) merged
- Waiting for reviews
-
Rashesh
- Created a issue: customize tab missing from Bullets and numbering dialog
Customize tab not available in Bullets and Numbering dialog · Issue #6777 · CollaboraOnline/online · GitHub- Skyler is working on this; Szymon requested changes https://gerrit.libreoffice.org/c/core/+/153806
- Working: Fix android bugs by Rash419 · Pull Request #6912 · CollaboraOnline/online · GitHub
- Created a issue: customize tab missing from Bullets and numbering dialog
-
Nicolas
- Plan to file some issues wrt DeepL
-
Timur
- I have seen a couple of crash reports from Staging or Demo where either themes and/or sidebar were involved, but that was not reproducible
- Themes
- Now Noel fix for Themes got in https://gerrit.libreoffice.org/c/core/+/154836 → we need now to see more of those reports appear → fixed and merged
- Format - theme dialog selects the theme for the document, available from LO 7.6 and Online 23.05, it is in CODE 23.05 Press Release - Collabora Office and Collabora Online
- 23.05 Android web browser cannot run presentation with default slide (by default has no background)
- 23.05 Android app snapshot: cannot open ODP
Community
- Translation stats to go out soon → SM and Forum
LibreOffice conference (Gabriel)
- Mike’s talk got accepted
- Szymon, Caolan, Thorsten
- Still busy organizing the conference
-
- spreading the ideas through different means is good.
- Will be in Bucharest – and Gabriel will be organizing it too.
- LibreOffice Conference 2023 in Bucharest, Romania - The Document Foundation Blog
- Call for papers went out
- Registration is now open
- You are invited to the “Introduction in LibreOffice Development” workshop:
Next meeting
10/08/2023