Community Weekly Meeting #132

pedro.silva · August 21, 2023, 5:39am

Collabora Online Weekly Meeting #132

Date: Aug 17th 2023

All minutes published on: Topics tagged meeting-minutes

Attendees (write your name):

Michael, Cosmin, Mike D, Pedro, Caolan, Gulsah, Szymon, Darshan, Aron, Attila, Rashesh, Nicolas, Gökay

Release schedule

Anna and Andras out on vacation
Mobile releases probably at the end of August
- Next iOS testflight – Attila is on it;
  - no clear date when to release yet
  - Attila found 2 bugs related to navigator (probably affects Android also):
    - Double click not working
      - Safari normally uses double click to another function maybe that is why the click function is never called: ios: fix doubleclick in navi, with single clicks by aszucs3 · Pull Request #7028 · CollaboraOnline/online · GitHub
        
        Reviewed by Szymon
    - it tries to use combobox that we don’t use (will be fixed on core)
- Android
  - Fixed 2 blockers: didn’t respect dark mode; didn’t open impress files
    - It still needs to be tested (look for crashes)
    - dark mode fix: android: enable dark mode in documents by Rash419 · Pull Request #7036 · CollaboraOnline/online · GitHub
    - impress fix(cherry-pick): https://gerrit.libreoffice.org/c/core/+/155445
    - crash after closing a doc: android: fix app crashes after closing the document by Rash419 · Pull Request #7078 · CollaboraOnline/online · GitHub
    - some mobile view fixes:
    - All are merged (Rashesh)
    - working on: mobile wizard becomes empty when Character/Paragraph when you press back button, something wrong with _currrentDepth property
    - next: update android dependencies, ndk, gradle, gradle plugin
CODE 23.05.3 will probably be released in Aug 25th

Online activity (Pedro)

PRs without reviewer 6
- Collabora Online · GitHub
  - https://gerrit.libreoffice.org/c/core/+/155079 → Caolan to check it again
  - Add action for detecting code duplicates #6802 Szymon will check this → now merged
    - This was reverted, too big of a threshold → probably best to move it to make check (and use only that npm package)
Dark mode
- Mobile: user could get stuck in one or the other theme (dark/light)
  - Add missing dark mode toggle in mobile view by Darshan-upadhyay1110 · Pull Request #7095 · CollaboraOnline/online · GitHub (Darshan)
    - Rashesh to review
  - Later we probably should double check the android app shell toggle
Design
- Added button/menu toggles for tabs state (collapse/expand) and menu bar (hide/show on compact view → Thanks Maks Wolkowinski
- Pedroaaa
  - Properly expose tabs name to screen reader → merged
  - UI treeview improvements
  - we are generating the close button of JSDialogs using combination of jquery and jquery -ui
Oli
- Next → Up and down arrow keys should move focus up/down a level · Issue #6933 · CollaboraOnline/online · GitHub → Darshan reviewed, waiting for requested changes
  - https://github.com/CollaboraOnline/online/pull/6972 Oli will check that
    - Gokay added a few code pointers. Oli on it, almost finished.
Gokay
- Button-ids are non-deterministic; will make them deterministic. So we don’t randomly generate unique IDs but instead use a more semantic approach based configuration file. Szymon requested changes: Private/gokay/js dialogs ids by gokaysatir · Pull Request #7034 · CollaboraOnline/online · GitHub (merged)
  - Some icons are invisible
Attila
- Now working on iOS → now debugging
- Working on navigator related bugs (all fixed)
Szymon
- Also working font previews (so the font drop-down menu will display the font name in its font)
  - has a working proof of concept
- Cypress test fixes:
- Fullscreen Presentation bugs
  - on iPhone → Don't show presentation on iOS in small frame · CollaboraOnline/online@2eda474 · GitHub (now merged)
  - Fullscreen on chrome →cool#7102 fix 2nd presentation under chrome not appearing · CollaboraOnline/online@89f283c · GitHub (now merged)
  - Fullscreen on FF → Gulsah on it
    - Permission was always false
      - When the document is not active the typeerror can happen again
    - Deprecated moz* method
Darshan
- WIP: Print single calc sheet: [ WIP ] Add option for print sheet by Darshan-upadhyay1110 · Pull Request #7035 · CollaboraOnline/online · GitHub
  - Szymon sent code pointers, investigating now
  - It’s now working but Darshan found another existing bug
    - Nick is now on the exportas bug (export document with empty sheets causes the bug)
  - Next mobile issues
Michael / Caolan – Performance
- Found some good problems from calc:
  - calc performance with large selections - copy/paste · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection nightmare which we try to do on keypresss – consuming vast memory & time. → probably needs more info.
  - Performance improvements for comments in spreadsheets → now merged:
    - cool#6911 calc comment positions are now cell addresses by caolanm · Pull Request #6988 · CollaboraOnline/online · GitHub
    - Draw calc note indicator browser side by caolanm · Pull Request #7001 · CollaboraOnline/online · GitHub
- Now working on comment import performance
Skyler
- Busy with using UNO with websocket
  - https://g errit.libreoffice.org/c/core/+/154680
  - Wrote a small python server to bridge websockets to regular tcp sockets (GitHub - Minion3665/collabora--urp-ws-proxy: A websocket proxy for interpreting UNO Remote Protocol (presumably transmitted between COOLWSD and a client of your choice)). Why not Java/C++? I though it would be easier to get it going and it won’t be needed by the end.
  - websocket we already use the uno prefix for uno commands so I didn’t want to change that. Rather than using UNO I use URP for ‘uno remote protocol’.
    - Lets me send messages between core and the java URP client through COOLWSD without breaking existing commands!
    - I have a small ‘sidecar’ toy app to write some URP for testing GitHub - Minion3665/com.collabora.productivity.skyler.sidecar: A toy sidecar app for modifying collabora office documents with UNO commands
  - Fixed URP protocol violations
  - I’ve now got a document that I wrote using my Java client over URP over websockets!!
    - it’s a basic hello world document and it’s trapped inside the jail right now but it exists and it works
  - Got Java-Websocket library to download when building core, gerrit CI is now passed for the first change [adding coreside bridge] and mostly passed for the second change [adding Java connector] (macos and linux passed, windows is queued but passed previously and I expect to still be fine, github CI depends on gerrit changes)!
  - Now → Considering security, as URP allows you to run macros without confirmation/execute shell commands etc.
    - Written a small counterpart to my original toy ‘sidecar’ dubbed ‘siderce’ to test this
    - Added an option under security to enable URP over websockets (disabled by default)
      - Discussed with Pedro in our weekly mentor meeting
- Re-enabled the “bullets and numbering” customize tab → merged
- Collabora Online hangs locally: Collabora Online connections hang when a relative LO path is used · Issue #7041 · CollaboraOnline/online · GitHub → A.I.: Pedro to ping Timur
Gulsah
- Waiting for reviews
  - Now → Trying to understand why full screen presentation freezes when using Firefox
    - Web Browser Console: warning message fullscreen denied. Maybe related to invoke method
    - warning is “Fullscreen request denied, not called from inside a short running user-generated event handler.
    - It seems now that hang is only sporadic.
      - Open impress
      - Wait 5 min
      - Click presentation button on tab = hang
Nicolas
- Plan to file some issues wrt DeepL
Timur
- I have seen a couple of crash reports from Staging or Demo where either themes and/or sidebar were involved, but that was not reproducible
- Themes
  - Now Noel fix for Themes got in https://gerrit.libreoffice.org/c/core/+/154836 → we need now to see more of those reports appear → fixed and merged
  - Format - theme dialog selects the theme for the document, available from LO 7.6 and Online 23.05, it is in CODE 23.05 Press Release - Collabora Office and Collabora Online
- 23.05 Android web browser cannot run presentation with default slide (by default has no background)
- 23.05 Android app snapshot: cannot open ODP – This has been fixed: https://gerrit.libreoffice.org/c/core/+/155445
Mike D
- I also answered this weird question about accidentally deleting “Arrow Styles / Line Styles” in LO:
  - Reddit - Dive into anything
- which lead me to poke around COOL and found bugs/quirks:
  - Insert > Shapes
    - Arrow/Line Styles menus? (Odd rendering/layouts?)
  - Insert > Fontwork
    - Odd trying to select object + typing text.
  - Insert > Vertical Text
    - Cursor stays vertical, should flip to horizontal to make it easier to see where you’ll type.

Forum (Mike D)

These were the key topics:

Good to see comments/movement on the “ch units” bug.
- Github Issue #6984
Weird “underline shrink/stretch depending on zoom level” bug.
- I narrowed it down to LO Bug #156681, which was regression between LO 7.5.4+7.5.5.
- Also happens in COOL. (I just tested.)
3rd user within the past few weeks had this “systemplate directory is read-only” issue
- ERR unknown UI default's component UITheme + WRN The systemplate directory is read-only
  - I left a few messages in Mattermost.
  - If I search “systemplate”, I found messages going back about a year, but haven’t looked through yet.

Still unanswered from last week:

This person asking about Japanese Phonetic Guides:
- Unable to use phonetic guides
  - (Is this possible in COOL?)
- LibreOffice 7.5 Help: “Asian Phonetic Guide”
- Wikipedia.org: “Ruby Characters”
- One of my older Reddit posts on LO + Japanese Ruby Text

16->16 - zero replies in user support:

→ User Support - Collabora Online

62->62 - zero replies in installation and config:

→ Installation & Configuration - Collabora Online

Community

LibreOffice conference (Gabriel)

Mike’s talk got accepted
Szymon, Caolan, Thorsten
Still busy organizing the conference
- spreading the ideas through different means is good.
Will be in Bucharest – and Gabriel will be organizing it too.
- LibreOffice Conference 2023 in Bucharest, Romania - The Document Foundation Blog
- Call for papers went out
- Registration is now open
- You are invited to the “Introduction in LibreOffice Development” workshop:

Next meeting

24/08/2023

Topic	Replies	Views
Community Weekly Meeting #130 Development meeting-minutes	267	August 4, 2023
Community Weekly Meeting #131 Development meeting-minutes	295	August 10, 2023
Community Weekly Meeting #133 Meeting Minutes meeting-minutes	270	August 24, 2023
Community Weekly Meeting 125 Development meeting-minutes	266	July 3, 2023
Community Weekly Meeting 127 Development meeting-minutes	240	July 13, 2023