Community Weekly Meeting #131

[pedro.silva]

Collabora Online Weekly Meeting #131

Date: Aug 10th 2023

All minutes published on: Topics tagged meeting-minutes

Attendees (write your name):

• Andras, Pedro, Shehr, Skyler, Caolán, Cosmin, Mike D (Tex), Gülşah, Anna, Darshan, Szymon, Gökay, Oli, Rashesh, Aron

Release schedule (Andras)

• Mobile releases probably at the end of August
  • Next iOS testflight – Attila is on it;
    • no clear date when to release yet
    • Atilla found 2 bugs related to navigator (probably affects Android also):
      • Double click not working
        • Safari normally uses double click to another function maybe that is why the click function is never called
      • it tries to use combobox that we don’t use (will be fixed on core)
  • Android
    • Fixed 2 blockers: didn’t respect dark mode; didn’t open impress files
      • It still needs to be tested (look for crashes)
• CODE 23.05.3 will probably be released in Aug 25th

Online activity (Pedro)

• PRs without reviewer 7

  • Collabora Online · GitHub
    • Add action for detecting code duplicates #6802 Szymon will check this → now merged
      • But PRs from forked repositories are not passing this test. The GH action has no permissions, user needs to enable that in the forked repository. A.I. write this down somewhere (ideally in the GH action error message) → Pedro

• Dark mode

  • Missing slide previews. We request the previews but get an error instead form the server side
  • Error in the server side and doesn’t correspond to the request → Szymon prepared a workaround: Mark slide preview as fetched when it arrives by eszkadev · Pull Request #6942 · CollaboraOnline/online · GitHub
    • But Paris will look at the root cause. Now has a PR ready: Draw dark mode fixes by OFFTKP · Pull Request #6985 · CollaboraOnline/online · GitHub → now merged

• Design

  • Added button/menu toggles for tabs state (collapse/expand) and menu bar (hide/show on compact view → Thanks Maks Wolkowinski
  • Pedro
    • Properly expose tabs name to screen reader
    • UI improvements on admin
    • Welcome: allow scrollbar when needed (affects for mobile)

• Oli

  • Next → Up and down arrow keys should move focus up/down a level · Issue #6933 · CollaboraOnline/online · GitHub → Darshan reviewed , waiting for requested changes
    • Up and down arrow work for notebook bar by CosmicOli · Pull Request #6972 · CollaboraOnline/online · GitHub Oli will check that
      • Gokay added a few code pointers. Oli on it, almost finished.

• Gokay

  • Button-ids are non-deterministic; will make them deterministic. So we don’t randomly generate unique IDs but instead use a more semantic approach based configuration file. Szymon requested changes: Private/gokay/js dialogs ids by gokaysatir · Pull Request #7034 · CollaboraOnline/online · GitHub
    • Big changes, we need to wait now working on this. Notebookbar definition files (the json) now have accessibility and id are in the same place (not anymore in th jsdialogBuilder)
  • a11y fixes:
    • Tabbed view: Dropdown menus and color pickers → merged
    • Now insert table → merged
    • Darshan: Claimed Reset access key when focus goes away : Add reset accessibilityKey by Darshan-upadhyay1110 · Pull Request #6979 · CollaboraOnline/online · GitHub → merged

• Attila

  • Now working on iOS → now debugging
  • Working on navigator related bugs

• Szymon

  • PPTX import bugs (master slide formatting inside of shapes)
    • https://gerrit.libreoffice.org/c/core/+/154980 → now merged
  • Dark mode support for element rendered in the core
  • Also working font previews (so the font drop-down menu will display the font name in its font)

• Darshan

  • Allow insert_button postmessage to take an additional value: tablet: Add check for Insert_buttons to display in tablet view by Darshan-upadhyay1110 · Pull Request #7005 · CollaboraOnline/online · GitHub → merged
  • Fix local editor after view change:
    Remove open_local_editor button in tablet view by Darshan-upadhyay1110 · Pull Request #7039 · CollaboraOnline/online · GitHub → now merged also (before it would insert the button on tablet when switching the UI view)
  • Then on richdocuments side make sure open_with_local_editor button is inserted with tablet:false →Add tablet parm for Insert_Button by Darshan-upadhyay1110 · Pull Request #3094 · nextcloud/richdocuments · GitHub → merged
    • Backported to latest stable richdocuments branches (26 and 27)
  • WIP: Print single calc sheet : [ WIP ] Add option for print sheet by Darshan-upadhyay1110 · Pull Request #7035 · CollaboraOnline/online · GitHub
    • Szymon sent code pointers, investigating now

• Michael / Caolan – Performance

  • Found some good problems from calc:
    • calc performance with large selections - copy/paste · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection nightmare which we try to do on keypresss – consuming vast memory & time. → probably needs more info. A.I. Pedro to find the document
    • Performance improvements for comments in spreadsheets → now merged:
      • cool#6911 calc comment positions are now cell addresses by caolanm · Pull Request #6988 · CollaboraOnline/online · GitHub
      • Draw calc note indicator browser side by caolanm · Pull Request #7001 · CollaboraOnline/online · GitHub
  • Now working on comment import performance

• Shehr

  • UITreeview doesn’t use all the available space. Could reproduce when change orientation: ui-treeview doesn't extend the avaialble vertical space · Issue #6977 · CollaboraOnline/online · GitHub → now merged
  • Now working on JSDialog: label vs textarea vs input field inconsistent paddings #7037 → has local changes will then force push

• Skyler

  • Busy with using UNO with websocket
    • https://gerrit.libreoffice.org/c/core/+/154680
    • Wrote a small python server to bridge websockets to regular tcp sockets (GitHub - Minion3665/collabora--urp-ws-proxy: A websocket proxy for interpreting UNO Remote Protocol (presumably transmitted between COOLWSD and a client of your choice)). Why not Java/C++? I though it would be easier to get it going and it won’t be needed by the end.
    • websocket we already use the uno prefix for uno commands so I didn’t want to change that. Rather than using UNO I use URP for ‘uno remote protocol’.
      • Lets me send messages between core and the java URP client through COOLWSD without breaking existing commands!
      • I have a small ‘sidecar’ toy app to write some URP for testing GitHub - Minion3665/com.collabora.productivity.skyler.sidecar: A toy sidecar app for modifying collabora office documents with UNO commands
    • Fixed URP protocol violations
    • I’ve now got a document that I wrote using my Java client over URP over websockets!!
      • it’s a basic hello world document and it’s trapped inside the jail right now but it exists and it works
    • Got Java-Websocket library to download when building core, gerrit CI is now passed for the first change [adding coreside bridge] and mostly passed for the second change [adding Java connector] (macos and linux passed, windows is queued but passed previously and I expect to still be fine, github CI depends on gerrit changes)!
    • Now → Considering security, as URP allows you to run macros without confirmation/execute shell commands etc.
      • Written a small counterpart to my original toy ‘sidecar’ dubbed ‘siderce’ to test this
      • Added an option under security to enable URP over websockets (disabled by default)
        • Discussed with Pedro in our weekly mentor meeting
  • Re-enabled the “bullets and numbering” customize tab → merged
  • Collabora Online hangs locally: Collabora Online connections hang with a fresh build · Issue #7041 · CollaboraOnline/online · GitHub → A.I.: Pedro to ping Timur

• Pranam

  • Now adding accessibility identifiers to some elements: FAB (pencil button) on touch devices → reviewed → requested changes accessibilty: added accessibilty fields to the mobile edit button by lpranam · Pull Request #6973 · CollaboraOnline/online · GitHub → now merged

• Gulsah

  • Waiting for reviews
    • Switched to avoid multiple child dialogs to be open → a core side problem
      • Fixed and merged: https://gerrit.libreoffice.org/c/core/+/154514
      • https://gerrit.libreoffice.org/c/core/+/155083
      • Now also backported
    • Now → Trying to understand why full screen presentation freezes when using Firefox
      • Web Browser Console: warning message fullscreen denied. Maybe related to invoke method
      • warning is “Fullscreen request denied, not called from inside a short running user-generated event handler.
      • It seems now that hang is only sporadic.
        • Open impress
        • Wait 5 min
        • Click presentation button on tab = hang

• Rashesh

  • Created a issue: customize tab missing from Bullets and numbering dialog
    Customize tab not available in Bullets and Numbering dialog · Issue #6777 · CollaboraOnline/online · GitHub → fixed by Skyler
    • Skyler is working on this; Szymon requested changes https://gerrit.libreoffice.org/c/core/+/153806
    • Working: Fix android bugs by Rash419 · Pull Request #6912 · CollaboraOnline/online · GitHub → merged
    • Mobile
      • android: enable dark mode in documents
      • fix: cursor jump when hyperlink popup clicked in mobileview #7050
      • Crashes when opening multiple file rapidly

• Nicolas

  • Plan to file some issues wrt DeepL

• Timur

  • I have seen a couple of crash reports from Staging or Demo where either themes and/or sidebar were involved, but that was not reproducible
  • Themes
    • Now Noel fix for Themes got in https://gerrit.libreoffice.org/c/core/+/154836 → we need now to see more of those reports appear → fixed and merged
    • Format - theme dialog selects the theme for the document, available from LO 7.6 and Online 23.05, it is in CODE 23.05 Press Release - Collabora Office and Collabora Online
  • 23.05 Android web browser cannot run presentation with default slide (by default has no background)
  • 23.05 Android app snapshot: cannot open ODP – This has been fixed: https://gerrit.libreoffice.org/c/core/+/155445

• Mike D

  • Pressing ALT on Keyboard Leaves COOL + Focuses on Browser’s Menus (Firefox-only bug)
    • Should stay within document/COOL, letting you get into the COOL’s tabs/buttons.
    • Pedro: on Firefox is shift + tab. AI: Probably worth to pay attention if FF user also find that confusing

Forum (Mike D)

These were the key topics:

• Asking about versioning documents:
  • Versioning for documents in COOL
    • Review > Manage
    • File > Repair
    • Versioning is typically handled by integrator (Nextcloud, Owncloud, etc.)
      • An extra button appears in upper-right corner next to “X” close button.
• Unsure what this person means about “Sharing video” + “Talk”:
  • Video windows doesn't switch between participants while editing a shared document → Needs info, screenshots and steps
  • Looks like they posted on Github #7046 too.
• This person asking about Japanese Phonetic Guides:
  • Unable to use phonetic guides
  • (Possible in COOL?)
  • LibreOffice 7.5 Help: “Asian Phonetic Guide”
  • LibreOffice Writer's Asian phonetic guides are undesirably far away from their kanji (desired appearance: the furigana is right next to the kanji). They also offset said kanji from the rest of the text when writing with vertical directionality. Is there any way to fix this? : libreoffice

16->17 - zero replies in user support:

→ User Support - Collabora Online

62->62 - zero replies in installation and config:

→ Installation & Configuration - Collabora Online

Community

LibreOffice conference (Gabriel)

• Mike’s talk got accepted
• Szymon, Caolan, Thorsten
• Still busy organizing the conference
• • spreading the ideas through different means is good.
• Will be in Bucharest – and Gabriel will be organizing it too.
  • LibreOffice Conference 2023 in Bucharest, Romania - The Document Foundation Blog
  • Call for papers went out
  • Registration is now open
  • You are invited to the “Introduction in LibreOffice Development” workshop:
    • Learn about LibreOffice development at our upcoming conference! - The Document Foundation Blog
    • Workshop: Introduction to LibreOffice Development | LibreOffice Conference 2023 - Bucharest (Romania)
    • Registration Form | LibreOffice Conference 2023 - Bucharest (Romania)

Next meeting

17/08/2023