Collabora Online Weekly Meeting #144
Date: Nov 16th 2023
All minutes published on: https://forum.collaboraonline.com/tag/meeting-minutes
Please update your section
status bar changing languages → was it filed? : https://github.com/CollaboraOnline/online/issues/7492
-
Using public link from richdocuments triggers http auth popup. I have discussed with Julius, it seems to be a new bug: https://github.com/nextcloud/richdocuments/issues/3295
-
We got it using staging-perf that uses: Richdocument version is : 8.2.2
-
Julius will be backporting
-
Attendees (write your name):
- Anna, Ezinne, Caolán, Andras, Cosmin, Timur, Attila, Gulsah, Gokay, Darshan, Bayram, Hub, Aron, Mike D, Skyler, Michael, Vivek, Nicolas, Cosmin
Making the call shorter
-
Please update your section relating in the document before we read through it.
-
Then only go over anything we need to share / get input on
Release Schedule
-
CODE 23.05.5.4 Released on Monday!
-
Next CODE Release expected Week 47!
-
Mobile releases
-
iOS 23.05.6 Week 48 (?)
-
Android 23.05.6 Week 48 (?)
-
need to fix insert → comments on Mobile.
-
-
iOS
- quick smoke-testing of new build looks good (Nicolas)
Julius
-
Sidebar concerns:
-
lots of negative feedback here still.
-
Darshan fixed this for three cases – but we have 2x cases more where the Nextcloud sidebar shows up by default; particularly for internal shared link.
-
There is an explicit open-sidebar call after we close; it gets closed, and re-opened for internal links – hunting this down (Darshan)
- gave a stack-trace to Julius, and trying to work out why it doesn’t close.
-
Preferred – generally disable it – design team decided against it.
-
In all places where the viewer opens; we have the sharing sidebar showing up.
-
Need a way in richdocuments to prevent that.
-
Other apps installed that could influence timing of calls.
- Pedro will get a list of apps installed to help reproduce it locally.
-
-
-
Open in new tab by default (?)
-
UX testing feedback tells us that files in new tabs is a serious issue
-
AI: share feedback with Julius (Pedro)
-
Google opens in a new tab by default (Nicolas)
-
A website that is an application: a “file explorer” (Pedro)
- user expects, the file opens – something new happens.
-
May be needed inside the Nextcloud server – not in richdocuments (Julius)
-
-
Probably follow up release with still pending fixes next week
-
Full screen fix, merged
-
Prevent automatic logout while editing, still pending
- Collabora Online patch got in and was released (https://sdk.collaboraonline.com/docs/postmessage_api.html#get-user-state ); Richdocuments patch still in the works
-
-
WASM
-
https://github.com/nextcloud/richdocuments/issues/3258
-
Pull-request is in a test-able state; can see if there are more missing things.
-
AI: add a setting in the capabilities to say “WASM enabled” (Ash)
-
-
-
Calc Performance: cells with lengthily text
- Improvement was merged
-
First beta of richdocuments for upcoming Nextcloud 28 was released, nothing fancy just compatibility changes to adapt to upstream refactoring of our files app
Nicolas
-
Checked the LanguageTool integration (in desktop) and filled some remaining issues
-
Has some impact on spell/grammar checker in online too
-
reported the findings; lets see what happens.
-
Will poke Miklos (Michael)
-
Cosmin
-
Found some broken help buttons in 22.05 and opened issue 7596.
-
Trying to debug some rare and random errors occurring in prod.
Online activity
-
Bugs caught during this meeting
-
Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
- Issue: AI: Pedro
-
-
Attila
-
Merged: Navigator problem related with different users using different UI language → causing Navigator to glitch (flicker)
https://github.com/CollaboraOnline/online/issues/7322
https://gerrit.libreoffice.org/c/core/+/153771 -
working on fontwork problem (text becomes wide)
https://bugs.documentfoundation.org/show_bug.cgi?id=148000
It mostly working now. There is some precision problem
Have to make test, and compat flag probably.
-
-
PRs without reviewer 6
-
Szymon
-
Szymon will take a look at the lengthy cell problem – added improvement for formulabar
-
On vacation last week.
-
-
Darshan
-
Working on a follow up PR Set Icon on Change to Dark Mode ( Cleaning up duplicate CSS present in w2ui icon css file)
-
Found some small design issue on mobile related to checkbox/Radio buttons. Need to file ticket on GH and will fix it one by one.
-
-
Michael / Caolan – Performance
-
new cypress regression tests for the various invalidation related fixes added
-
reduce the amount of redrawing online has to do for tile updates, without clipping
-
FormulaBar perf
-
Reduce jsdialog formulabar updates from 6 to 3 per keystroke
-
Reduce jsdialog formulabar updates from 3 to 1 per keystroke
- https://gerrit.libreoffice.org/c/core/+/159424 (to review)
-
-
Missing quarantine documents on crash
-
current theory is that is it removed by a later session on reload if same content
-
Another report on this topic backs up this theory.
-
-
Kit-in-process things (Michael)
-
now have it running private/mmeeks/kit-in-process
-
lots of rough edges & problems; but … vaguely usable it seems.
-
Badly needs cleaning up.
-
-
-
Testing results:
-
Dark mode now working nicely.
-
Found some good problems from calc:
-
[https://github.com/CollaboraOnline/online/issues/6893](https://github.com/CollaboraOnline/online/issues/6893) – getTextSelection
- may be a red-herring.
-
-
Presentation starting – accelerated this (Timur)
- progress bar ticket is filed.
-
-
Bayram
-
make Move/Copy sheet dialog async: https://gerrit.libreoffice.org/c/core/+/158078
-
under review and testing: https://github.com/CollaboraOnline/online/issues/7354
-
commented about tab switching issue: The issue was already there before my patch. (after move left/right, previous/next tab is selected, then the correct tab is selected)
-
-
https://github.com/CollaboraOnline/online/issues/7369 - Calc: grouping doesn’t work #7369
-
(fixed) column groups: only the top-parent control box is responsive to the click.
-
(in progress) row groups: hidden child control boxes are still clickable
-
crash: I encountered a crash after creating third group inside another groups
-
-
-
Skyler
-
I’m testing https://github.com/CollaboraOnline/online/pull/7656 which touches a lot of input event code, if you have a device that has a touchscreen or you have a device that does not have a touchscreen I encourage you to test this to make sure input still works properly. Especially helpful would be tests on Android phones and Chromebooks. Thanks!
-
Fixed an issue that could get you softlocked without any UI: https://github.com/CollaboraOnline/online/pull/7664
-
Other various touchscreen fixes and testing, e.g. https://github.com/CollaboraOnline/online/pull/7647
-
-
Timur
-
Ctrl+C, Ctrl+Z, CTRL+V sometimes doesn’t work on Calc with multiple users – no change
Dark mode with multiple users – no change
-
Focus on the comments in Writer, Calc, Impress - few fixes already, some in progress…
-
DeepL stopped working – fixed in Core and additionally in Online.
-
GitHub active for Online and RichDocumentsCode
-
-
Pranam
-
Currently working on copy paste improvement
-
When we select a cell (without entering cell edit mode) and copy something from a cell (with formula), pasting it outside of COOL formula gets pasted and not just the end result output.
-
Michael: Yes, if we select a cell I would expect to see the end result output and not the formula
-
-
New cypress test for autosaved comments
-
-
Gökay
-
Writer – LanguageTool
- Ignore all is not working when language tool is enabled.
-
Calc:
-
Cut & Paste a hyperlink is not working when multiple users are active on the same file.
-
Context menu is the priority not the button in the popup.
-
-
-
Hubert
-
Other fixes for configuring UI:
- DisableLocalInsertImage WOPI: https://github.com/CollaboraOnline/online/pull/7661
-
-
Gülşah
-
Editing a cell without exiting the cell edit mode and then clicking the ‘+’ to insert a new sheet moves the entered content into that new sheet.
-
Fixed: https://github.com/CollaboraOnline/online/pull/7579
- I triggered the cypress test several time but failed on unrelated part.
-
-
And now working on overwrite follow up PR of configurable override mode
-
Fixed: https://github.com/CollaboraOnline/online/pull/7614
- I triggered the cypress test several time but failed on unrelated part.
-
Have fix on gerrit but patch but has an issue: https://gerrit.libreoffice.org/c/core/+/159282
-
Before the patch “Help” button never works, after the patch “Help” button works but not in first try.
- If we click another Help button first (eg: Format→Theme→Help) then click the Insert->Chart->Help works
-
-
-
-
Currently working on Writer→Sidebar→Area section “Thickness” button shows the dialog cut.
-
Not can be fixed one line css code. Investigate a log, understand the reason. Playing with the browser/src/control/Control.JSDialog.js “setPosition”. It is invoked early time so I think we should invoke it again somewhere.
- Debugging…
-
-
Andras
-
Mike D
-
https://github.com/CollaboraOnline/online/issues/7638
-
Android: “File > Properties” headings are misaligned.
-
→ Darshan fixed. In Progress.
-
-
Forum (Mike D)
3 Forum posts + 1 Reddit this week.
Key topics:
-
https://forum.collaboraonline.com/t/what-are-the-limitations-of-the-collabora-server/2180/3
- Potential 20+ users? Asked about “any limitations of COOL?” I pinged Marketing.
9 → 9 - zero replies in user support:
→ https://forum.collaboraonline.com/c/user-support/11?order=activity
37 → 37 - zero replies in installation and config:
→ https://forum.collaboraonline.com/c/installation-configuration/10?ascending=true&order=posts
Next events
-
COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – https://www.collaboraoffice.com/cool-days-2024/
-
We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
-
What to do next
-
Passport & VISA
-
Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
-
Apply for a VISA if needed.
-
-
Register for the event: https://eventyay.com/e/0512424d
-
Submit a talk:
-
Next meeting
23/11/2023