Collabora Online Weekly Meeting #146
Date: Nov 30th 2023
All minutes published on: Topics tagged meeting-minutes
Please update your section
Attendees (write your name):
- Anna, Ezinne, Caolán, Andras, Cosmin, Timur, Attila, Gulsah, Gökay, Darshan, Bayram, Hub, Aron, Mike D, Skyler, Michael, Vivek, Nicolas, Cosmin, Szymon, Pranam
Making the call shorter
- Please update your section relating in the document before we read through it.
- Then only go over anything we need to share / get input on
Release Schedule
- CODE 23.05.5.4 Released on last Monday.
- Right now: chasing all the blockers
- More updated in the beginning of the next week, possibly new CODE version
- Next CODE Release
expected Week 47! - Mobile releases
- iOS 23.05.6 Week 48 (?)
- Android 23.05.6 Week 48 (?)
- need to fix insert → comments on Mobile.
- iOS
- quick smoke-testing of new build looks good (Nicolas)
Julius
- Sidebar concerns:
- lots of negative feedback here still.
- Darshan fixed this for three cases – but we have 2x cases more where the Nextcloud sidebar shows up by default; particularly for internal shared link.
- There is an explicit open-sidebar call after we close; it gets closed, and re-opened for internal links – hunting this down (Darshan)
- gave a stack-trace to Julius, and trying to work out why it doesn’t close. [done]
- Preferred – generally disable it – design team decided against it.
- In all places where the viewer opens; we have the sharing sidebar showing up.
- Need a way in richdocuments to prevent that.
- Other apps installed that could influence timing of calls.
- Pedro will get a list of apps installed to help reproduce it locally. [done]
- Found the lingering problem: fix: Avoid triggering a deferred sidebar open if openFile is already handling that #41636: [stable27] fix: Avoid triggering a defered sidebar open if openFile is already handling that by juliushaertl · Pull Request #41636 · nextcloud/server · GitHub
- It’s against Nextcloud 27, richdocuments 8.2.3
- Not merged yet, but already approved
- Open in new tab by default (?)
- UX testing feedback tells us that files in new tabs is a serious issue
- AI: share feedback with Julius (Pedro)
- Google opens in a new tab by default (Nicolas)
- A website that is an application: a “file explorer” (Pedro)
- user expects, the file opens – something new happens.
- May be needed inside the Nextcloud server – not in richdocuments (Julius)
- Probably follow up release with still pending fixes next week
- Full screen fix, merged
- Prevent automatic logout while editing, still pending
- Collabora Online patch got in and was released (PostMessage API — SDK https://sdk.collaboraonline.com/ documentation ); Richdocuments patch still in the works
- WASM
- WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
- Pull-request is in a test-able state; can see if there are more missing things.
- AI: add a setting in the capabilities to say “WASM enabled” (Ash)
- WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
- Calc Performance: cells with lengthily text
- Improvement was merged
- First beta of richdocuments for upcoming Nextcloud 28 was released, nothing fancy just compatibility changes to adapt to upstream refactoring of our files app
Nicolas
- Nothing of relevance; in listening mode.
Online activity
- Bugs caught during this meeting
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
- Issue: AI(Pedro): To file bug
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
- Attila
- working on Language change problems (sidebar, statusbar)
Calc: Sidebar Changes Language · Issue #7492 · CollaboraOnline/online · GitHub
tried to find a general fix, and tried to setView in a few places like at
JSDialogNotifiIdle:invoke() … but they not fixed the problem, but made some more.
- working on Language change problems (sidebar, statusbar)
Navigator was an exception, that localised text because of a ModifyChanged() and
Broadcasted it to all Navigator Dialog… (so it is not an idle/timet of the view)
Debugged where exact localisation happens to find a shared point,
found most of them… they use Translate::get(…), they should be easy to fixed.
But Panels Title do localisation elseway I just found it not long ago.
childaccess.cxx … getChild(“*” + locale)
I will try to find some more general place to fix by setView, but for fallback, I can fix them more direcly.
-
PRs without reviewer 8
-
Szymon
- Current: working on view jumping, various richdocumentscode improvements
-
Darshan
-
(On hold for now) Working on a follow up PR Set Icon on Change to Dark Mode (Cleaning up duplicate CSS present in w2ui icon css file) => Review changes by pedro WIP
-
Fix download options (PDF/PDF as/EPUB) in read only mode #7706 => Merged
-
Add rename document icon for dark mode 7713
-
Make icon structure consistent 7711 => +1 review Pedro to re-check it
-
WIP: Fix filter dialog usability issues in Calc
-
-
Vivek
- Work in progress - Scroll bar animation on mouse hover event (pause)
- Work in Progress - Comment dialogue looking odd in mobile view
-
Michael / Caolan – Performance
- working on some regressions from earlier perf work
- notes not moving on deleting rows (but cols ok)
- missing tile updates?, next to look into
- Was seeing viewid mismatches, even without using darkmode, related to darkmode
- restored allow “theme change” even if the global theme has not changed, but retained the perf gain from the original situation
- reduce the amount of redrawing online has to do for tile updates, without clipping
- Kit-in-process things (Michael)
- working on some regressions from earlier perf work
-
Testing results:
- Dark mode now working nicely.
- Found some good problems from calc:
- generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
- may be a red-herring.
- generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
-
Bayram
- Calc: groupping doesn't work · Issue #7369 · CollaboraOnline/online · GitHub - Calc: grouping doesn’t work #7369
- (fixed) column groups: only the top-parent control box is responsive to the click.
- (fixed) row groups: hidden child control boxes are still clickable
- Patch: (Under review) Calc: make grouping responsive for each group level by bayramcicek · Pull Request #7722 · CollaboraOnline/online · GitHub - Calc: make grouping responsive for each group level #7722
- Calc: Ctrl+Shift+PageUp/PageDown goes the wrong way
- Problem is on the core side. I will send the patch today after testing.
- Next: New bug about switching issue: Calc: Moving sheet changes active sheet for a split second
- Moving happens correctly, but it changes the view to the target tab and then back to the correct one (the one that was moved)
- Calc: groupping doesn't work · Issue #7369 · CollaboraOnline/online · GitHub - Calc: grouping doesn’t work #7369
-
Skyler
- Touchscreen input fixes merged
- Let me know if you experience any issues, Szymon has already mentioned issues with TigerVNC
- However I’m pleased to say that Szymon’s issues initially looked much more major than they actually are
- Let me know if you experience any issues, Szymon has already mentioned issues with TigerVNC
- Working on making the keyboard stay up when using it for navigation even when we know it’s an onscreen keyboard (and so don’t popup for everything)
- Just started looking so no changes/pulls yet, but I estimate it’ll need a core change and an online change
- Looking at older mobile versions (old Safari versions) … as Safari on iOS changes with the OS it’s sometimes hard to update so some people still use very old versions
- Touchscreen input fixes merged
-
Pranam
- Revamp comment autosave feature
- Reverted all the previous patches of the feature
- More simple implementation using existing workflow
- Hopefully will remove comment regressions
- Then new cypress test for autosaved comments (multiple users) will also be needed
- Revamp comment autosave feature
-
Gökay
- Writer – LanguageTool
- Ignore all is not working when LanguageTool is enabled.
- A PR is reviewed and merged but I’ll check this again. QA team has a comment.
- Will prepare a unit test.
- Ignore all is not working when LanguageTool is enabled.
- Duden corrector hints were not shown when there is one empty list. There is also a merged PR for this issue. QA team has a comment for also this one. Will check again.
- Currently working on getting hyperlink info on read only documents. (paused now, while blockers are still around)
- Comments related 2 bugs are solved. Waiting to be merged into master branch.
- Will continue with another bug related to dark mode.
- Calc:
- Cut & Paste a hyperlink is not working when multiple users are active on the same file.
- Context menu is the priority not the button in the popup.
- Writer – LanguageTool
-
Hubert
- Other fixes for configuring UI:
- DisableInsertLocalImage WOPI: wopi: Added DisableInsertLocalImage by hfiguiere · Pull Request #7661 · CollaboraOnline/online · GitHub
- Now passed all tests, still needs +1 to be merged
- DisableInsertLocalImage WOPI: wopi: Added DisableInsertLocalImage by hfiguiere · Pull Request #7661 · CollaboraOnline/online · GitHub
- Various enhancements to the PostMessage debug page.
- Feel free to ping me with any specific issue
- Other fixes for configuring UI:
-
Gülşah
-
Editing a cell without exiting the cell edit mode and then clicking the ‘+’ to insert a new sheet moves the entered content into that new sheet.
- Fixed: Exit cell edit mode before add a new sheet by GulsahKose · Pull Request #7579 · CollaboraOnline/online · GitHub
- I triggered the cypress test several time but failed on unrelated part.
- Cypress tests locally passed but didn’t pass the CI
- Fixed: Exit cell edit mode before add a new sheet by GulsahKose · Pull Request #7579 · CollaboraOnline/online · GitHub
-
And now working on overwrite follow up PR of configurable override mode
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
- I triggered the cypress test several time but failed on unrelated part.
- Cypress tests locally failed too but couldn’t return back to work this.
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
-
Now working on this Writer→Sidebar→Area section “Thickness” button shows the dialog cut.
- Have a fix:
- Core patch : https://gerrit.libreoffice.org/c/core/+/160106 (Merged)
- Backported to co-23.05: https://gerrit.libreoffice.org/c/core/+/160039 (Merged)
- Github: Fix the thickness dialog is shown cut by GulsahKose · Pull Request #7744 · CollaboraOnline/online · GitHub (waits to pass cypress test)
- Have a fix:
-
Currently working on ““Download” and “Download as” are not working at all”
- Tested locally core master and online master. None of the download option doesn’t work.
- I’ll test on core 23.05 again and want to be sure to see same problem. To be sure I’ll contact with Ezinne…
- Continue to investigating…
-
-
Andras
- No update
-
Pedro
-
Mike D
- Right-Click > More Options = "Your Browser Has Very Limited Access to the Clipboard" · Issue #7747 · CollaboraOnline/online · GitHub
- Right-Click > More Options = “limited access to clipboard” popup.
- Seems like it was a “Paste Special” thing…
- Menu options might need removal?
- Ctrl+H Shortcut for "Find and Replace" does not work in all servers · Issue #7748 · CollaboraOnline/online · GitHub
- Ctrl+H does nothing! Should pop open “Find and Replace”.
- Another Find and replace issue: dialog comes up with text inserted by another user
- Timur
- Also retested old:
- iOS and Android app: Paste not possible in formula bar (except using additional software on some platforms) · Issue #1320 · CollaboraOnline/online · GitHub
- Android(/iOS?) Calc: Can’t paste into formula bar.
- Language tool: a strange/ interesting bug on LO. Will look into this.
- Right-Click > More Options = "Your Browser Has Very Limited Access to the Clipboard" · Issue #7747 · CollaboraOnline/online · GitHub
Forum (Mike D)
5 Forum posts + 3 Github this week.
Key topics:
- File - Send - Email. I don't have "Send" - #4 by Tex
- iOS: No “File > Send > Email as PDF”
- (I gave him workaround + told him to submit feature request to Github…)
- iPad mini: collabora office text/calc editing not working
- Someone on iPad Mini not working. iOS Keyboard appears, but they can’t type/edit spreadsheet.
- Current OS is iPadOS 15.8
- Collabora Office Version is 23.05.5.2
9 → 9 - zero replies in user support:
→ User Support - Collabora Online
37 → 37 - zero replies in installation and config:
→ Installation & Configuration - Collabora Online
Next events
- COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – COOL Days 2024 - 8-10 April - Cambridge, UK - Collabora Office and Collabora Online
- We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
- What to do next
- Passport & VISA
- Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
- Apply for a VISA if needed.
- Register for the event: https://eventyay.com/e/0512424d
- Submit a talk:
- What to do next
Next meeting
7/12/2023