Collabora Online Weekly Meeting #145
Date: Nov 23rd 2023
All minutes published on: Topics tagged meeting-minutes
Please update your section
- Using public link from richdocuments triggers http auth popup. I have discussed with Julius, it seems to be a new bug: Public share links cause basic auth window · Issue #3295 · nextcloud/richdocuments · GitHub
- We got it using staging-perf that uses: Richdocument version is : 8.2.2
- Julius will be backporting Nextcloud
Attendees (write your name):
- Anna, Ezinne, Caolán, Andras, Cosmin, Timur, Attila, Gulsah, Gokay, Darshan, Bayram, Hub, Aron, Mike D, Skyler, Michael, Vivek, Nicolas, Cosmin, Szymon
Making the call shorter
- Please update your section relating in the document before we read through it.
- Then only go over anything we need to share / get input on
Release Schedule
- CODE 23.05.5.4 Released on last Monday.
- Next CODE Release
expected Week 47! - Mobile releases
- iOS 23.05.6 Week 48 (?)
- Android 23.05.6 Week 48 (?)
- need to fix insert → comments on Mobile.
- iOS
- quick smoke-testing of new build looks good (Nicolas)
Julius
- Sidebar concerns:
- lots of negative feedback here still.
- Darshan fixed this for three cases – but we have 2x cases more where the Nextcloud sidebar shows up by default; particularly for internal shared link.
- There is an explicit open-sidebar call after we close; it gets closed, and re-opened for internal links – hunting this down (Darshan)
- gave a stack-trace to Julius, and trying to work out why it doesn’t close. [done]
- Preferred – generally disable it – design team decided against it.
- In all places where the viewer opens; we have the sharing sidebar showing up.
- Need a way in richdocuments to prevent that.
- Other apps installed that could influence timing of calls.
- Pedro will get a list of apps installed to help reproduce it locally. [done]
- Found the lingering problem: fix: Avoid triggering a defered sidebar open if openFile is already handling that #41636 : [stable27] fix: Avoid triggering a defered sidebar open if openFile is already handling that by juliushaertl · Pull Request #41636 · nextcloud/server · GitHub
- It’s against Nextcloud 27, richdocuments 8.2.3
- Not merged yet, but already approved
- Open in new tab by default (?)
- UX testing feedback tells us that files in new tabs is a serious issue
- AI: share feedback with Julius (Pedro)
- Google opens in a new tab by default (Nicolas)
- A website that is an application: a “file explorer” (Pedro)
- user expects, the file opens – something new happens.
- May be needed inside the Nextcloud server – not in richdocuments (Julius)
- Probably follow up release with still pending fixes next week
- Full screen fix, merged
- Prevent automatic logout while editing, still pending
- Collabora Online patch got in and was released (PostMessage API — SDK https://sdk.collaboraonline.com/ documentation ); Richdocuments patch still in the works
- WASM
- WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
- Pull-request is in a test-able state; can see if there are more missing things.
- AI: add a setting in the capabilities to say “WASM enabled” (Ash)
- WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
- Calc Performance: cells with lengthily text
- Improvement was merged
- First beta of richdocuments for upcoming Nextcloud 28 was released, nothing fancy just compatibility changes to adapt to upstream refactoring of our files app
Nicolas
- Checked the LanguageTool integration (in desktop) and filled some remaining issues
- Has some impact on spell/grammar checker in online too
- reported the findings; lets see what happens.
- Will poke Miklos (Michael)
Online activity
-
Bugs caught during this meeting
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
- Issue: AI: Pedro
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
-
Attila
- Merged: fix of fontwork text becomes wide
148000 – FILEOPEN PPTX: curved text doesn't line break properly and becomes too wide
https://gerrit.libreoffice.org/c/core/+/159776 - Started to work on Language change problems
Calc: Sidebar Changes Language · Issue #7492 · CollaboraOnline/online · GitHub
reproduced the problem.
It seems to be a regression, as a 1 month older version it was ok.
I try to find where to get viewID for JSDialogNotifyIdle::Invoke()
- Merged: fix of fontwork text becomes wide
-
PRs without reviewer 6
-
Szymon
- Fixed crashes caused by copy-pasting done by other users.
-
Darshan
- Working on a follow up PR Set Icon on Change to Dark Mode ( Cleaning up duplicate CSS present in w2ui icon css file) => Review changes by pedro WIP
-
Fix download options (PDF/PDF as/EPUB) in read only mode #7706 => need review
-
Vivek
- Work in progress - Scroll bar animation on mouse hover event (pause)
- Work in Progress - Comment dialogue looking odd in mobile view
-
Michael / Caolan – Performance
- reduce the amount of redrawing online has to do for tile updates, without clipping
- FormulaBar perf
- Reduce jsdialog formulabar updates from 3 to 1 per keystroke
- https://gerrit.libreoffice.org/c/core/+/159424 (now merged)
- Reduce jsdialog formulabar updates from 3 to 1 per keystroke
- Threading gotcha (Michael)
- Missing quarantine documents on crash
- current theory is that is it removed by a later session on reload if same content
- Another report on this topic backs up this theory.
- Kit-in-process things (Michael)
-
Testing results:
- Dark mode now working nicely.
- Found some good problems from calc:
- generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
- may be a red-herring.
- generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
- Presentation starting – accelerated this (Timur)
- progress bar ticket is filed.
-
Bayram
- Calc: groupping doesn't work · Issue #7369 · CollaboraOnline/online · GitHub - Calc: grouping doesn’t work #7369
- (fixed) column groups: only the top-parent control box is responsive to the click.
- (in progress) row groups: hidden child control boxes are still clickable
- found the cause of the issue: size of the groups remain the same whether a group is hidden or not.
- Will send the patch after testing
- crash: I encountered a crash after creating third group inside another groups
- Next
- Calc: Ctrl+Shift+PageUp/PageDown goes the wrong way
- Calc: groupping doesn't work · Issue #7369 · CollaboraOnline/online · GitHub - Calc: grouping doesn’t work #7369
-
Skyler
- I’m testing Unify touchscreen handling, remove L.Browser.touch by Minion3665 · Pull Request #7656 · CollaboraOnline/online · GitHub which touches a lot of input event code, if you have a device that has a touchscreen or you have a device that does not have a touchscreen I encourage you to test this to make sure input still works properly. Especially helpful would be tests on Android phones and Chromebooks. Thanks!
- Fixed an issue that could get you softlocked without any UI: Menubar & Tabs visibility logic fixes by Minion3665 · Pull Request #7664 · CollaboraOnline/online · GitHub
- Other various touchscreen fixes and testing, e.g. Add a ui_defaults hint for touchscreens by Minion3665 · Pull Request #7647 · CollaboraOnline/online · GitHub
-
Timur
- Focus on the comments in Writer, Calc, Impress – to test fixes . Thread of 7 comments now seen as only 3 or 4 in full view. Seems that multiple replies from the 1st user are not seen, while other’s replies are.
- To test Sidebar and Navigator fixes.
- Small Duden, LanguageTool fixes, in progress.
-
Pranam
- Currently working on copy paste improvement
- When we select a cell (without entering cell edit mode) and copy something from a cell (with formula), pasting it outside of COOL formula gets pasted and not just the end result output.
- Michael: Yes, if we select a cell I would expect to see the end result output and not the formula
- New cypress test for autosaved comments
- Currently working on copy paste improvement
-
Gökay
- Writer – LanguageTool
- Ignore all is not working when language tool is enabled.
- A PR is reviewed and merged but I’ll check this again. QA team has a comment.
- Ignore all is not working when language tool is enabled.
- Duden corrector hints were not shown when there is one empty list. There is also a merged PR for this issue. QA team has a comment for also this one. Will check again.
- Currently working on getting hyperlink info on read only documents.
- Calc:
- Cut & Paste a hyperlink is not working when multiple users are active on the same file.
- Context menu is the priority not the button in the popup.
- Writer – LanguageTool
-
Hubert
- Other fixes for configuring UI:
- EnableLocalInsertImage WOPI: wopi: Added DisableInsertLocalImage by hfiguiere · Pull Request #7661 · CollaboraOnline/online · GitHub
- hide button in notebookbar notebookbar: handle show/hide button by hfiguiere · Pull Request #7589 · CollaboraOnline/online · GitHub
- Other fixes for configuring UI:
-
Gülşah
-
Editing a cell without exiting the cell edit mode and then clicking the ‘+’ to insert a new sheet moves the entered content into that new sheet.
- Fixed: Exit cell edit mode before add a new sheet by GulsahKose · Pull Request #7579 · CollaboraOnline/online · GitHub
- I triggered the cypress test several time but failed on unrelated part.
- Can not run the cypresstest locally. Have a problem about connecting to chromium browser
- Fixed: Exit cell edit mode before add a new sheet by GulsahKose · Pull Request #7579 · CollaboraOnline/online · GitHub
-
And now working on overwrite follow up PR of configurable override mode
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub
- I triggered the cypress test several time but failed on unrelated part.
- Can not run the cypresstest locally. Have a problem about connecting to chromium browser
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub
-
Online Chart wizard Help button
- Fixed:https://gerrit.libreoffice.org/c/core/+/159282
- backported to 23.05: https://gerrit.libreoffice.org/c/core/+/159756
-
Currently working on Writer→Sidebar→Area section “Thickness” button shows the dialog cut.
- Dialog has an image, in some case image render is delayed and to set the final position we are getting wrong width because image size is 0x0 because of the delay, so final position is wrong.
- Discussed with Szymon and still working on.
- Dialog has an image, in some case image render is delayed and to set the final position we are getting wrong width because image size is 0x0 because of the delay, so final position is wrong.
-
-
Andras
- Review and merge
- disable spell check for document name input field by timar · Pull Request #7707 · CollaboraOnline/online · GitHub disable spell check for document name input field → AI (Pedro) to review
- add missing css class to dark mode icon in Calc by timar · Pull Request #7699 · CollaboraOnline/online · GitHub add missing css class to dark mode icon in Calc → Awesome, thanks! I will check it
- Review and merge
-
Pedro
- Thanks Aarsh for fix:navigator hyperlinks line-breaking on chrome and firefox by aarsh21 · Pull Request #7617 · CollaboraOnline/online · GitHub → reviewed and requested changes
- Gitpod re-tested. Instructions updated. Now possible to use chromium for cypress tests in the VM
- dark-mode use correct jquery-ui icons with data-theme value
- Fix mobile-ui-tabs Misaligned Headings Fix mobile-ui-tabs Misaligned Headings by Darshan-upadhyay1110 · Pull Request #7651 · CollaboraOnline/online · GitHub thanks Darshan → fixes in but we should probably disable that menu item when on mobile
- Detected very strange behaviour with: remove bullet button; outline toggle
- control: ‘toolbutton’ id:‘RemoveBullets-button’ event: ‘click’ state: ‘.uno:RemoveBullets’ cool.html:359:37 OUTGOING: uno .uno:RemoveBullets . Is always with active (on) state as if it was a toggle. It never goes disabled even if the cursor is not in a list
- Very easy to click it thinking that will remove the whole list and then it actually just remove one item. And now the user will try to apply outline list to that widow etc
- Outline button (sidebar) is clickable but it does nothing unless the user expressly clicks the triangle to open the dropdown: control: ‘toolbox’ id:‘numberbullet’ event: ‘click’ state: ‘.uno:SetOutline’ cool.html:359:37 OUTGOING: dialogevent 0 {“id”:“numberbullet”, “cmd”: “click”, “data”: “.uno:SetOutline”, “type”: “toolbox”}
- It should open the bullets dialog with advance options (as it happens with “Character spacing” button dropdown). This would also help to increase discoverability of that dialog and the advance options.
- Another option could be to just remove the outline toggle from the sidebar (provided that its functionality is still accessibility via the dialog)
- control: ‘toolbutton’ id:‘RemoveBullets-button’ event: ‘click’ state: ‘.uno:RemoveBullets’ cool.html:359:37 OUTGOING: uno .uno:RemoveBullets . Is always with active (on) state as if it was a toggle. It never goes disabled even if the cursor is not in a list
-
Mike D
- Android: "File > Properties" Misaligned Headings · Issue #7638 · CollaboraOnline/online · GitHub
- Android: “File > Properties” headings are misaligned.
- → Darshan fixed. In Progress.
- Android: "File > Properties" Misaligned Headings · Issue #7638 · CollaboraOnline/online · GitHub
Forum (Mike D)
3 Forum posts + 1 Reddit this week.
Key topics:
- What are the limitations of the Collabora server - #3 by Mario1
- Potential 20+ users? Asked about “any limitations of COOL?” I pinged Marketing.
9 → 9 - zero replies in user support:
→ User Support - Collabora Online
37 → 37 - zero replies in installation and config:
→ Installation & Configuration - Collabora Online
Next events
- COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – COOL Days 2024 - 8-10 April - Cambridge, UK - Collabora Office and Collabora Online
- We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
- What to do next
- Passport & VISA
- Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
- Apply for a VISA if needed.
- Register for the event: https://eventyay.com/e/0512424d
- Submit a talk:
- What to do next
Next meeting
30/11/2023