Caolan
- Current coolwsd deb package breaks AppArmor on Debian and Ubuntu 22.04 or older · Issue #9945 · CollaboraOnline/online · GitHub
- apparmor abi issue on Debian earlier Ubuntu where abi-4
is nor available - no good way to detect what abi is available apparently
- so in postin remove the conf file if there is no
/etc/apparmor.d/abi/4.0, which will also repair broken
current installs
→ remove apparmor profile that depends in abi 4.0 if that is not available by caolanm · Pull Request #9960 · CollaboraOnline/online · GitHub
- apparmor abi issue on Debian earlier Ubuntu where abi-4
- Latest Docker image is only working in privileged mode · Issue #9948 · CollaboraOnline/online · GitHub
- failure to start under docker
- fallbacks are missing caps because postinst not bundled
by Makefile.am EXTRA_DIST
→ coolwsd-deprecated package missing its postinst by caolanm · Pull Request #9961 · CollaboraOnline/online · GitHub
- debug chart to see what it would take to use the
existing apis to add columns to XInternalDataProvider
→ https://gerrit.libreoffice.org/c/core/+/172839 - possible, but very verbose and painful, looks like
lots of “special cases”, bubble chart(?) etc that the
data table code know already how to deal with. - cool#9969 debug autocolor + FONTCOLOR confusion
- config: remove font color value and use fallback by lpranam · Pull Request #9969 · CollaboraOnline/online · GitHub
→ loads of confusion about COL_AUTO which is to find
a real color for the automatic font color that works
on an arbitrary background. vs FONTCOLOR which is intended
to be applied on a DOCCOLOR background. Doesn’t help that
Color::IsDark and Color::IsBright are not the opposite of
eachother, there is a 3rd category of neither. - cool#9976 empty jails and jail tmps left behind
→ enable cleanup of namespacing using jails by caolanm · Pull Request #9978 · CollaboraOnline/online · GitHub - failure of richdocumentscode proxy and keepalive sockets
- proxy.php assume that the stream is closed, so keepalive sockets
confused it so richdocumentscode didn’t work at all
→ break read loop when we reach ContentLength by caolanm · Pull Request #281 · CollaboraOnline/richdocumentscode · GitHub
- proxy.php assume that the stream is closed, so keepalive sockets
- still doesn’t work well, but establishes connection before then
not doing a whole pile more - failure of richdocumentscode to launch
- ClientRequestDispatcher::handleIncomingMessage is
consuming entire message body so keepalive sockets don’t
have left over data in them to disrupt parsing them.
But handleClientProxyRequest is launching something to
parse the body after handleIncomingMessage ends, so we can’t
remove that body in all cases
→ repair richdocumentscode case by caolanm · Pull Request #10006 · CollaboraOnline/online · GitHub
- ClientRequestDispatcher::handleIncomingMessage is
Jaume
Commenting improvements:
- Make sure that you can only delete your own comment on readonly:
- Done and merged
- Allow promoting reply comments to toplevel ones:
- Mostly done, the promotion works, I’m working on the callback so the UI updates
- WIP patches: https://gerrit.libreoffice.org/c/core/+/173051 and WIP: sw: annotation: add option to promote reply to rott comment by JaumePujantell · Pull Request #10008 · CollaboraOnline/online · GitHub
Mike
- Some work on restoring Linux debugging environment (interrupted)
- Deadlock while accessing CLSID Property of OLEs
- They reported, that they still see it, again
- They provided a stack trace, pointing to yet another place
- I was able to finally trigger that path (took an hour of repeated runs of their reproducer)
- Fixed
- Performed another set of testing-in-a-loop (10000 iterations) - no deadlocks
- Performance degradation with LibreOffice 24.2
- A tricky to measure
- In the process, found a regression in 24.8
- Caused by the ITEM work
- Noel took over this regression, and has a long trail of follow-up fixes (“dont use GetItemSurrogates for gathering …”)
- Finally was able to see the difference
- Found the causing commit 5619fc438273cd15e78539e78b8af751bca24b1a
- Why does spell check affect loading at all?
- It doesn’t - it only starts after loading; but it affects the next command coming from external Java process
- Some reviews of Gokay’s patches
- Reviewed some changes from Jaume
Miklos
Worked on:
- 162782 – FILESAVE SVG: semi-transparent shape text in a bullet list crashes
- Related: cool#9735 kit: make sure we don't process events in the any input callback by vmiklos · Pull Request #9974 · CollaboraOnline/online · GitHub
- Hang on paste failed image download · Issue #9956 · CollaboraOnline/online · GitHub
- 162707 – FILESAVE DOCX lost paragraph style with lots of numberings
- Digitally sign documents · Issue #9992 · CollaboraOnline/online · GitHub