Status report: consultancy team, week 4, 2024

Status reports
1

Caolan

  • sheet wide invalidation improvements
  • invalidation rects getting merged to make mega rect
  • add saltextenc to preloadData
  • oversized invalidation rects on joining calc doc
  • some FOSDEM WASM prep with thb
  • chase what happens to viewid in writer on changing various
    settings that affect the rendering options to see how things
    get synced or how the views are considered to match
    → there is oddness around the relatively new “ShowHiddenChar”
    defaulted on for Formatting Marks. Turning on/off formatting
    marks can cause dark/light mode tiles to appear.
    → so this is the “Writer: Dark mode gives Light mode tiles when user clicks on Formating mark” issue
  • tdf#159368 upstream regression crash
  • add page up/down to preview navigation
    add pageup and page down to preview navigation by caolanm · Pull Request #8098 · CollaboraOnline/online · GitHub
  • show full renderstate in browser debuging message
    the viewrenderedstate=string string is only used in debugging by caolanm · Pull Request #8099 · CollaboraOnline/online · GitHub
  • viewid problem
    → we have just one layout shared between multiple views, if
    show hidden chars is synced to show formatting, then layout
    could be different in view formatting on/off which is
    presumably why it has be treated as a special thing, and
    that difference in layout makes it futile to have this auto-on
    with view formatting unless we go down a new road of multiple
    layouts
  • “Writer: Dark mode gives Light mode tiles when user clicks on
    Formating mark” debugging and fixing
    → https://gerrit.libreoffice.org/c/core/+/162579 to turn show
    hidden chars back off again and various tests to capture
    the problem
  • dark mode problems in chart
  • poke around at this, looks like a few problems here
    → https://gerrit.libreoffice.org/c/core/+/162619 for toggling dark
    mode not doing anything when chart is active

Mike

  • “Improvements needed to DOCX fidelity”
    • 5 Different positioning of a page number field in the footer
    • DomainMapper::lcl_utext checks m_pImpl->m_pSdtHelper->GetSdtType, and calls m_pImpl->m_pSdtHelper->createPlainTextControl
    • In the first para, SdtHelper::m_xFieldStartRange is empty
    • So the problem seems to be, that for a block sdt, the first paragraph (in doc) does not set SdtHelper::m_xFieldStartRange.
    • Oh - there’s DomainMapper_Impl::m_xSdtEntryStart?
  • “Improvements needed to DOCX fidelity”
    • 5 Different positioning of a page number field in the footer
    • Spent some time time playing with different refactor of field import code, in attempt to make it sane
    • In the end, created https://gerrit.libreoffice.org/c/core/+/162427 as the least bad solution (mentioned my concerns there)
  • “Improvements needed to DOCX fidelity”
    • 5 Different positioning of a page number field in the footer
      • Backporting to co-23.05 branch
    • 4 Different positioning of text in footnote
      • Started to debug it
  • “File linked to image is not exported to ReqIF-XHTML”
    • Estimated and answered
  • “Inconsistent behaviour with document repair mechanism”
    • Answered; asked for some clarification
  • “Bookmarks placed directly behind each other produce une[…]”
    • Estimated and answered
  • “Improvements needed to DOCX fidelity”
    • 4 Different positioning of text in footnote
    • Created a minimal reproducer
    • The difference between the case when there’s no space between the number and the footnote text, and when there is, is hanging paragraph indent
    • Debugging
  • “Improvements needed to DOCX fidelity”
  • “Improvements needed to DOCX fidelity”
    • 4 Different positioning of text in footnote
    • https://gerrit.libreoffice.org/c/core/+/162635
    • What a mess it is - the code of the compat options dialog …
    • Backporting to 24-02 (will automatically (?) appear in co-24.04) and co-23.05
    • The long name of the option gets on my nerves
    • Will rename it, it’s not too late
  • “Improvements needed to DOCX fidelity”

Tomaz

Calc: add currency dropdown to the notebookbar

  • Get all the currencies used from the document model
    • look at how we get the document color - done the same for
    • added DocumentModelAccessor class so we can access parts of the document model from SfxObjectShell
    • only implemented currencies in this change
      • but also document colors should now go there too
  • Added the currencies that are in the document currencies on top
    • can access SfxObjectShell in the drop-down, so can get the document currencies
    • use the language and symbol as criteria
    • insert on top of the list and not at the bottom
    • not the most pretty code for insertion
  • Looked at the updated WIP patches from Szymon to add support for Online
    • and now it works fine from Online when tested - some issues however (described in the TODO)
    • needs refactoring, so the ToolbarUnoDispatcher instance is “view aware”
  • so one instance per view
    • refactored the code and introduced a NotebookBarViewManager and NotebookBarViewData
    • this now is also responsible for WeldedTabbedNotebookbar instance and the Notebookbar VCL instance
    • NotebookBarViewManager is a singleton and just holds the map
      • for a view instance we have a view data instance, so for SfxViewShell pointer maps to a NotebookBarViewData
    • changed and looks to work good
    • need to do more testing with everything together

Miklos

Worked on Clipboard: Implement permissions for pasting in Chrome-based browsers · Issue #8023 · CollaboraOnline/online · GitHub, now it even has cypress tests.