Status report: consultancy team, week 42, 2023

[vmiklos]

Caolan

• “zooming a lot in calc” reproduces the
  “Different tile sizes in tile requests” warning
  → different tile widths in requestedTiles on switching calc tabs by caolanm · Pull Request #7444 · CollaboraOnline/online · GitHub
• tdf#157726 regression from an attempted security fix
  → https://gerrit.libreoffice.org/c/core/+/158038
• have a look at the reported security issue of ole link contents
  fetched before prompt to allow updating
  → we should at least retain Referer info in ole objs
  https://gerrit.libreoffice.org/c/core/+/158052
• ofz#63295 Null-dereference READ
• merge some more outstanding stuff from patch-porting
• filed “SIGSEGV in SwFrame::ImplFindPageFrame” for new crash seen
  wrt STYLEREF
• “Assertion in DocumentBroker::sendRequestedTiles fails on running cypress impress tests”
  • !newTileCombined.hasDuplicates() assert continues to appear
  • realize that local log
    cypress_test/cypress/wsd_logs/coolwsd_output.log does contain
    the assert see in ci and can reproduce locally
  • these cypress tests are crazy slow, read the ladybird guide
    on cy.wait avoidance.
• comment on add support for websocket urps available >= LibreOffice 24.2 by caolanm · Pull Request #355 · jodconverter/jodconverter · GitHub
  to see if I can encourage that to get merged/reviewed
• put together a demo for xwiki ludovic of the urp thing
  • double check that it works
  • put all the bits for a standalone demo at:
    https://github.com/CollaboraOnline/online/files/12935390/officepb-collabora-online.zip
    because you need so many pieces working together
• fix a few more online coverity warnings
• play with cypress to see how to remove cy.wait() in general
  → Private/caolanm/remove cypress waits1 by caolanm · Pull Request #7474 · CollaboraOnline/online · GitHub to remove
  a wait in testing impress tables
• make check-desktop spec=writer/editable_area_spec.js is
  6m40s locally (vs 12m+ in ci), dropping the cy.wait goes to
  6m29s, oh well
• crash reporting script still claims no quarantine file in many cases
  • lets get more logging, maybe the missing docs are duplicates of an
    existing quarantined document?
    → raise quarantine logging to WRN and include more information by caolanm · Pull Request #7475 · CollaboraOnline/online · GitHub
• review https://gerrit.libreoffice.org/c/core/+/157740
  → looks mostly reasonable to me
• go back to cool#7177 wrt merge request
  → avoid logging user content from spreadsheet cells by caolanm · Pull Request #7177 · CollaboraOnline/online · GitHub
• cool#7428 notebookbar getting regenerated often
  • not quite clear why this is happening
  • online notebookbar is rebuilt once if optional zotero support is
    enabled
  • also happens on switching theme, but surely that doesn’t happen
    as much as seen in profile, some uncaptured bug there I think
• all hands
• see a low hanging crashreport in 7.6 list
  → https://gerrit.libreoffice.org/c/core/+/158124
• add an empty file for every file format in the upstream crash
  reporting
• put latest calc flamegraph at
  → calc performance with large selections - copy/paste · Issue #6893 · CollaboraOnline/online · GitHub
• put latest writer flamegraph at
  → perf: surprisingly little delta threading ... · Issue #7374 · CollaboraOnline/online · GitHub
• review move feature change
  → should use some loext: namespace and not dc:, etc
• can we avoid recreating the notebookbar so much
  → wip: avoid recreating the core notebookbar when we don't have to by caolanm · Pull Request #7494 · CollaboraOnline/online · GitHub
  but that simple approach won’t work
  • icon names are set at online notebookbar load time so switching
    theme requires a rebuild
• fix tdf#157849 crash in gtk popoup for text spacing in impress
• “ToC preview NOK in dark mode”
  → backport my fix for that
• VclDrawingArea::DumpAsPropertyTree spends a lot of time clearing
  bitmaps which then gets overwritten anyway
  → https://gerrit.libreoffice.org/c/core/+/158310
• poke at patch porting script a little
• “Port LanguageTool to master” merge last outstanding
  commit from people who aren’t with collabora anymore instead of
  adding some filter.

Mike

— Exporting multiple consecutive spaces to ReqIF-XHTML

• Implemented in master
  • A new HTML export filter option: PreserveSpaces
    → will emit ‘xml:space=“preserve”’ or ‘white-space: pre-wrap’
    → import of these is implemented, too

— Modifications to track changes do not emit LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED

• Closed successful

— Writer: Fields and placeholder issue
* Implemented the initially planned fix

Tomaz

Miklos

• 157119 – Third part of multi-page floating tables “Third part of multi-page floating tables”
  • see the bug for details