Caolan
- some online coverity warnings to test ci with
→ Private/caolan/coverity2024 05 06 by caolanm · Pull Request #8982 · CollaboraOnline/online · GitHub - review calc cnp perf
→ https://gerrit.libreoffice.org/c/core/+/167193 - fix rgba emojis
- cool#8744 consider creating canvas when dispatching request
to get tile instead of later when getting it - one of the prefetches is broken
→ Private/caolan/prefetchfixes2 by caolanm · Pull Request #8988 · CollaboraOnline/online · GitHub - and another related piece has a test the wrong way around
→ check for _docLayer existence before deref of _docLayer by caolanm · Pull Request #8987 · CollaboraOnline/online · GitHub - svm test fails with --enable-cairo-rgba
- Unit test failure when running CppunitTest_vcl_svm_test in core with cairo RGBA config · Issue #9002 · CollaboraOnline/online · GitHub for
→ https://gerrit.libreoffice.org/c/core/+/167314 - drop requirement for rtl_random_getBytes to have a pool arg
→ https://gerrit.libreoffice.org/c/core/+/167067 - stumble on a missing slide preview reproducer
chat about it with hcastro
→ preview clean up by hcvcastro · Pull Request #9016 · CollaboraOnline/online · GitHub - suggestions for “Display issue with calc after fill down and undo”
→ there are two slightly different mechanisms to determine the scale
to use for optimal row height, with the SetWidthOrHeight one
newer than the Undo one - suggestions for “Assistance Functionalities: Tables: Automatic input assistance (correction) for formulas”
→ the interactive auto-fill doesn’t dispatch a “uno command” from
online, but just sends mouse events and calc does that dispatch
internally, hidden from online - cool#8829 ponder DNS+convert-to
Tomaz
PDF Reader - Create comments / add notes – improve slide & draw commenting
- Implement popup to show the annotation note content when clicking on the object
- single click selection
- don’t select the annotation
- Make PDF import work for SdrPathObj
- import and set the properties
- Add ObjectAnnotationData, which is something every SdrObject has
- mainly to contain everything about annotation in this object
- and to prevent SdrObject rebuilds, which rebuilds half of the LO
- Rework adding and deleting annotations
- code present on the annotation manager in SD
- currently “delete all annotations” crashes for some reason
- we put annotations on the page (SdPage - SdrPage), but maybe it’s not needed - traverse all objects on the page instead and check if they are annotations
- lots of code rework needed sadly
PDF Reader - Accessibility view – bringing checker sidebar to Online
- Speed improvements for json dumping are in
- much faster, but still 3-4 seconds before the accessibility checker dialog appears
- Still not ideal as the user has no idea from the UI that the accessibility checker dialog will appear
- need to show the accessibility checker dialog, but not run the check right away
- maybe show an update button before we run the checker for the first time
- better UI
- TODO
Miklos
Worked on: