Status report: consultancy team, week 45, 2023

Status reports
1

Caolan

  • debug calc slowdown
    → already fixed, run away event handlers in headerbar
  • poke at cypress test for null delta update
  • slide preview not sending tileprocessed
    → I can reproduce a “Tileprocessed message did not arrive in time”
    warning with impress, though maybe not the warning they see
    → 'Tileprocessed message did not arrive in time' for slide preview by caolanm · Pull Request #7626 · CollaboraOnline/online · GitHub
  • cypress test for invalidation regression testing
  • build fails in cypress tests wrt Page 1 and 2 of 2, vs Page 2 of 2
    → https://github.com/CollaboraOnline/online/pull/7632 to allow both.
  • video for ms automated testing
  • looks in download for input files
  • docs are tested in msoffice first
  • if they fail there are renamed in download to doc.failed
  • converted with asan staging
    • not re-converted if they exist in “converted” output dir
  • then results in “converted” tested in msoffice again, and renamed
    to doc.failed in converted if that happens
  • ./resetFailed.bat script will rename back the “download” ones
    to non .failed
  • cypress + invalidations regression
    → mostly works locally, fails in ci, blast
    → unreliable for some reason
  • DeepL stopped working
  • this is because latest curl which means https doesn’t work
    anymore, and this one of the broken cases
  • Debug why invalidation tests are unreliable
  • cypress is innocent, online is really sending extra updates of
    a fairly arbitrary non-stable amount on first connection
    → empty updates seen on first view of document by caolanm · Pull Request #7648 · CollaboraOnline/online · GitHub

Mike

  • Question: After saving signed document, signing is
    removed, but macros remain signed (DGFIP)
    • A mess of interaction
    • DocumentMacroMode::adjustMacroMode calls hasTrustedScriptingSignature,
      which asks to enable macros
    • But then may disable it
    • Or ask again in “confirmation is required” section …
    • Contradicting requirements
    • A compromise is to start with Medium level (Thorsten cares about the
      default High), and later do changes keeping the hardened security by default
      (have a configuration).
    • Created a bunch of changes
    • Last changes in the task.
    • Samuel pointed out, that an expert configuration
      (officecfg::office::Common::Security::Scripting::CheckDocumentEvents) allows
      to disable the hardened security for High level; so my plan to introduce one
      is now obsolete; nice! Missed that, because it was hidden under
      ‘GetMacroCallsSeenWhileLoading()’ call.
    • Backporting to 7-6.
  • Libre Office build without ssl implementations
    • fixing build…
    • Found the three elements in RepositoryExternal.mk / Repository.mk,
      present in master

Tomaz

First-page header and footer from and to DOCX

  • Move all header/footer tests into one place
    • much easier to test the various scenarios instead of having the test
      spread out in multiple ooxmlexport* and ooxmlimport* classes
  • Change copying of page styles with first, left, right header/footer
    content
    • split into 2 methods
    • first one copy whole page style - source content will be copied to
      target content
    • second copy method can be parameterized, copying only what content makes
      sense (and is not yet set)
    • first copy is used when making a new page style for even/odd only pages
    • second copy is used when we have linked headers/footers in sections and
      we need to copy specific (not set) content
    • copying also needs to clean the already set content in the page style -
      so we don’t append the content by mistake
  • Fixed some tests:
    • evenAndOdd setting enabled
    • title page enabled

Miklos