Collabora Online Weekly Meeting #170
Date: 30th May 2024
All minutes published on: https://forum.collaboraonline.com/tag/meeting-minutes
- Pedro, Vivek, Bayram, Anna, Attila, Ezinne, Meven, Skyler, Darshan, Hubert, Cor, Nicolas, Andras, Gökay, Mike D, Gulsah, Gabriel, Szymon, Caolán, Thorsten
- https://share.collabora.com/index.php/s/Ya2D62K7nQmczaW [Password - coolmeeting]
-
CODE 24.04.3.1
-
Released
-
CODE: 24.04.4.1 Next week
-
CO release expected to happen today/tomorrow.
-
Mobile releases are in testing mode ……
-
Builds created
-
available in the testflight
-
1 blocker to go for Android hopefully to have this fixed
- Android: Cannot open files again
-
-
-
PRs in need for attention (Please add here any PR that needs attention)
-
PRs without reviewer https://github.com/orgs/CollaboraOnline/projects/3/views/2
-
now 2
-
Karthik (welcome)
-
Mobile developer with 8 years of experience from India
-
Has document app where it needs to convert
- Exploring options to convert documents to PDF and then found LO and by extension COOL
-
Happy to contribute
-
Skyler: for iOS we use Objective-C
-
First PR: Updating error message for node check while building cool for iOS. #9133
- Pedro: Find another easy hack and ping Karthik
-
-
Nicolas
-
Gabriel
-
Now back
-
We have started to upgrade now to 23
-
Working now on something related to CSV and probably will backport it but I’m waiting for some feedback → https://gerrit.libreoffice.org/c/core/+/165905
-
this was mostly useful for converting CSV → PDF – because separators were not found
-
idea was to detect automatically at conversion.
-
First patch – adds character-set and separator settings
-
can use these when you pass the filter parameters.
-
Instead of separator & character set put ‘detect’
-
-
Would be nice to use it in the import dialog.
-
-
Would love to help out with design for serializing settings (Michael)
-
Julius
-
Nextcloud 29 released
-
Getting much more frequent races causing a download of the file … when clicked. (Michael)
-
seems like a richdocuments / Nextcloud race… perhaps more plugins installed …
-
now have draw.io/BPMN/etc. etc. in the list here … probably related to this.
-
-
Quite some fixes also backported to older releases
-
Updating files when running out of quota
-
Issues with open locally, we now terminate the session properly before handing over to local editing
-
Fix for using different URLs for internal communication
-
-
Ongoing work on polishing the guest name picker and cleanup of some very old code
-
Doing some testing and screen recordings around usability and performance
-
Thorsten
- No update
-
Attila
-
Working on a image stretch/crop issue in impress.
https://bugs.documentfoundation.org/show_bug.cgi?id=153008 (it is a resolved bug, but someone commented document that is still not working)
Was able to make it display correctly by hacking some data manually in rendering.
Now I trace where this data are came from, to find a spot where I could use crop property saved into the sdrObject -
Andras
- No update
-
Szymon
-
Current: view jump in Calc on row insertion by other user
-
have a fix, need to pass CI
-
found and fixed 2 other small bugs: not showing cell on load, not following in the other sheet
-
-
Snackbar queue – to not miss any information
-
Working on showing some useful information about the server for admins
-
Next: Pedro’s report - now unotoolbuttons are being enable/disable but the inner child is not being enabled or disabled: search previous and search next
-
Darshan
-
Fix state update of input element https://github.com/CollaboraOnline/online/pull/9165
-
Close mobile icon should be hidden in desktop #9164 => Merged https://github.com/CollaboraOnline/online/pull/9164
-
Replace ruler height hard coded value with css-variable => Merged https://github.com/CollaboraOnline/online/pull/9155
-
Add missing dark mode icons for 24.04 #9149 => Merged https://github.com/CollaboraOnline/online/pull/9149
-
Color contrast between text area and text area should be higher => Merged https://github.com/CollaboraOnline/online/pull/9050
-
Vertical ruler in writer: => Merged
-
CORE Patch: https://gerrit.libreoffice.org/c/core/+/167481
-
WIP patch online: https://github.com/CollaboraOnline/online/pull/9030
-
-
Typescript conversion of Ruler.js. Next will create base class for ruler which will help to remove duplication of code occurring in horizontal and vertical ruler file.
-
Next:
-
More improvements on accessibility stuff
-
Add ruler functionality in presentation document => Hold
https://github.com/CollaboraOnline/online/pull/8966
-
-
Antony
-
Michael “Performance” Meeks ^^
-
Background auto-save for 24.04
-
Now enabled for all saves (except file write) not just auto-save
-
new code to turn bgsave off if:
-
any dialog pops up during save
-
any save fails, or save process crashes
-
-
Chasing intermittent “too many thread” issues.
-
More unit tests
-
Fix save icon modified status in classic toolbar
-
-
Kinder to browsers / proxies:
-
Content-Length restoration in 24.04
-
plus missing Connection: Close where needed
-
-
SenderQueue acceleration
- profile form Neil.
-
Caolan performance
-
Bisected a calc pdf export perf regression
-
“tagged” spreadsheet pdf export will export markup for every cell, so 100k rows by 20 cols is millions of entries which is problematic
- bisected to tdf#123870 sc: fix tagged content for accessible PDF export https://cgit.freedesktop.org/libreoffice/core/commit/?id=b3c93b16d62e809500005edc749af4b8ad10162c
-
-
dns stalls seen in watchdog profiles – threaded that
-
fixed, disappeared from watchdog profiles
-
might be nice to poke at the warning spew (Michael)
- https://github.com/CollaboraOnline/online/pull/9143 to get some more info
-
-
wip: idea to reschedule queue processing timeout if there are tile rendering predicted to happen
-
Watchdog profiles
-
auto git commit of profiles
-
-
Bayram
-
(Closed) - Assistance Functionalities: Automatic text completion of columns/rows
-
PR1: https://github.com/CollaboraOnline/online/pull/8981 (merged)
-
core1: https://gerrit.libreoffice.org/c/core/+/167726 (merged)
-
core2: https://gerrit.libreoffice.org/c/core/+/168086 (merged)
-
PR2: https://github.com/CollaboraOnline/online/pull/9135 (merged)
-
Calc: We now have two AutoFill contextmenu items (“Copy Cells”, “Fill Series”) - which should appear immediately after we do AutoFill by dragging
-
-
(To Test) - Assistance Functionalities: Tables: Automatic input assistance (correction) for formulas
-
core: https://gerrit.libreoffice.org/c/core/+/168161 (merged)
-
online: https://github.com/CollaboraOnline/online/pull/9172 (merged)
-
Calc: label “Structure:” changed to “Functions in use and their validity:” and fix misalignment.
-
-
(In Progress) - Enhancement - Support Power Query in XLSX
-
core: https://gerrit.libreoffice.org/c/core/+/164290 (WIP)
-
get back to work on that…
-
-
Skyler
-
Mobile releases
-
Waiting for an Apple review
-
While that’s going on, I’m solving some other bugs
-
-
Desktop / Zoom causing view jumps
-
Merged → https://github.com/CollaboraOnline/online/pull/9154
-
Looking at backporting this to 23.05
-
-
UI Preference inconsistency fix (https://github.com/CollaboraOnline/online/issues/9166)
-
https://github.com/CollaboraOnline/online/pull/9181 → Waiting for Szymon’s review
-
Ready for review, fixes ui_defaults=SavedUIState=false as well as misc other issues
-
BREAKING-CHANGE: This changes the naming of many of the preferences in localStorage, effectively resetting lots of UI preferences … but I think that it’s better to do it than come up with some ugly hack to try to translate all these things to their past names
-
Also in the same PR: dark mode is no longer on a per-app basis
-
Also in the same PR: fix a race condition where Ic661358cd47600ec9c3a329bef361b8087483017 (a CI fix) would not always be applied
-
-
Pranam
-
Gökay
-
Continues:
-
Replace lat & long logic with twips / pixels.
-
Sending new improvements.
-
-
Some small fixes and reviews.
-
Copy text with comments issue. Has a PR but needs to check the tests also.
-
Hubert
-
draw/impress: Added the convert curve command
-
Still Working on a Drupal integration
-
Gulsah
-
Calc formula auto complete feature
-
A base class is created for new function auto complete widget
-
https://github.com/CollaboraOnline/online/pull/8981 (merged)
-
https://github.com/CollaboraOnline/online/pull/9071 (merged)
-
Szymon requested some changes on. I’ll work on them.
-
-
-
New button that inverts only document colors in dark mode.
-
Completed for writer impress draw
-
Working on a follow-up commit for calc. Calc background is different from others
-
https://github.com/CollaboraOnline/online/pull/9086 (merged)
-
https://github.com/CollaboraOnline/online/pull/9153 (waiting to merge) → now merged
-
https://gerrit.libreoffice.org/c/core/+/168019 (waiting to merge)
-
-
Neil
-
Vivek
- Improvements around conditional formatting dialog → awaiting for review
-
Timur
-
Méven
-
Font combo UI adjustment MERGED https://github.com/CollaboraOnline/online/pull/9029
-
use notebookbar by default in case of misconfiguration or deprecated “classic” setting MERGED https://github.com/CollaboraOnline/online/pull/9017
-
adding sanity check for wopi configuration https://github.com/CollaboraOnline/online/pull/4353 IN PROGRESS
-
-
Cor
-
Found the (easy) cause of a single keyboard shortcut issue/regression on Desktop, caused by a COOL commit.
Gökay will patch that. -
Dived into presentations/templates (weeks ago) trying to understand the cascading of styles and DF, which is ‘more interesting’ than e.g. Writer. Helps to clean up stuff. Later will look into my macro’s (from previous work) for cleaning/standardizing existing slides.
-
-
Forum (Mike D)
9 topics bumped + 6 posts by me this week.
Thanks to mmeeks + Hub + Tex for answering some posts.
MAJOR BUG
-
https://forum.collaboraonline.com/t/password-for-read-write-mode/2654
- Spreadsheet with password can be "File > Download As" to create file without password.
-
-
A recent user updating 24.04.3 + Nextcloud 28/29 losing content after save.
- Said same exact setup on 23.05 was stable.
-
→ mmeeks is on it, plus user is helping gather more info/logs.
-
Key Topics
-
https://forum.collaboraonline.com/t/nextcloudoffice-excel/2622/7
-
User from a few weeks back posted screenshots.
-
AutoFilter + Protected/Hidden Cells/Sheets
-
Excel = no info appears in dropdown.
-
Collabora/Nextcloud = yes, everything shows.
-
-
-> I asked for a sample document.
-
-> Looks like it could be a LO core issue / missing feature.
-
-
-
Author who wanted a “focus mode”:
-
No/minimal toolbars, minimal formatting buttons, “keeping text centered”, …
-
(Pretty much a text editor that allows some bold/italics and headings… lol.)
-
-
-> I answered with some of my book/writing knowledge.
-
(I’ve stumbled upon a lot of this “focus mode” stuff over the years too… bah. Why not just use basic text editors or other tools?)
-
-
Questions:
-
Karthik
I am happy to share that I completed building Mobile project for iOS and able to run in my device successfully. My requirement is to convert office files like docx, xlsx and ppt to PDF files completely offline in my current project. I tested the same feature in Mobile project from cool and it is working like a pro.
Could you please suggest how exactly to link this Mobile project to my current project to have that functionality in my project.
- 06**/06/2024**