Collabora Online Weekly Meeting #171
Date: 6th Jun 2024
All minutes published on: Topics tagged meeting-minutes
1. Attendees (write your name):
• Bayram, Anna, Ezinne, Méven, Andras, Darshan, Attila, Gulsah, Hub, Caolán, Skyler, Mike D
2. Testing
• https://staging-perf.eu.collaboraonline.com/nextcloud/index.php/s/Y4jcqreiLb4sqY2 [Password - coolmeeting]
3. Release Schedule
◦ CODE: 24.04.4.1 This week
◦ CODE: 24.04.4.2 in 2 weeks.
◦ CO released
• Mobile releases are in testing mode ……
◦ Builds created
available in the testflight
1 blocker to go for Android hopefully to have this fixed
• Android: Cannot open files again
4. Online Activity
• PRs in need for attention (Please add here any PR that needs attention)
• PRs without reviewer Collabora Online · GitHub
• now 2
• Karthik (welcome)
◦ Mobile developer with 8 years of experience from India
◦ Has document app where it needs to convert
Exploring options to convert documents to PDF and then found LO and by extension COOL
◦ Happy to contribute
◦ Skyler: for iOS we use Objective-C
◦ First PR: Updating error message for node check while building cool for iOS. #9133
Pedro: Find another easy hack and ping Karthik
• Nicolas
•
• Gabriel
• Now back
• We have started to upgrade now to 23
• Working now on something related to CSV and probably will backport it but I’m waiting for some feedback → https://gerrit.libreoffice.org/c/core/+/165905
◦ this was mostly useful for converting CSV → PDF – because separators were not found
◦ idea was to detect automatically at conversion.
◦ First patch – adds character-set and separator settings
can use these when you pass the filter parameters.
Instead of separator & character set put ‘detect’
◦ Would be nice to use it in the import dialog.
• Would love to help out with design for serializing settings (Michael)
• Julius
• Nextcloud 29 released
• Getting much more frequent races causing a download of the file … when clicked. (Michael)
◦ seems like a richdocuments / Nextcloud race… perhaps more plugins installed …
◦ now have draw.io/BPMN/etc. etc. in the list here … probably related to this.
• Quite some fixes also backported to older releases
◦ Updating files when running out of quota
◦ Issues with open locally, we now terminate the session properly before handing over to local editing
◦ Fix for using different URLs for internal communication
• Ongoing work on polishing the guest name picker and cleanup of some very old code
• Doing some testing and screen recordings around usability and performance
• Thorsten
◦ No update
• Attila
• Finished (it is merged) the a image stretch/crop issue in impress.
153008 – FILEOPEN PPTX: images (clipped against a shape) appear horizontally compressed
• Started working on a pieChart issue. (Leader line color is wrong )
• Andras
◦ No update
• Szymon
• Current: view jump in Calc on row insertion by other user
◦ have a fix, need to pass CI
◦ found and fixed 2 other small bugs: not showing cell on load, not following in the other sheet
• Snackbar queue – to not miss any information
• Working on showing some useful information about the server for admins
• Next: Pedro’s report - now unotoolbuttons are being enable/disable but the inner child is not being enabled or disabled: search previous and search next
• Darshan
• Print slides with notes #9198 => Merged
Print slides with notes by Darshan-upadhyay1110 · Pull Request #9198 · CollaboraOnline/online · GitHub
• Presentations: Ruler #8966 => In Review
Presentations: Ruler by Darshan-upadhyay1110 · Pull Request #8966 · CollaboraOnline/online · GitHub
https://gerrit.libreoffice.org/c/core/+/167060
• Vertical ruler in writer: => Merged
◦ CORE Patch: https://gerrit.libreoffice.org/c/core/+/167481
◦ WIP patch online: Add vertical ruler for writer by Darshan-upadhyay1110 · Pull Request #9030 · CollaboraOnline/online · GitHub
• Typescript conversion of Ruler.js. Next will create base class for ruler which will help to remove duplication of code occurring in horizontal and vertical ruler file.
• Next:
◦ Investigation on icon errors in console
◦ More improvements on accessibility stuff
• Antony
•
• Michael “Performance” Meeks ^^
• Background auto-save for 24.04
◦ Now enabled for all saves (except file write) not just auto-save
◦ new code to turn bgsave off if:
▪ any dialog pops up during save
▪ any save fails, or save process crashes
◦ Chasing intermittent “too many thread” issues.
◦ More unit tests
◦ Fix save icon modified status in classic toolbar
• Kinder to browsers / proxies:
◦ Content-Length restoration in 24.04
◦ plus missing Connection: Close where needed
• SenderQueue acceleration
◦ profile form Neil.
• Caolan performance
• A good perf related fix from Chris Lord
◦ https://github.com/CollaboraOnline/online/pull/9212 (merged)
• Some ideas around using worker threads from Chris
◦ https://github.com/CollaboraOnline/online/pull/9208
• idea to reschedule queue processing timeout if there are tile rendering predicted to happen
◦ https://github.com/CollaboraOnline/online/pull/9130 (merged, done)
• dns stalls seen in watchdog profiles, fix merged
◦ might be nice to poke at the warning spew (Michael)
▪ https://github.com/CollaboraOnline/online/pull/9143 to get some more info on that
• Watchdog profiles
◦ auto git commit of profiles
▪ https://github.com/caolanm/profiles/tree/co-24.04/watchdog
• Bayram
• (Closed) - Assistance Functionalities: Tables: Automatic input assistance (correction) for formulas
◦ core: https://gerrit.libreoffice.org/c/core/+/168161 (merged)
◦ online: https://github.com/CollaboraOnline/online/pull/9172 (merged)
◦ Calc: label "Structure:" changed to "Functions in use and their validity:" and fix misalignment.
• (In Progress) - Enhancement - tdf#158857: Keep Power Query when saving XLSX
◦ core: https://gerrit.libreoffice.org/c/core/+/164290 (WIP)
◦ submitted patchset 14. -> added <webPr> (Web Query Properties) support.
◦ now: add <tables>, <m>, <s>, <x> elements under <webPr>.
• Skyler
• Mobile releases
◦ Expecting to release 23.05.12 on iOS today/tomorrow!
• Desktop / Zoom causing view jumps
◦ Merged → https://github.com/CollaboraOnline/online/pull/9154
◦ 23.05 backport merged → https://github.com/CollaboraOnline/online/pull/9188
• UI Preference inconsistency fix (https://github.com/CollaboraOnline/online/issues/9166)
◦ https://github.com/CollaboraOnline/online/pull/9181 → Approved, merged
◦ Had a regression reported to me yesterday, fix also approved & merged: https://github.com/CollaboraOnline/online/pull/9222
• Mobile RTL Scroll fixes
◦ https://github.com/CollaboraOnline/online/pull/9203 → Approved, merged
• Now working on comments causing viewport movement on iOS
• Pranam
•
• Gökay
• Continues:
◦ Replace lat & long logic with twips / pixels.
◦ Sending new improvements.
• Some small fixes and reviews.
• Copy text with comments issue. Has a PR but needs to check the tests also.
• Hubert
• No updates
• Gulsah
• New button that inverts only document colors in dark mode.
◦ Completed for Writer Impress Draw
◦ https://github.com/CollaboraOnline/online/pull/9086 (merged)
◦ https://github.com/CollaboraOnline/online/pull/9153 (merged)
◦ https://gerrit.libreoffice.org/c/core/+/168019 (merged)
◦ Completed for Calc
◦ https://github.com/CollaboraOnline/online/pull/9205
▪ Approved by Gökay, waiting to pass CI, There is a unrelated fail)
• Changing dark mode affects other users link colors.
◦ Investigating...
• Neil
•
• Vivek
◦ Improvements around conditional formatting dialog → awaiting for review
• Timur
•
• Méven
◦ adding sanity check for wopi configuration https://github.com/CollaboraOnline/online/pull/4353 IN PROGRESS, porting to internal framework async methods
• Cor
◦ Found the (easy) cause of a single keyboard shortcut issue/regression on Desktop, caused by a COOL commit.
Gökay will patch that.
◦ Dived into presentations/templates (weeks ago) trying to understand the cascading of styles and DF, which is ‘more interesting’ than e.g. Writer. Helps to clean up stuff. Later will look into my macro’s (from previous work) for cleaning/standardizing existing slides.
• Forum (Mike D)
8 topics bumped + 5 posts by me this week.
Thanks to Rash + Tex (+ Ash for debugging a user’s issue on Github) for answering some posts.
Key Topics
• I cannot stop a slide show on Android
◦ Android + Impress: Can’t “Escape” Presentation
◦ Samsung Galaxy Tab S9 FE+
◦ It worked okay on mine.
(I did run across weird “Dark Mode” issue. Sample Presentation was white-on-white text. I had to flip on Light Mode, then present, then I could read the text.)
(Also jerky slides moving up because of keyboard popping up.)
Updates from previous:
• NextcloudOffice Excel - #11 by NicolasGlatz
◦ User with AutoFilters acting differently Excel / Collabora/LO
→ Shared sample XLSX.
• I asked for a little bit smaller MWE (Minimal Working Example) too.
◦ I was able to display some hidden data in their sample file.
• Password for read-write mode - #3 by Franzca71
◦ User with passworded file → File > Save As = No Password
→ Shared sample XLSX.
◦ I uncovered some pain points (very confusingly worded menus + glitchy filename presentations in LO).
• Collabora 24.04.3.1: losing content of file even after saving it on Nexctloud - #9 by azz
◦ User with saving troubles.
◦ Ash narrowed it down to:
Very low # of CPU cores (1 CPU instead of 4 recommended).
Antivirus running, really slowing user’s network down to a crawl + using 100% CPU.
• Questions:
• Karthik
I am happy to share that I completed building Mobile project for iOS and able to run in my device successfully. My requirement is to convert office files like docx, xlsx and ppt to PDF files completely offline in my current project. I tested the same feature in Mobile project from cool and it is working like a pro.
Could you please suggest how exactly to link this Mobile project to my current project to have that functionality in my project.
5. Next events
•
6. Next meeting
• 13/06/2024