Collabora Online Weekly Meeting #128
Date: Jul 20th 2023
All minutes published on: Topics tagged meeting-minutes
Attendees (write your name):
- Darshan, Szymon, Anna, Mike D (Tex), Shehr, Gülşah, Aron, Rashesh, Pedro, Timur, Nicolas, Cosmin, Skyler, Attila, Ezinne, Pranam, Oli
Welcome Oli
- Student starting to hack on Collabora Online, Skyler mentoring here, thanks!
- Has already a local build working
- Next → Up and down arrow keys should move focus up/down a level · Issue #6933 · CollaboraOnline/online · GitHub
- Also please take a look and take into accound Darshan’s work on a similar issue: Left or right arrow key on a tab label should switch tabs · Issue #6934 · CollaboraOnline/online · GitHub
Release schedule (Anna)
- CODE release
- Found some bugs , chasing that
- Probably will be released today (20 Jul)
- Code freeze also today
- Mobile releases probably at the end of August
- Next iOS testflight – Attila is on it;
- no clear date when to release yet
- Android
- same as iOS
- Next iOS testflight – Attila is on it;
Testing
Today let’s focus on use this meeting to test CODE:
- Spreadsheet: COOLWeekly127.ods
- Presentations: basic-presentation.pptx
Forum (Mike D)
Answered a few more forum questions.
Created first PR: improves issue/enhancement markdown template: Github Issue Template Fixes by Tex2002ans · Pull Request #6944 · CollaboraOnline/online · GitHub
These were the key topics:
- Link to a Specific Cell
- Looks like Google Docs already has that Right-Click functionality:
- Right-Click > View more cell actions > Get link to this range
- Google Docs Help: “Link to a range of cells in a spreadsheet”
- How to Get a Hyperlink to a Cell or Range in Google Sheets
- AI: Pedro → smartpicker and the possibilities to link to name ranges
- (Sounds like a good enhancement, so I’ll submit a Github.)
- Looks like Google Docs already has that Right-Click functionality:
Also found strange bug where Review > Language or status bar > Language was not displaying English, just German.
16->16 - zero replies in user support:
→ User Support - Collabora Online
60->60 - zero replies in installation and config:
→ Installation & Configuration - Collabora Online
Dark mode
- Andreas K. has been helping here
- also an interesting discussion WRT paragraph styles: style previews white background · Issue #4727 · CollaboraOnline/online · GitHub , probably good to keep them with white background for now.
- We agreed, got closed.
- Darshan fixes the changing to dark mode would switch active tab
- Status bar’s icons were invisible when using dark mode → fixed and merged
- Sidebar had a strange frame surrounding it → fixed
- Missing slide previews
- We request the previews but get an error instead form the server side
- Paris will look at this
Online activity (Pedro)
- PRs without reviewer ~10 of them
- Collabora Online · GitHub
- Easy hack fix removing duplication in makefile: Condense common parameters in Makefile by codewithvk · Pull Request #6593 · CollaboraOnline/online · GitHub
- Now merged thanks codewithvk
- Now working on adding disable status menu button: Menubutton should have disabled state styling different · Issue #6877 · CollaboraOnline/online · GitHub
- Cypress issues fix: https://github.com/CollaboraOnline/online/pull/6708
- Caolan reviewed, now merged
- Gokay
- Multi language support for access keys: Add multi-language support for Notebookbar accelerators. by gokaysatir · Pull Request #6739 · CollaboraOnline/online · GitHub
- merged
- Button-ids are non-deterministic; will make them deterministic. Szymon requested changes: Provide unique ids for notebookbar buttons. by gokaysatir · Pull Request #6801 · CollaboraOnline/online · GitHub
- a11y fixes:
- Arrows keys should directly trigger the element and not just the outline(focus)
- Not have preview images in the tab order – non-interactive things not in tab order
- Focus wouldn’t cycle and would jump to the document → now Szymon on that
- Triggering the accesseys was quite flimsy in any other non chrome based browser
- Multi language support for access keys: Add multi-language support for Notebookbar accelerators. by gokaysatir · Pull Request #6739 · CollaboraOnline/online · GitHub
- Attila
- Now working on iOS → debugging
- Szymon
- JSDialogs fixes: menu button with date picker; spinfield with time
- Snackbar got fixed (a regression from vex conversion that made it modal)
- Snackbar’s button now dismisses always the snackbar
- Fixed copy-pasting problem in calc (nor possible to copy autofiltered list)
- Modified collapsed comment would get edited → merged
- Now working on fixing tab cycling on tabbed view
- Darshan
- Add tooltip for copy version button in Help tab and added some visual feedback for user after click on copy version information
- Added visual feedback after copy information into clipboard by Darshan-upadhyay1110 · Pull Request #6796 · CollaboraOnline/online · GitHub => Pending → now with conflicts needs to solve them → For now paused
- Left-right arrow to switch tab Add Left or right arrow on a tab label should switch tabs by Darshan-upadhyay1110 · Pull Request #6938 · CollaboraOnline/online · GitHub
- Add tooltip for copy version button in Help tab and added some visual feedback for user after click on copy version information
- Michael / Caolan – Performance
- Lots of things fixed…
- double rendering of canvases
- much improved debugging mode help→about tripple click – faster, better rendeirng.
- Storing compressed tiles + deltas in each tile.
- Monotonic time-stamp consistency end to end etc. …
- re-factored lots of code – and reduced duplication
- Improved unit test robustness.
- Found some good problems from calc:
- calc performance with large selections - copy/paste · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection nightmare which we try to do on keypresss – consumign cast memory & time.
- calc performance - getting tiled rendering area · Issue #6894 · CollaboraOnline/online · GitHub – wrestling with tons of time spent checking the spreadsheet tiled area on each tile render.
- Lots of things fixed…
- Shehr Pushed
-
Now → trying to improve the insert line
- Nicolas: Maybe we could investigate some improvements around the handles
- Trying to change the default thickness of the line
- Still in progress, working on this with Pedro
- Gulsah helping here on how to debug it. Fowarding GDB debug documentaiton
- Maybe a problem with IDE(?) But still trying with GDB directly wouldn’ t solve it. Same result: some files wouldn’t show on debugger
-
UITreeview doesn’t use all the available space
- Could reproduce when change orientation
- AI: Pedro will send how to see/test uitreeview on calc
-
- Skyler
- Busy with using UNO with websocket
- Pranam
- View was being pushed → got fixed: formulabar: fixed scrollIntoView caused problems by lpranam · Pull Request #6949 · CollaboraOnline/online · GitHub
- Gulsah
- Waiting for reviews
- Impress: slide sorter: enabling context menu (to insert slide and paste slide)
- trouble with referring to slides with numbers, since they get invalidated on reorder or insert or delete
- happy to help if the problem is written done (Szymon)
- Difficult to know where the slide reordering happens → so, paused for now
- Comparing now the drag n drop status and the insert new slide
- Trying to find slide id
- Switched to avoid multiple child dialogs to be open → a core side problem
- Fixed and merged: https://gerrit.libreoffice.org/c/core/+/154514
- Impress: slide sorter: enabling context menu (to insert slide and paste slide)
- Waiting for reviews
- Rashesh
- Created a issue: customize tab missing from Bullets and numbering dialog
Customize tab not available in Bullets and Numbering dialog · Issue #6777 · CollaboraOnline/online · GitHub- Skyler is working on this; Szymon requested changes https://gerrit.libreoffice.org/c/core/+/153806
- A.I. : review this two patches related to helm chart:
- https://github.com/CollaboraOnline/online/pull/5556→ merged
- Help chart for kubernetes is now easier to install:
- collabora-online 1.1.0 · collabora-productivity/collabora-online
- Thanks to genofire : )
- https://github.com/CollaboraOnline/online/pull/5556→ merged
- Android: Saving was not working: Fix android bugs by Rash419 · Pull Request #6912 · CollaboraOnline/online · GitHub
- Created a issue: customize tab missing from Bullets and numbering dialog
- Nicolas
- plan to file some issues wrt deepl
Community
- Translation stats to go out soon → SM and Forum
- Jun →
Mike D. please send that out usingweblate-leader-board-parser.py it’s now also out (SM) and published on the forum
- Jun →
LibreOffice conference (Gabriel)
- Still busy organizing the conference
-
- spreading the ideas through different means is good.
- Will be in Bucharest – and Gabriel will be organizing it too.
- LibreOffice Conference 2023 in Bucharest, Romania - The Document Foundation Blog
- Call for papers went out
- Registration is now open
- You are invited to the “Introduction in LibreOffice Development” workshop:
Next meeting
27/07/2023