Collabora Online Weekly Meeting #149
Date: Dec 21st 2023
All minutes published on: Topics tagged meeting-minutes
Please update your section
pasting “please update your section” from another instance (staging perf):
CSP warning in the console and snackbar appears for a split second right before it disappears
Please let’s test
View jumping
Open spreadsheet in 2 sessions
- select some range using mouse
- try to drag selected range
- when you will see that „selected range“ and „current cell“ are not at the same place – you are done!
- in other view go far away
- select few rows in second view and then “delete rows”
- right click on some row and use “row height” dialog, ok
Result: you jumped to the first view’s selection
Expected: no jump
Better logging for cy.cGet() by neilguertincollabora · Pull Request #7877 · CollaboraOnline/online · GitHub Better logging for cy.cGet() #7877
Attendees (write your name):
- Anna, Ezinne, Caolán, Andras, Cosmin, Timur, Attila, Gulsah, Gökay, Darshan, Bayram, Hub, Aron, Mike D, Skyler, Michael, Vivek, Nicolas, Cosmin, Szymon, Pranam, Julius,Krish Aryan
Making the call shorter
- Please update your section relating in the document before we read through it.
- Then only go over anything we need to share / get input on
Release Schedule
- CODE 23.05.6 Week 50 Released!
- Mobile releases
- iOS 23.05.6 planning to release in Jan
1. Builds are in testflight - Android 23.05.6 planning to release in Jan
- need to fix insert → comments on Mobile.
1. Vivek Has some improvements here- it’s not merged yet
- iOS
- quick smoke-testing of new build looks good (Nicolas)
AI: Test view jump again next time
Krish Aryan
- Google summer of code (openSUSE)
- Basic K8s , docker
- Project URL: Google Summer of Code
- Linkedin: https://www.linkedin.com/in/krish-aryan-171563154/
Julius
- New release pending for later today
- Spreadsheet status bar show by default
- Version access for shared files (server release 27.1.5, released)
- For Nextcloud 28 additional things landed (new major version coming next week)
- Improved setup checks to make setup errors easier to fix for admins
- Additional option to configure URL for internal communication between Nextcloud/online
- Sidebar concerns:
- Open in new tab by default (?)
- UX testing feedback tells us that files in new tabs is a serious issue
- Plan to tackle all the things that are not working (middle click etc)
- Google opens in a new tab by default (Nicolas)
- A website that is an application: a “file explorer” (Pedro)
- user expects, the file opens – something new happens.
- May be needed inside the Nextcloud server – not in richdocuments (Julius)
- Update: Discussion in our weekly meeting with designers
- We’ll as a first step look into making ctrl click/middle mouse click/back buttons in the browser work/behave correctly
- UX testing feedback tells us that files in new tabs is a serious issue
- WASM
- WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
- richdocuments pull request ready, what version is wasm expected for?
- No pressing needs, let’s just merge this for main branch
- WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
- Issue with renaming documents failed, opening was no longer possible afterwards
- Julius will check logs and report at online with more details
Nicolas
- Nothing of relevance; in listening mode.
Online activity
-
Bugs caught during this meeting
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
- Issue: AI(Pedro): To file bug
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
-
Attila
- Working on PPTX hyperlink problem
154248 – FILEOPEN PPTX: multiline field wrapping breaks rendering of links (and font changes)
It is not an import problem as I though…
Probable it is in the layouting/rendering - working on Language change problems (sidebar, statusbar) Calc: Sidebar Changes Language · Issue #7492 · CollaboraOnline/online · GitHub
Szymon asked me to not set language at SfxBindings::Update_Impl,
instead try to make it synchronous, so I try to search where
these timers are started, and check how it result if I use invoke().
- Working on PPTX hyperlink problem
-
PRs without reviewer 6
-
Szymon
- Working on view jumping
- found reproducer for more cases reported by Anna!
- Fix: Calc: don't stop dragging the selection on quick move by eszkadev · Pull Request #7878 · CollaboraOnline/online · GitHub
- Fixed Drag and drop in Firefox in Pivot table dialog:
- Added warning when insert image from remote is blocked:
- Working on view jumping
-
Darshan
- View jump caused by Autofilter popup 7832 => Merged
- Fix all major issue Calc autofilter
- Disable Select/Unselect-current Filter Checkboxes in Calc https://gerrit.libreoffice.org/c/core/+/160082 => Merged
- Filter by color options in Auto filter is working now 7824=> Merged
- Be consistent with LO for auto-filter popups. We need radio buttons for filter by color selection to be more consistent with LO.
- Online side changes to add radio button in Treeview based on JSON data. Filter by color options should have radio buttons insted of Checkboxes by Darshan-upadhyay1110 · Pull Request #7854 · CollaboraOnline/online · GitHub => Merged
- Add “checkboxtype” property ( radio or checkbox ) from CORE to send with JSON data for Treeview widget. https://gerrit.libreoffice.org/c/core/+/161043 => Merged
- More cypress test “AutoFilter” 7879 => In Review
- Small fix for typing text in font and style input dropdown dark in Dark mode 7867=> In review
- Child popup in auto-filter always comes to a fix place on screen ( on left side in middle of the screen ). it should not behave like this. Child-pop-ups should be positioned according to parent position.
- Strange option Separator is added to widgetTree view of auto-filter. This case also needs to be handled from core side. As the Separator is not an entity it is just a visual representation. => Will start next
-
Vivek
- Work in progress - Scroll bar animation on mouse hover event (pause)
- Comment dialogue looking odd in mobile view => In Review
- Android Insert Cell Menu Misaligned Radio Button => In Review
- Many Icons Not Inverting Color In Dark mode cool-help => Merged
- WIP - Async more dialogs
- Not Started - wasteful commandvalues CharFontNAme
-
Michael / Caolan – Performance
- Potential optimization for menubar updating seen in COOL call where we probably don’t need that effort
- https://gerrit.libreoffice.org/c/core/+/160465 to review, after current release
- Mystery case of another apparent viewid mismatch with a single user and new calc document outstanding
- Potential optimization for menubar updating seen in COOL call where we probably don’t need that effort
-
Testing results:
- Dark mode now working nicely.
- Found some good problems from calc:
- generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
- may be a red-herring.
- generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
-
Bayram
- Calc: sheet drop zone is too small · Issue #7813 · CollaboraOnline/online · GitHub - Calc: sheet drop zone is too small #7813
- Status: To Test
- Patch: (Merged) Calc: improve drag&drop functionality of sheet tabs by bayramcicek · Pull Request #7846 · CollaboraOnline/online · GitHub - Calc: improve drag&drop functionality of sheet tabs #7846
- Follow-up patch: (Merged) Calc tabs: remove drop zone indicator after drop by bayramcicek · Pull Request #7855 · CollaboraOnline/online · GitHub - Calc tabs: remove drop zone indicator after drop #7855
- Working on “Calc: collapsing groups does not hide its child groups”
- Calc: sheet drop zone is too small · Issue #7813 · CollaboraOnline/online · GitHub - Calc: sheet drop zone is too small #7813
-
Skyler
- Got a few changes which need review, all tests have passed on all of them. Bold ones are more important
- Calc keyboard popping down
- Waiting for review on https://gerrit.libreoffice.org/c/core/+/160313 → someone to test it before merging it
- May be nice to get another review on Stop onscreen keyboards closing when used to move by Minion3665 · Pull Request #7797 · CollaboraOnline/online · GitHub
- Touchscreen fixes
- Need reviews on Followup to unified touch handling by Minion3665 · Pull Request #7712 · CollaboraOnline/online · GitHub
- May want second followup to investigate 2 more dubious lines from the first commit, out-of-scope for this followup as I think they’ll take longer than I want to wait to merge this
-
Pranam
- Revamp comment autosave feature
- Reverted all the previous patches of the feature
- More simple implementation using existing workflow
- Hopefully will remove comment regressions
- Then new cypress test for autosaved comments (multiple users) will also be needed
- Revamp comment autosave feature
-
Gökay
- Working on a read only mode feature that will allow clicking on a hyperlink.
- Clicking on hyperlinks in read-only mode is ready to be reviewed for Writer.
- Core side has already been merged.
- After getting the Online side in, I will continue with Calc and Impress.
- Will write unit tests for the solved issues.
- Pending.
- Impress mobile view:
- Long press and select “cut” from the context menu.
- It doesn’t work.
- I will be checking this.
- Working on a read only mode feature that will allow clicking on a hyperlink.
-
Hubert
- Started some of the Draw (and by extension Impress) improvement work.
- No change
- More postmessage test harness: framed.doc: Added postmessage for Get_User_State by hfiguiere · Pull Request #7876 · CollaboraOnline/online · GitHub
- Merged: SDK doc updates for new postmessages in 23.05.6
- Started some of the Draw (and by extension Impress) improvement work.
-
Gulsah
-
Editing a cell without exiting the cell edit mode and then clicking the ‘+’ to insert a new sheet moves the entered content into that new sheet.
-
Szymon suggested move solution to core so I did:
-
Overwrite follow up PR of configurable override mode
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
- I triggered the cypress test several time but failed on unrelated part.
- Cypress tests locally failed too but couldn’t return back to work this.
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
-
Currently working on ““Download” and “Download as” are not working at all”
- Fixed by Coalan’s commit: add hasWASMSupport to capabilities by caolanm · Pull Request #7784 · CollaboraOnline/online · GitHub
-
Calc: Columns and rows are not activated on mouseDown
- I noticed that the problem is just latency, Actually activates but after than 5-8 sec later.
- Debugging…
-
-
Andras
- No update
-
Pedro
-
Mike D
- LanguageTool: a strange/interesting bug on LO. Will look into this.
Forum (Mike D)
4 new posts happened this week (3 posts answered by me).
Key topics:
-
Android app: Editing a copy always required for every file - #2 by Tex
- Android user with file opening / read-only troubles gave a lot more debug info.
- “The problem happens when I open a file directly from the Android file system. The problem doesn’t happen when I open a file from within Collabora Office.”
- Mike: Will have to test their steps + recommend opening issue on Github.
-
Show table again / Tabelle wieder einblenden
- Calc: Show/Hide Sheets problem?
- I wrote a “How to Hide or Show a Sheet in Calc” tutorial with screenshots.
- UX Note: The “Show Sheet” dialog seems incredibly awkward/clunky. See 3rd screenshot.
- At least add a title on the popup so you know what it’s supposed to be doing.
- Buttons should be flipped/renamed from Cancel/Close to Show/Cancel.
- (Or usual OK/Cancel.)
-
Collabora for Android to import data from URL
- Android: Importing data from URLs possible?
- I asked for more info.
- → Not possible. (CSV locally + Collabora will import dialog.)
- Seems like it might be that WEBSERVICE thing creeping up again.
- Android: Importing data from URLs possible?
-
Lock/write-protect cells in table
- Write-protected cells in Nextcloud Office Calc.
- → I answered with a quick workaround of hide/unhide sheets/columns.
- Unsure on technical details. Hopefully they give more info on their use-case.
-
Last Week Check-in:
-
iOS iPad trackpad support? - #4 by Tex
- Came back with more iPad + keyboard with trackpad info.
- Logitech Combo Touch keyboard + iPadOS 17.1.1.
- Might be some good hardware to get a dev/QA?
- Skyler: I made a purchase request for an iPad with a keyboard and trackpad, maybe I could look at this when I get it
- Skyler: Also, this sounds like the sort of thing that might have been fixed with my touch patches… testing on master would be excellent!
- Skyler: I made a purchase request for an iPad with a keyboard and trackpad, maybe I could look at this when I get it
- AI (Pedro): reach out and create staging accounts
11 → 11 - zero replies in user support:
→ User Support - Collabora Online
37 → 37 - zero replies in installation and config:
→ Installation & Configuration - Collabora Online
Next events
- COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – COOL Days 2024 - 8-10 April - Cambridge, UK - Collabora Office and Collabora Online
- We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
- What to do next
- Passport & VISA
- Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
- Apply for a VISA if needed.
- Register for the event: https://eventyay.com/e/0512424d
- Submit a talk:
- What to do next
-
Next meeting