Community Weekly Meeting #148

[pedro.silva]

Collabora Online Weekly Meeting #148

Date: Dec 14th 2023

All minutes published on: Topics tagged meeting-minutes

Please update your section

please update your section

Attendees (write your name):

1. Anna, Ezinne, Caolán, Andras, Cosmin, Timur, Attila, Gulsah, Gökay, Darshan, Bayram, Hub, Aron, Mike D, Skyler, Michael, Vivek, Nicolas, Cosmin, Szymon, Pranam, Julius,Krish Aryan

Making the call shorter

• Please update your section relating in the document before we read through it.
• Then only go over anything we need to share / get input on

Release Schedule

1. CODE 23.05.6 Week 50 (most probably tomorrow)
2. Most of patches that are planned to have in release are merged
3. Most of Tickets that needed to be
4. Mobile releases
5. iOS 23.05.6 Week 48 (?)
6. Android 23.05.6 Week 48 (?)
7. need to fix insert → comments on Mobile.
   1. Vivek Has some improvements here
   1. not sure if it merged.
8. iOS
9. quick smoke-testing of new build looks good (Nicolas)

Krish Aryan

• Google summer of code (openSUSE)
• Basic K8s , docker
• Project URL: Google Summer of Code
• Linkedin: https://www.linkedin.com/in/krish-aryan-171563154/

Julius

• New release pending for later today
  • Spreadsheet status bar show by default
  • Version access for shared files (server release 27.1.5 pending next Thursday)
  • For Nextcloud 28 additional things landed (new major version coming next week)
    • Improved setup checks to make setup errors easier to fix for admins
      • Improve setup checks and url handling with separate callback url by juliushaertl · Pull Request #3315 · nextcloud/richdocuments · GitHub
    • Additional option to configure URL for internal communication between Nextcloud/online
• Sidebar concerns:
  • [stable27] fix: Avoid triggering a defered sidebar open if openFile is already handling that by juliushaertl · Pull Request #41636 · nextcloud/server · GitHub merged
    • Will be released with 27.1.5 next Thursday
• Open in new tab by default (?)
  • UX testing feedback tells us that files in new tabs is a serious issue
  • AI: share feedback with Julius (Pedro)
  • Google opens in a new tab by default (Nicolas)
  • A website that is an application: a “file explorer” (Pedro)
    • user expects, the file opens – something new happens.
  • May be needed inside the Nextcloud server – not in richdocuments (Julius)
  • Update: Discussion in our weekly meeting with designers
    • We’ll as a first step look into making ctrl click/middle mouse click/back buttons in the browser work/behave correcly
• WASM
  • WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
    • richdocuments pull request ready, what version is wasm expected for?
    • No pressing needs, let’s just merge this for main branch

Nicolas

• Nothing of relevance; in listening mode.

Online activity

• Bugs caught during this meeting

  • Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
    • Issue: AI(Pedro): To file bug

• Attila

  • working on Language change problems (sidebar, statusbar) Calc: Sidebar Changes Language · Issue #7492 · CollaboraOnline/online · GitHub
    Rewriting my last PR hopefully will be ready today:
    statusbar language fix: https://gerrit.libreoffice.org/c/core/+/160416
    Szymon helped me to find a other place for this fix:
    SfxBindings::Update_Impl
  • Started to work on a pptx import hyperlink problem:
    154248 – FILEOPEN PPTX: multiline field wrapping breaks rendering of links (and font changes)

• PRs without reviewer 5

  • Collabora Online · GitHub
    • Fix media request error by eszkadev · Pull Request #7473 · CollaboraOnline/online · GitHub

• Szymon

  • Working on view jumping
  • added fix for wrong user id after recover from idle
  • fetch fresh cursor data after idle in calc
  • looked at “Idle state” related bugs
  • Looked at annotations appearing in other views bug in calc/impress

• Darshan

  • View jump caused by Autofilter popup 7832 => In Review
    • Test other places where that class is used
  • WIP: Fix filter dialog usability issues in Calc
    • Fix position of filter by color dialog popup in Autofilter => Merged
    • Disable Select/Unselect-current Filter Checkboxes in Calc https://gerrit.libreoffice.org/c/core/+/160082 => Merged
    • Filter by color options in Auto filter is working now 7824=> Merged
      • If user clicks on checkbox filterByColor not getting applied we need to click on label for filtering. I am working on this problem to also work when use to check or uncheck the checkbox for filter by color option => WIP
    • Be consistent with LO for auto-filter popups. We need radio buttons for filter by color selection to be more consistent with LO => WIP
    • Child popup in auto-filter always comes to a fix place on screen ( on left side in middle of the screen ). it should not behave like this. Child-pop-ups should be positioned according to parent position.
    • Strange option Separator is added to widgetTree view of auto-filter. This case also needs to be handled from core side. As the Separator is not an entity it is just a visual representation. => Will start next
    • Small refactoring change for updating Calc header/row when mode change to Dark/Light 7827 => Merged

• Vivek

  • Work in progress - Scroll bar animation on mouse hover event (pause)
    • Calc: Implement JavaScript animation on mouse event by codewithvk · Pull Request #7218 · CollaboraOnline/online · GitHub
  • Comment dialogue looking odd in mobile view => In Review
    • Mobile: Insert comment layout is too narrow and doesn't occupy full height by codewithvk · Pull Request #7719 · CollaboraOnline/online · GitHub
  • Android Insert Cell Menu MissAligned Radio Button => In Review
    • Android: Insert Cells Menu Misaligned Radio Buttons by codewithvk · Pull Request #7736 · CollaboraOnline/online · GitHub
  • Many Icons Not Inverting Color In Dark mode cool-help => In Review
    • Fix: Many Icons Not Inverting Color In Dark mode cool-help by codewithvk · Pull Request #7796 · CollaboraOnline/online · GitHub
  • WIP - Async more dialogs
    • Draft : https://gerrit.libreoffice.org/c/core/+/160557
  • Not Started - wasteful commandvalues CharFontNAme

• Michael / Caolan – Performance

  • missing tile updates #1
    • Sometimes we only request two rows of tiles in writer on an initial load by caolanm · Pull Request #7760 · CollaboraOnline/online · GitHub (merged)
  • various view id problem pr to review and consider
    • fix: tiles not updated after reconnection by Rash419 · Pull Request #7780 · CollaboraOnline/online · GitHub (merged)
    • Make sure to set the correct normalized view id for the tiles. by gokaysatir · Pull Request #7775 · CollaboraOnline/online · GitHub (merged)
    • And a mystery case of another apparent viewid mismatch with a single user and new calc document

• Testing results:

  • Dark mode now working nicely.
  • Found some good problems from calc:
    • generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
      • may be a red-herring.

• Bayram

  • Calc: groupping doesn't work · Issue #7369 · CollaboraOnline/online · GitHub - Calc: grouping doesn’t work #7369
    • Status: Fixed/Merged
    • Patch: Calc: make grouping responsive for each group level by bayramcicek · Pull Request #7722 · CollaboraOnline/online · GitHub - Calc: make grouping responsive for each group level #7722 : Gokay, Szymon
  • Working on Calc: sheet drop zone is too small · Issue #7813 · CollaboraOnline/online · GitHub - Calc: sheet drop zone is too small #7813
    • Almost done.

• Skyler

  • Got a few changes which need review, all tests have passed on all of them. Bold ones are more important
  • Calc keyboard popping down
    • Waiting for review on https://gerrit.libreoffice.org/c/core/+/160313 → someone to test it before merging it
    • May be nice to get another review on Stop onscreen keyboards closing when used to move by Minion3665 · Pull Request #7797 · CollaboraOnline/online · GitHub
  • Touchscreen fixes
    • Need reviews on Followup to unified touch handling by Minion3665 · Pull Request #7712 · CollaboraOnline/online · GitHub
    • May want second followup to investigate 2 more dubious lines from the first commit, out-of-scope for this followup as I think they’ll take longer than I want to wait to merge this

• Pranam

  • Revamp comment autosave feature
    • Reverted all the previous patches of the feature
    • More simple implementation using existing workflow
    • Hopefully will remove comment regressions
    • Then new cypress test for autosaved comments (multiple users) will also be needed

• Gökay

  • Working on a read only mode feature that will allow clicking on a hyperlink.
  • Will write unit tests for the solved issues.
  • Dark mode switch issue is waiting for a review.
    • Merged.
  • Ghost column when resizing browser window:
    • We couldn’t reproduce this.

• Hubert

  • Started some of the Draw (and by extension Impress) improvement work.
    • WIP Draft
      • draw: Added Grid and line helpers by hfiguiere · Pull Request #7786 · CollaboraOnline/online · GitHub – adding some of the missing UI for enabling Grid.
      • There is a core patch needed for the commandstate.
      • Dragging is 100% frontend side.

• Gulsah

  • Editing a cell without exiting the cell edit mode and then clicking the ‘+’ to insert a new sheet moves the entered content into that new sheet.

    • Fixed: Exit cell edit mode before add a new sheet by GulsahKose · Pull Request #7579 · CollaboraOnline/online · GitHub

    • Szymon suggested move solution to core so I did:

      • https://gerrit.libreoffice.org/c/core/+/160758

  • Overwrite follow up PR of configurable override mode

    • Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
      • I triggered the cypress test several time but failed on unrelated part.
      • Cypress tests locally failed too but couldn’t return back to work this.

  • Currently working on ““Download” and “Download as” are not working at all”

    • Fixed by Coalan’s commit: add hasWASMSupport to capabilities by caolanm · Pull Request #7784 · CollaboraOnline/online · GitHub

  • Calc: Columns and rows are not activated on mouseDown

    • I noticed that the problem is just latency, Actually activates but after than 5-8 sec later.
    • Debugging…

• Andras

  • No update

• Pedro

• Mike D

  • LanguageTool: a strange/interesting bug on LO. Will look into this.

Forum (Mike D)

7 posts happened this week (3 posts answered by me).

Key topics:

• New Topics:

• Set a default template

  • iOS + iPad: Set a Default Template
    • Is it possible?
    • I don’t think so, not yet. (Is it even possible on Online?)
  • Also, support OTT or DOTX files.
    • Probably nudge towards Github enhancement.

• Updates to Previous Topics:

• iOS iPad trackpad support? - #4 by Tex

  • Came back with more iPad + keyboard with trackpad info.
  • Logitech Combo Touch keyboard + iPadOS 17.1.1.
  • Might be some good hardware to get a dev/QA?
    • Skyler: I made a purchase request for an iPad with a keyboard and trackpad, maybe I could look at this when I get it
      • Skyler: Also, this sounds like the sort of thing that might have been fixed with my touch patches… testing on master would be excellent!
  • AI (Pedro): reach out and create staging accounts

• Grammar suggestions with LanguageTool aren't showing up in Nextcloud Office in Collabora 23.05.5.4 - #4 by Tex

  • User’s LanguageTool + Docker (NextCloud) isn’t working.
  • They just posted a backtrace after hitting “Spelling” button.

• Collabora admin login required after server restart - #3 by Lulina

  • Nextcloud + Collabora
  • Strange issue where they can’t open documents, but after logging into admin console, they can.

• Besides that, there were 3 more posts:

  • 2 where users posted help for steps where they got stuck.
  • 1 asking about IMPORTRANGE support again (Spreadsheets referencing cells in other documents)
    • Referencing ranges in other sheets - #5 by Rodal

9 → 11 - zero replies in user support:

→ User Support - Collabora Online

37 → 37 - zero replies in installation and config:

→ Installation & Configuration - Collabora Online

Next events

• COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – https://www.collaboraoffice.com/cool-days-2024/
• We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
  • What to do next
    • Passport & VISA
    • Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
    • Apply for a VISA if needed.
  • Register for the event: https://eventyay.com/e/0512424d
  • Submit a talk:
    • https://eventyay.com/e/0512424d/cfs

• Next meeting