Collabora Online Weekly Meeting #147
Date: Dec 07th 2023
All minutes published on: Topics tagged meeting-minutes
Please update your section
please update your section
Attendees (write your name):
- Anna, Ezinne, Caolán, Andras, Cosmin, Timur, Attila, Gulsah, Gökay, Darshan, Bayram, Hub, Aron, Mike D, Skyler, Michael, Vivek, Nicolas, Cosmin, Szymon, Pranam, Julius
Making the call shorter
- Please update your section relating in the document before we read through it.
- Then only go over anything we need to share / get input on
Release Schedule
- CODE 23.05.6 Week 50
- Right now: chasing all the blockers
- Tickets to be merged and tested
- Mobile releases
- iOS 23.05.6 Week 48 (?)
- Android 23.05.6 Week 48 (?)
- need to fix insert → comments on Mobile.
- iOS
- quick smoke-testing of new build looks good (Nicolas)
Julius
- New release pending for later today
- Spreadsheet status bar show by default
- Version access for shared files (server release 27.1.5 pending next Thursday)
- For Nextcloud 28 additional things landed (new major version coming next week)
- Improved setup checks to make setup errors easier to fix for admins
- Additional option to configure URL for internal communication between Nextcloud/online
- Sidebar concerns:
- [stable27] fix: Avoid triggering a defered sidebar open if openFile is already handling that by juliushaertl · Pull Request #41636 · nextcloud/server · GitHub merged
- Will be released with 27.1.5 next Thursday
- [stable27] fix: Avoid triggering a defered sidebar open if openFile is already handling that by juliushaertl · Pull Request #41636 · nextcloud/server · GitHub merged
- Open in new tab by default (?)
- UX testing feedback tells us that files in new tabs is a serious issue
- AI: share feedback with Julius (Pedro)
- Google opens in a new tab by default (Nicolas)
- A website that is an application: a “file explorer” (Pedro)
- user expects, the file opens – something new happens.
- May be needed inside the Nextcloud server – not in richdocuments (Julius)
- Update: Discussion in our weekly meeting with designers
- We’ll as a first step look into making ctrl click/middle mouse click/back buttons in the browser work/behave correcly
- WASM
- WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
- richdocuments pull request ready, what version is wasm expected for?
- No pressing needs, let’s just merge this for main branch
- WASM headers for online · Issue #3258 · nextcloud/richdocuments · GitHub
Nicolas
- Nothing of relevance; in listening mode.
Online activity
-
Bugs caught during this meeting
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
- Issue: AI(Pedro): To file bug
- Hyperlink preview glitching (keeps flickering). Check the web console, we keep receiving the same postmessage over and over
-
Attila
- working on Language change problems (sidebar, statusbar)
Calc: Sidebar Changes Language · Issue #7492 · CollaboraOnline/online · GitHub
2 PR under review:
general language fix: https://gerrit.libreoffice.org/c/core/+/160219
statusbar language fix: https://gerrit.libreoffice.org/c/core/+/160416
The statusbar miss localization is triggered by the core: timer event that check for status change.
I will test for other buggy cases, and try to fix create time problem, that may not result wrong localization now.
- working on Language change problems (sidebar, statusbar)
-
PRs without reviewer 8
-
Szymon
- Current: working on view jumping
- Added some warning dialogs for user, improved “info modals”
- Fixed opening file in richdocuments after rename in Collabora Online
- Found reason why “download xxx” doesn’t work recently – headers in requests
-
Darshan
- Make icon structure consistent 7711 => Merged
- Handle setImage icon cases for data.Icon and data.Image #7779 => Merged ( this PR is a fix for regression caused by 7711)
- Change checkbox state by click on checkbox label [7732](http:// Change checkbox state by click on checkbox label in Auto filter) => Merged
- WIP: Fix filter dialog usability issues in Calc
- Fix position of
filter by color
dialog popup in Autofilter => Merged - Disable Select/Unselect-current Filter Checkboxes in Calc https://gerrit.libreoffice.org/c/core/+/160082 => Merged
- Working on filter by color options are not filtering the column data.
- Fix position of
-
Vivek
- Work in progress - Scroll bar animation on mouse hover event (pause)
- Comment dialogue looking odd in mobile view => In Review
- Android Insert Cell Menu MissAligned Radio Button => In Review
- Many Icons Not Inverting Color In Dark mode cool-help => In Review
- WIP - Async more dialogs
- Not Started - wasteful commandvalues CharFontNAme
-
Michael / Caolan – Performance
- missing tile updates #1
- Sometimes we only request two rows of tiles in writer on an initial load by caolanm · Pull Request #7760 · CollaboraOnline/online · GitHub resize event during start (for review)
- various view id problem pr to review and consider
- fix: tiles not updated after reconnection by Rash419 · Pull Request #7780 · CollaboraOnline/online · GitHub
- Make sure to set the correct normalized view id for the tiles. by gokaysatir · Pull Request #7775 · CollaboraOnline/online · GitHub
- And a mystery case of another apparent viewid mismatch with a single user and new calc document
- missing tile updates #1
-
Testing results:
- Dark mode now working nicely.
- Found some good problems from calc:
- generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
- may be a red-herring.
- generic calc performance ticket · Issue #6893 · CollaboraOnline/online · GitHub – getTextSelection
-
Bayram
- Calc: groupping doesn't work · Issue #7369 · CollaboraOnline/online · GitHub - Calc: grouping doesn’t work #7369
- Patch: (Under review) Calc: make grouping responsive for each group level by bayramcicek · Pull Request #7722 · CollaboraOnline/online · GitHub - Calc: make grouping responsive for each group level #7722 : Szymon, Gokay
- Calc: Moving sheet changes active sheet for a split second
- Moving happens correctly, but it changes the view to the target tab and then back to the correct one (the one that was moved)
- The issue is not happening on the LO side
- Worked on that, commented my findings, couldn’t make more progress
- Next: I will work on the drag&drop functionality of the Calc tabs. It seems drop zone is very tiny, we need to do some improvements there.
- Calc: groupping doesn't work · Issue #7369 · CollaboraOnline/online · GitHub - Calc: grouping doesn’t work #7369
-
Skyler
- Touchscreen input fixes
- Finding some regressions, particularly on touch devices
- I think that we allowed these to be merged because of issues with testing mobile devices on cypress, so I’m looking into that too
- Some devices are being recognized as touch devices when they aren’t – according to reports this looks like some remote desktop/VM configurations can cause this, I haven’t yet been able to reproduce
- If you’re facing this, please let me know what your configuration is. Touch device detection is done by this snippet:
- Finding some regressions, particularly on touch devices
- Touchscreen input fixes
isTouchEvent: function(e) {
if (!e.pointerType) { return !(e instanceof MouseEvent); } return e.pointerType === ‘touch’ || e.pointerType == ‘pen’ || e.pointerType == ‘kinect’; }
so it would be particularly helpful if you could look at what the pointerType of your event is
-
Working on making the keyboard stay up when using it for navigation even when we know it’s an onscreen keyboard (and so don’t popup for everything)
- Have core & online patches, doesn’t yet work for multiple users (I think the core option is not per-view… looking at dark mode for inspiration)
- https://gerrit.libreoffice.org/c/core/+/160313
-
Pranam
- Revamp comment autosave feature
- Reverted all the previous patches of the feature
- More simple implementation using existing workflow
- Hopefully will remove comment regressions
- Then new cypress test for autosaved comments (multiple users) will also be needed
- Revamp comment autosave feature
-
Gökay
- Will write unit tests for the solved issues.
- Dark mode switch issue is waiting for a review.
- Will be working on:
- Ghost column when resizing browser window:
-
Hubert
- Started some of the Draw (and by extension Impress) improvement work
- WIP Draft
- draw: Added Grid and line helpers by hfiguiere · Pull Request #7786 · CollaboraOnline/online · GitHub – adding some of the missing UI for enabling Grid.
- 2 problems: The button does toggle the grid but the state isn’t reflected in the button or menu. Still on going investigation around state event and uno command
- WIP Draft
- Started some of the Draw (and by extension Impress) improvement work
-
Gulsah
-
Editing a cell without exiting the cell edit mode and then clicking the ‘+’ to insert a new sheet moves the entered content into that new sheet.
- Fixed: Exit cell edit mode before add a new sheet by GulsahKose · Pull Request #7579 · CollaboraOnline/online · GitHub
- I triggered the cypress test several time but failed on unrelated part.
- Cypress tests locally passed but didn’t pass the CI I’ll rebase my patch and let the szymon know.
- Fixed: Exit cell edit mode before add a new sheet by GulsahKose · Pull Request #7579 · CollaboraOnline/online · GitHub
-
And now working on overwrite follow up PR of configurable override mode
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
- I triggered the cypress test several time but failed on unrelated part.
- Cypress tests locally failed too but couldn’t return back to work this.
- Fixed: Disable overwrite mode in experimantal mode automatically. by GulsahKose · Pull Request #7614 · CollaboraOnline/online · GitHub → to review
-
Now working on this Writer→Sidebar→Area section “Thickness” button shows the dialog cut.
- Fixed. All patches are merged.
-
Currently working on ““Download” and “Download as” are not working at all”
- Setup nextcloud to test better. And detected Download as is working nice on online co-22.05 And found some clues when I compare the coolwsd.log. Continue to investigating…
-
-
Andras
- No update
-
Pedro
-
Mike D
- Right-Click > More Options = "Your Browser Has Very Limited Access to the Clipboard" · Issue #7747 · CollaboraOnline/online · GitHub
- Right-Click > More Options = “limited access to clipboard” popup.
- Seems like it was a “Paste Special” thing…
- Menu options might need removal?
- Ctrl+H Shortcut for "Find and Replace" does not work in all servers · Issue #7748 · CollaboraOnline/online · GitHub
- Ctrl+H does nothing! Should pop open “Find and Replace”.
- Another Find and replace issue: dialog comes up with text inserted by another user
- Timur
- Also retested old:
- iOS and Android app: Paste not possible in formula bar (except using additional software on some platforms) · Issue #1320 · CollaboraOnline/online · GitHub
- Android(/iOS?) Calc: Can’t paste into formula bar.
- Language tool: a strange/ interesting bug on LO. Will look into this.
- Right-Click > More Options = "Your Browser Has Very Limited Access to the Clipboard" · Issue #7747 · CollaboraOnline/online · GitHub
Forum (Mike D)
5 Forum posts + 3 Github this week.
Key topics:
- File - Send - Email. I don't have "Send" - #4 by Tex
- iOS: No “File > Send > Email as PDF”
- (I gave him workaround + told him to submit feature request to Github…)
- iPad mini: collabora office text/calc editing not working
- Someone on iPad Mini not working. iOS Keyboard appears, but they can’t type/edit spreadsheet.
- Current OS is iPadOS 15.8
- Collabora Office Version is 23.05.5.2
9 → 9 - zero replies in user support:
→ User Support - Collabora Online
37 → 37 - zero replies in installation and config:
→ Installation & Configuration - Collabora Online
Next events
- COOL Day 2024 – April 8 to 10, 2024, Cambridge, UK – COOL Days 2024 - 8-10 April - Cambridge, UK - Collabora Office and Collabora Online
- We are thrilled to announce COOL Days 2024, another exciting and enriching conference and team building event in the picturesque city of Cambridge!
- What to do next
- Passport & VISA
- Make sure you have a valid passport for travel (until at least 11th October 2024 to avoid any issues).
- Apply for a VISA if needed.
- Register for the event: https://eventyay.com/e/0512424d
- Submit a talk:
- What to do next
Next meeting
15/12/2023