Caolan
- do less writer comment measuring and positioning if notes
are not shown, which is the online case
- we still need to know where the text they are anchored to are
though so that still needs to be calculated
→ https://gerrit.libreoffice.org/c/core/+/155453
- mem leak in calc?
- how to reproduce? tried a few things but no definite leak
- scrolling in calc
- considered improved enough that it got closed
- calc comments, a lot moved into browser, but load is still
poor. Possibly we could support whatever it needed for import in
some caching object and leave turning it into a shape until we need
one of those. - fix crashtesting failure on kde114933-2.svg
- tdf#156677 make a testcase for a ScFormulaCell::MaybeInterpret
failure
→ https://gerrit.libreoffice.org/c/core/+/155463 semi-plausible fix
at least it illustrates the problem - tdf#156661 regression pinned on me
- do some more coverity warnings for online
- tdf#156611 some code review for
→ https://gerrit.libreoffice.org/c/core/+/155079 - debug calc html export potential leak
→ no sign of a leak for me but did see some autofill
drag down weirdness- debug calc autofill overlay, hidpi only issue
→ autofill onMouseDown doesn't generate working event position for hidpi by caolanm · Pull Request #7048 · CollaboraOnline/online · GitHub
- debug calc autofill overlay, hidpi only issue
- prototype deferring much of the work of loading xlsx comments
until we need them
→ looking for a good place to put something like that I find
something sort of similar exists, maybe we can adapt
whan exists there to what I want
→ then profile would look better, but OutputDevice::HasGlyphs then
appears a lot
→ https://gerrit.libreoffice.org/c/core/+/155569 to address that
→ what is the situation for export though?
ah export turns all such sort of deferred note objects
into real ones when we export which isn’t super great, but
at least can work out of the box - another round of coverity fixes for libreoffice
- defer loading xlsx comments until they are needed
→ https://gerrit.libreoffice.org/c/core/+/155613
Mike
— Cursor is not invalidated when pressing space in LOK
- Fix provided
— Writer: Crash when opening the attached ODT (debug build)
- Spent some time testing with master / co-23.05
— Writer: Keep ratio checkmark on sidebar should be set for images by default
- Investigated a bit
Paris
- Continued working on “Calc: Display first line in cell by default
when reading Excel file, roundtrip/editing case”- I have something locally that seems to work but I need to test it further
- I will have to look into not sending over the nviewid on tilecombine. Sending the id is (I think) useless anyway because it gets replaced with the actual id… also it used to be that always 0 is sent. So why is the nviewid section needed there? Need to investigate.
Tomaz
Finish document themes for Impress:
- adding ThemeDialog into impress
- refactored to use sd specific ThemeColorChanger, and removed the common (svx) ThemeColorChanger
- added changing of styles to ThemeColorChanger
- adding undo/redo support to ThemeColorChanger
- backporting to co-23.05
Miklos
- 155118 – Second part of multi-page floating tables “Second part of multi-page floating tables”
- see the bug for details