Collabora Online Weekly Meeting #101
Date: Dec 15 2022
All minutes published on: Meeting Minutes - Collabora Online
Attendees (write your name):
- Pedro, Szymon, Andras, Kendy, Nicolas, Gülşah, Gokay, Michael
Release schedule (Gokay)
- Next CODE 22.05 → week 50 → still valid
- Mobile app release was postponed for next year (probably between Jan-Mar)
Nextcloud bits (Julius)
-
Working on dropping an .ini file in top-level Nextcloud sync folders so that the desktop client can interact with locking / desktop / collaborative editing as the user chooses → waiting for desktop client team (richdocuments PR ready)
- planing call next week
- Tor working to read / interpret this and tweak the UI to better integrate
- some potential issues getting authentication tokens for LibreOffice – so deferring this ot the next step. (ping the user on the local side that there is a possibility to keep editing the same document collaboratively )
- Julius talking to client team about auth issues.
- Expose a ini file for edit online in Collabora Office / LibreOffice · Issue #4880 · nextcloud/desktop · GitHub
-
ctrl + F used to trigger the search input field (even when bottom status bar is hidden) and now it doesn’t (probably only for read-only mode) → AI: create task
-
Copy while in read only mode → AI: create task
-
Edit local icon on the compact view might be misplaced
- Should probably be in save/print group instead of redo/undo
- Pull request merged Adjust local editing button position in tabbed view
-
User mentions pull request is in progress Implement user mentions API by Raudius · Pull Request #2576 · nextcloud/richdocuments · GitHub
- Still needs some fixes regarding public shares when fetching the user list
- Improved and already merged
-
Rashesh’s PR mention: send a postMessage to integrator when username is selected I also merged
Nicolas (Adfinis → DeepL)
- Kendy: Working already on the blog post, it should be ready soon.
Forum (Pedro)
- This year we had activity every single week
- Jumping cursor
- Rodrigo willing to try to help if it’s not fixed already
-
Szymon’s patch → waiting for review, it already passed all tests → now merged
- AI: Ezinne to double check
- Look into coolwsd crash related with fonts → pinged Tor. Answered , it seems to be system wide problem.
Dark mode
- AI: Pedro needs to rebase dark mode branch (and solve any conflicts coming from new sidebar work) , then ping Andreas K.
- Branch was very old and with multiple conficts. Branch rebased and now ready to receive Prs.
Gabriel
- Started to working on an new issue (found in 21.x version): It seems multiple savings (in unmodified documents) in between very short chunks of time (seconds)
- Aron: how do you monitor the status of the document? Is the save icon button showing that is saved? Sometimes we save due to stuff happening on the core side (even if there is no user modification); Gabriel: don’t know this was reported as in “documents are identical”
- It’s quite old version. I can check it quickly to see if there is any obvious cause.
- AI for Gabriel: Create a ticket with this info and maybe worth to mention Ash there.
GitHub activity (Pedro)
- Gulsah
- Chart size PPTX → Impress. Now working on this following Quikee code pointer → When we have auto layout somehow position and size is decided for the plot area → needs to find where this is happening. → Have a working solution but one test is not passing: 143179: Use same plot area distance with Microsoft Office → fixed but tests need to be updated. AI: Ping Quikee → Pedro: pinged Quikee, he will check the tests. Thanks!
- Now working on hyperlink issues (calc mobile)
- bug: Modifying hyperlink keeps existing hyperlink as well ; Already has a fix for that (core side)
- Still not pushed, found another related bug. Fixed!
- Actually 2 bugs. One fix (on core) is already merged; the other one (online) is pending
- Fix the insert hyperlink behaviour on Calc. by GulsahKose · Pull Request #5584 · CollaboraOnline/online · GitHub
- Freeze rows and columns issue on mobile (toggle is not easy to understand, checkmark is missing)
- Already fix, waiting for review: Set the checked state of the FreezePanes item by GulsahKose · Pull Request #5598 · CollaboraOnline/online · GitHub
-
User wants to have log out button on the admin console
- Easy hack WIP PR open to anyone : Add logout button to admin console by pedropintosilva · Pull Request #5416 · CollaboraOnline/online · GitHub we have discussed and yes this should get in. I have tried to remove the cookie from client side but I really don’t think it is possible because it seems that was created with httpOnly option. AI: Ping someone that can push server side commit into this PR [Gokay will look into this] so not that easy , Gokay already looking into this. Session logic needs to be added.
- Gokay: Working on the session logic. Already have a login page.
- Gokay: already improved, now we have a login page! Add logout button to admin console #5416 waiting review
Design bits (Pedro and others)
- Symon: Now new JSDialog type to be used for all warning dialogs. We can use to replace vex dialogs of these type. Now being used for hyperlink “leaving the editor” dialog (former vex dialog). The plan here is to start to replace vex dialogs one by one sequentially (so it’s better for QA/testing and less prone to regressions)
- As a collateral hyperlink “leaving editor” bugs were fixed (in some languages, text was above buttons etc)
- AI: Which is the next in line?
Other ongoing work
- Uses some interaction handling sync, not working at the moment
- WRT mentions Rash is trying to make ongoing mentions work
- Finalizing now: writer: introducing new mention feature by Rash419 · Pull Request #5093 · CollaboraOnline/online · GitHub
- A problem with component but not really related with mentions PR
- Raul: still working on the public share issue (nextcloud side). What about notifying the users? Probably not a high prio thing but worth chasing [done]
- Kendy: Ok, please report and we will look into that. But we also need to look further on how all that works on Calc and Impress
- Next → Discuss /test within richdocuments (NC), WIP
- Merged → AI (Julius/Raul) to check/test it
- mention: send a postMessage to integrator when username is selected i… by Rash419 · Pull Request #5334 · CollaboraOnline/online · GitHub
- Also for calc and impress: mention: enable in impress and calc by Rash419 · Pull Request #5317 · CollaboraOnline/online · GitHub
- Finalizing now: writer: introducing new mention feature by Rash419 · Pull Request #5093 · CollaboraOnline/online · GitHub
- WRT mentions Rash is trying to make ongoing mentions work
- Pranam & Szymon
- Improving bibliography on writer. Now commits are already on master.
- Pedro is now also on this
- Szymon: Dialogs got in
- Now working on enabling icons
- Would be useful for navigator (but still following object is a problem)
- Treeview widget now with sorting and filtering capabilities
- Now working on enabling icons
- Szymon:
- Line break fix for DeepL fixed, next → add test
- Found second case: selecting the new document → to do
- Fixed validation error in calc
- Jumping cursor
- Line break fix for DeepL fixed, next → add test
- Nick & Szymon
- Exporting as PDF dialog → async
- done and merged
- Now missing set password sub-sialog to be async : AI: Nick
- Szymon: Did a clean up
- Szymon: found out that the dialog was not fully async (but the solution was not far from ideal)
- Ongoing → epub export options, already async. Problem with everything getting deconstructed before we get the file out → following Szymon’s code pointers
- Exporting as PDF dialog → async
COOL Days 2023
- COOL Days 2023 - Cambridge, UK - Collabora Office and Collabora Online
- We have booked the beautiful Clare College on 28th and 29th March 2023, one of the many famous Cambridge Colleges for our next Collabora Online Conference.
- Book your seat, fill the form!
Next Meeting
5/1/2023