Weekly COOL meeting #99

[pedro.silva]

­Collabora Online Weekly Meeting #99

Date: Dec 1 2022

All minutes published on: Meeting Minutes - Collabora Online

Attendees (write your name):

• Ezinne, Pedro, Szymon, Thorsten, Aron, Kendy, Gokay

Release schedule (Gokay)

• Next CODE 22.05 → week 50
• Mobile app release was postponed for next year (probably between Jan-Mar)

Nextcloud bits (Julius)

• Working on dropping an .ini file in top-level Nextcloud sync folders so that the desktop client can interact with locking / desktop / collaborative editing as the user chooses → waiting for desktop client team (richdocuments PR ready)

  • planing call next week
  • Tor working to read / interpret this and tweak the UI to better integrate
  • some potential issues getting authentication tokens for LibreOffice – so deferring this ot the next step. (ping the user on the local side that there is a possibility to keep editing the same document collaboratively )
  • Julius talking to client team about auth issues.
  • Expose a ini file for edit online in Collabora Office / LibreOffice · Issue #4880 · nextcloud/desktop · GitHub

• Edit local icon on the compact view might be misplaced

  • Should probably be in save/print group instead of redo/undo
  • Pull request merged Adjust local editing button position in tabbed view

• User mentions pull request is in progress Implement user mentions API by Raudius · Pull Request #2576 · nextcloud/richdocuments · GitHub

  • Still needs some fixes regarding public shares when fetching the user list
  • Improved and already merged

• Rashesh’s PR mention: send a postMessage to integrator when username is selected I also merged

Forum (Pedro)

• Interesting request/idea on having dynamic footer/header (injecting content into document header and/or footer)
  • Answered: send SDK documentation and info about the postMessage URL
• JSsidebar generated html
  • Szymon: Nice, we can then test this with the gridhandler wha
  • jsdialog: simplify structure by eszkadev · Pull Request #5256 · CollaboraOnline/online · GitHub → Pedro needs to review it
  • Online and Core commits merged
  • Still some polishing o going, 1 PR to be reviewed
• Inserting shapes makes the session crash → very interesting
  • Ezinne: tested, it was reproducible, now tracking task

Dark mode

• AI: Pedro needs to rebase dark mode branch (and solve any conflicts coming from new sidebar work) , then ping Andreas K.

GitHub activity (Pedro)

• Gulsah
  • Chart size PPTX → Impress. Now working on this following Quikee code pointer → When we have auto layout somehow position and size is decided for the plot area → needs to find where this is happening. → Have a working solution but one test is not passing: 143179: Use same plot area distance with Microsoft Office → fixed but tests need to be updated. AI: Ping Quikee
  • Now working on hyperlink issues (calc mobile)
• User wants to have log out button on the admin console
  • Easy hack WIP PR open to anyone : Add logout button to admin console by pedropintosilva · Pull Request #5416 · CollaboraOnline/online · GitHub we have discussed and yes this should get in. I have tried to remove the cookie from client side but I really don’t think it is possible because it seems that was created with httpOnly option. AI: Ping someone that can push server side commit into this PR [Gokay will look into this] so not that easy , Gokay already looking into this. Session logic needs to be added.

Design bits (Pedro and others)

• Repair document dialog was not being translated → now fixed; AI: probably good to add some sort of easy hack on grep these things

• Sidebar improvements got in as well as part of the new grid layout

• Hyperlink contextual dialog improvements

• Spinfield fixes

• Symon: Now new JSDialog type to be used for all warning dialogs. We can use to replace vex dialogs of these type. Now being used for hyperlink “leaving the editor” dialog (former vex dialog). The plan here is to start to replace vex dialogs one by one sequentially (so it’s better for QA/testing and less prone to regressions)

  • As a collateral hyperlink “leaving editor” bugs were fixed (in some languages, text was above buttons etc)

Other ongoing work

• Uses some interaction handling sync, not working at the moment
  • WRT mentions Rash is trying to make ongoing mentions work
    • Finalizing now: writer: introducing new mention feature by Rash419 · Pull Request #5093 · CollaboraOnline/online · GitHub
      • A problem with component but not really related with mentions PR
      • Raul: still working on the public share issue (nextcloud side). What about notifying the users? Probably not a high prio thing but worth chasing [done]
        • Kendy: Ok, please report and we will look into that. But we also need to look further on how all that works on Calc and Impress
    • Next → Discuss /test within richdocuments (NC), WIP
    • Merged → AI (Julius/Raul) to check/test it
    • mention: send a postMessage to integrator when username is selected i… by Rash419 · Pull Request #5334 · CollaboraOnline/online · GitHub
    • Also for calc and impress: mention: enable in impress and calc by Rash419 · Pull Request #5317 · CollaboraOnline/online · GitHub
• Pranam
  • Improving bibliography on writer. Now commits are already on master.
• Szymon:
  • Vex replacement
  • Import text with symbols fixed
  • Line break fix for DeepL fixed, next → add test
• Nick
  • Exporting as PDF dialog → async
    • Fixed saving issue (missing compile flag)
    • Needs to save in the right location
    • Talked with Mert → probably better way to do the async part → implemented
    • File picker → we don’t have → need to figure out how to implement that
    • I got it rendering properly
    • Now working on the download part
    • Now everything is async but with that some additional problems appear
    • A lot of progrees, almost done: https://gerrit.libreoffice.org/c/core/+/140403 Expose PDF export online by NickWingate · Pull Request #5288 · CollaboraOnline/online · GitHub
    • Ongoing → epub export options, already async. Problem with everything getting deconstructed before we get the file out → following Szymon’s code pointers

COOL Days

• Probably tomorrow videos are already available on Youtube CollaboraOffice channel (all videos now available)
  • AI: Notify people (email etc)
  • AI: Create a new playlist with all the videos → Marc is on this
  • Videos already being uploaded (some already available)
    • Community pages were updated with COOL Days CTA → YT [done]
    • Slides repository was updated [done]
    • Plus add update to the Forum [done]
• Hacktoberfest → 1 PR got in → today shared in SM one of them
• Monthly crediting (translators) to be sent out today.

Next Meeting

08/12/2022