Collabora Online Weekly Meeting #15

Development Meeting Minutes
1

Collabora Online Weekly Meeting #15

Date: Mar 04, 2021

Next meeting: Mar 11, 2021

All minutes published on: https://forum.collaboraonline.com/c/news/meeting-minutes/14

Attendees:

  • Nicolas Christener, Muhammet, Pranam, Andras, Yunusemre, Gabriel Masei, Ezinne, Szymon, Michael, Gokay, Pedro, Kendy

Community update (Muhammet)

Template Contest (Nicolas)

  • 33 submissions, 10 really good

  • Wrote a blog-post, currently in review – to be published tomorrow

  • Heiko wrapped all the templates into extensions – which are now already published

  • One per template ? (Michael)

    • yes …

  • Perhaps need to put some more work into them to improve them

  • also to get them up-stream

  • What’s the l10n story ? (Michael)

    • a big issue; for now – no easy way to extract strings from template ↔ Weblate

    • need to do some homework here.

  • Localized templates – needed at TDF …

JSON Toolbar / Notebookbar changes (Szymon)

  • No updates since last week

Bind Mounting / Hard-linking (Gabriel)

  • Working on it right now – started this morning; nothing else too urgent today.

CanvasTileLayer bits (Gokay)

  • Finished working on CanvasTileLayer on master

  • are now porting to co-6-4 and testing to see if there are regressions

  • bug-fixing & patch-porting going on now.

  • Hope to have this released in CODE in around a week.

Icon theming (css class names) (Pedro)

  • Tested with SVG symbols in the past

  • Had a nice demo:

  • Now tested with ‘object’; ‘embed’ & ‘iframe’

    • all of these always show the first color – (Red)

    • sometimes the iframe / embedded look like they are instant

    • its not instant.

  • GetSVGDocument is deprecated now – can use contentDocument attribute instead

    • no difference in the result.

  • => We have to do server side variable/color substitution → which is easy enough.

  • Load the SVG symbols, and reference parts of it in other places.

  • We could do that on the backend / serving these potentially ? (Michael)

    • Nextcloud have their own SVG API – ask for icon+accent color – gives it back styled

    • SVG Symbol – the only way to do this – compatible with browsers.

Async Saving (Kendy)

  • Ash working on async save itself, and unit tests there.

  • Previously used a remote server that answered test as needed – but not great for CI

  • improving reliability with an own server with same http impl.

  • Considered some small python thing but, decided to use the same code.

  • Can we do that in-process in its own thread ? (Michael)

    • hopefully so (Kendy)

Release schedule bits (Andras)

  • Originally wanted to have CODE this week, looked plausible

    • now postponed to next week, and including more feature

  • Continuously releasing small / incremental fixes based on stable COOL for 6.4.6-

Status of JS to TS move, and request for a (bunch of) easyHack(s) (Muhammet)

  • Good commits from Gokay & Dennis here

  • Can we create an easy-hack for this ? To find leaf nodes & list them as easy-hacks ?

  • Possibly a short tutorial on how to convert? To be published on dev.to?

  • Might draw some attention of potential new contributors

    • “Improve your TypeScript skills with practice on Open Source Software…”

  • Sadly not as easy as that (Kendy)

    • in most cases we take a different approach, and obsoleting the leaflet bits

    • get rid of it in the end anyway, would be sad to convert & remove.

  • Need to search for that (Gokay)

    • may find some individual files, may be possible – but need to look at it.

Pull requests in need of attention (Kara)

  • Several from Andreas – waiting for some weeks

    • Pedro / Szymon – can you look and/or comment ?

  • Thanks for the poke – was not aware (Pedro)

    • eg. clone formatting in context menu (Kara)

      • not really waiting – comment from Szymon there.

    • Can ping Andreas by message, or jump in.

Next Meeting

Next meeting will take place on Thursday, Mar 11, 2021 at 11:00 am (UTC)

2

Here is the demo and I also added more options as requested by @kendy:
https://www.collaboraoffice.com/wp-content/uploads/2021/03/svg-theming.zip

bottom line is: the only way to avoid glitch (icons switching color on loading) and without using server side is using inline svg