Collabora Online Weekly Meeting #57
Date: Jan 27, 2022
Next meeting: 03/01/2022
All minutes published on: Meeting Minutes - Collabora Online
Attendees (write your name):
- Pedro, Szymon, Kendy, Gabriel, Michael, Gokay, Alexandru, Andreas K, Ezinne
Welcome breakage
- odd behaviour of welcome screen – Kendy filing a ticket.
Community update (Pedro)
GitHub activity:
- npm problem (discuss later)
- Can't compile : npm ERR! code EINTEGRITY · Issue #4008 · CollaboraOnline/online · GitHub
- Alexandro can’t join today (Gabriel)
- PR waiting for review
- The ability to process URLs for backend endpoints as well as user generated links inside documents:
- browser: add optional function to process the URLs (internal and user generated) by alessioalex-1and1 · Pull Request #4067 · CollaboraOnline/online · GitHub
- 2 user cases, when you interact with java app you need to carry that session id; another one is when users share links (and the need to check those urls for malicious stuff)
- related issue #4066 with more info
- Kendy: have you considered doing this for export (for example: for SVG) in the core side. Probably it would be easier (and it’s everything in one place)
- Michael: Yes that’s a really cool feature to do it upstream in the core side
- Probably what we want is a template
- Kendy: let’s not block this PR and instead add a follow up task to upstream that export side of the things. Plus there is already something for the export SVG in the core side (so probably not that difficult )
- Alex: Will create that follow up and ping Kendy; Gabriel I can also help if needed
- compatibility with master's new window.app.console logging. by mmeeks · Pull Request #4043 · CollaboraOnline/online · GitHub
- The ability to process URLs for backend endpoints as well as user generated links inside documents:
- New issues
- not that new: Glow & Soft Edge effect in slides doesn't seem to render correctly in higher zoom factors · Issue #4029 · CollaboraOnline/online · GitHub Aron already confirmed
- regression: Regression CODE 21.11.1.1 Calc: "Sticky" Comment Popups When Scrolling Sheet While Editing · Issue #4046 · CollaboraOnline/online · GitHub
- regression: Regression CODE 21.11.1.1 Calc: "Add Comment" Will Edit a Random Comment · Issue #4045 · CollaboraOnline/online · GitHub
- Android app doesn't show slides in presentation mode · Issue #4063 · CollaboraOnline/online · GitHub
Forum activity:
- Time to first response: Average time (in hours) of the first response to new topics:
- Problems creating new documents from custom ott template
- Julius is aware – on vacation for some time.
-
documents created from templates are broken and cannot be saved · Issue #1563 · nextcloud/richdocuments · GitHub
- Julius: pending PR on how we handle creation of documents from template Use FileCreatedFromTemplateEvent to inject the already existing empty templates by juliushaertl · Pull Request #1377 · nextcloud/richdocuments · GitHub…
-
documents created from templates are broken and cannot be saved · Issue #1563 · nextcloud/richdocuments · GitHub
- Julius is aware – on vacation for some time.
- Many topics solved and or answered
- registered vs anonymous → new contributors (in and outside of the forum )
C hat rooms
- “How to properly shutdown coolwsd, sending a SIGTERM at the moment, but JailUtil.cpp:removeJail() function doesn’t seem to be called during the shutdown.”,
- [ ] WRN Prisoner connection disconnected but without valid socket.| wsd/COOLWSD.cpp:2365
- [ ] ERR Failed to remove [/var/db/collaboraonline/child-roots/bndIp93Nj8SLgOf0] only: File not found| common/FileUtil.cpp:286
- Vmiklos: coolwsd.service explicitly sends a SIGINT, probably you should do the same
- sending SIGINT gives the same result.
- The cleanup procedure removes stuff from child-roots/ recursively. If name of the jail goes after “tmp”, things work, otherwise fail. Now the question is how to fix this properly.
Thanks to New contributors:
- stellarpower
- Emmy Denison
- grandinj
- tholewebgods → 6.4
Design bits (Pedro)
- Working on Infobar
- Michael: there are other info that we could put in later on
- Fixing regressions that creeped in
- Improving how document name shows (avoiding cropping for now reason) → remove ancient JS function that was setting hard coded pixels (not needed now)
- PR reviewing and helping
- Also some UI tweaking on going
- New undo/redo position, now in the home tab
- Notebook bar design refresh · Issue #1976 · nextcloud/richdocuments · GitHub
- Andreas
- First I would like to have everything in CSS vars and then we can keep going on that direction
- Context top toolbars
- Andreas: The PR is a redesign for how the whole context toolbar
- Andreas: I think the animation (slow) can be fixed if we do not redraw it
- Andreas: maybe better to do smaller steps
- Michael: every time we animate we potential stop to talk with the web socket. Wrong interactivity problems, etc.
- Mobile bottom context toolbar on Writer: Using table: we missing the split cell → Pedro will open issue
What we’re up to (Szymon)
- RTL: fixed formula bar
- There is another bug from core and it only happens in RTL mode
- when content has multiple lines
- There is another bug from core and it only happens in RTL mode
- Format of new paragraph body (regression)
- Fixed help links, we had incorrect urls
Schedule & update (Gokay)
- we released 2021-11 last week and we also released a minor release for 2021-11 this week.
- We released a minor release for co-6-4 yesterday
Nextcloud bits (Julius)
-
On vacation.
-
People trying to open CSV with COOL + Nextcloud (Pedro)
- used to be a problem with default mime-type
- registered to open with a text editor.
- Reverts back to open as text.
- Jan: “For sure, if Collabora is installed, makes much more sense to use that for opening CSV files. “
-
Limitation in files-app (Julius)
- user can’t specify a preferred order of openers
- have an enhancement request for richdocuments + server side.
- Register a preview provider for CSV files · Issue #1276 · nextcloud/richdocuments · GitHub
- Default mimetype actions · Issue #1400 · nextcloud/richdocuments · GitHub
-
Maintenance release of richdocuments with template fixes soon
-
regular calls with Pedro,
-
Looking at the notebookbar design – to see how we can improve that further
- seeing how we can make it fit into the NC design-language
- some findings – of duplicate hamburger / notebook-bar
1&1 bits (Gabriel)
- Created docker images to vanilla version for both versions (6.4 and 21.11)
- Feedback: The latest version (21.11) looks nice, specially looking at the sidebar
- Next week
- We will be testing 21.11 and then we will report back
- working on upgrade plans for next month decide on version
- What’s the version in staging
- not from a specific point branch but a snapshot from master with asan etc. turned on
- have a logging change from window.console.log (Alexandru)
- need to resolve conflicts – with some new commits.
- Inevitable with console.log (Michael)
- best not to override console.log on window
- makes sense.
- Alex: I have fixed those conflicts and I have pushed
- Now you can use the new app namespace to do that
- Michael: could you please review some of my patches just to avoid creating regression when backporting
- Alex: I think I already did. Plus if we want to disable that it’s possible
- Michael: compatibility with master's new window.app.console logging. by mmeeks · Pull Request #4043 · CollaboraOnline/online · GitHub , thanks!
Easy bug(s) (Pedro)
- I have been trying to add more easy hacks and I started again at it last week
Next Meeting
03/01/2022