Collabora Online Weekly Meeting #75

Collabora Online Weekly Meeting #75

Date: June 2 2022
All minutes published on: https://forum.collaboraonline.com/c/news/meeting-minutes/14

Attendees (write your name): 
    • Andras, Michael, Thorsten, Kendy, Rashesh, Nicolas, Gokay, Pedro, Rizal

Grammar checking (Kendy)
    • Mert is back; forward porting the work to master to include in 7.4
    • Started making it possible to configure via coolwsd.xml
    • Has to introduce some dependencies for this, same as for certificates
    • Think this is positive.
    • Q. about dialog for configuration → design team for checking
    • mostly done.
    • Mert onto DeepL integration soon
Gabriel (1-and-1)
    • Moving the last modified timestamp and save status to status bar : https://github.com/CollaboraOnline/online/pull/4531 
Welcome updates (Gokay)
    • Shipping the update details indirected via the server.
    • Working on TDF Help→About image download from coolwsd.
Forum (Pedro)
    • Checking posts >5 days old – Kubernetes & Nginx bits …
        ◦ poked people to help out.
    • Interesting report re: Android/tablet – a crash opening dialogs …
        ◦ Aron answered – user not able to get logcats …
        ◦ Possible duplicate:
            ▪ https://forum.collaboraonline.com/t/tablet-layout-on-huawei-tablet-not-working/1139 
        ◦ Pedro added instructions on logging app so we can get details.
        ◦ Would be good to have a topic on how to test & get logs to file issues.
    • Improved the spam filter for the forum
    • Improving our Kubernetes documentation would be good
        ◦ some questions in the forum there.
GitHub activity (Pedro)
    • Easy hack: Hunting & removing code related to the old formula bar:
        ◦ https://github.com/CollaboraOnline/online/issues/4821 
        ◦ good to get rid of this – now we’re JSDialog’ing
    • Another easy-hack:
        ◦ https://github.com/CollaboraOnline/online/issues/4792 
    • Contributors:
        ◦ a bunch of PR’s from Andreas K – reviewed them.
        ◦ Any story with tests failing ? …
            ▪ Szymon can look at it ?
    • JS Sidebar (Szymon)
        ◦ https://github.com/CollaboraOnline/online/pull/4776
        ◦ Simplify JS sidebar → tackles LTR/RTL problems …
            ▪ Miklos fixed some automation issue here
            ▪ re-based … Rashesh to look at cypress failure.
    • Dark Mode
        ◦ general dark mode issue https://github.com/CollaboraOnline/online/issues/4382 
            ▪ have a solution for rendering tiles (Kendy)
                • just needs implementing.
            ▪ Pranam on this – a JS piece that needs doing.
Deltas
    • Replicating bad core LOK rendering nicely in the client 
        ◦ performance not fantastic → need to poke at Tor’s perf. work …
Nextcloud bits (Julius)
    • Julius out.
    • Widget re-worked, no indicator to see which person you clicked to follow
        ◦ in the widget – when you press “follow someone” keeps following even if you edit
            ▪ should stop when you start to edit – as happens on a map.
    • Error duplicating a file within the same directory: https://github.com/nextcloud/richdocuments/issues/2092
        ◦ looked like the preview requests may have caused the file-locking
            ▪ clone & wait for the preview to render does it still occur ? Can we work around that ?
        ◦ Could we send a preview as we save ? (Michael)	
            ▪ added a built-in preview mechanism for ODF files
            ▪ Preview is/was kind of small …
                • could delay that (Michael)
            ▪ Can also find a way to make preview generation not lock files (Julius)
    • Font pieces:
        ◦ No update from Tor → now on holiday.
    • Desktop / PC locking / launching feature → next for Tor.
        ◦ Getting locking information and then we can discuss how CO can pick up those details 
    • Detecting guests form CheckFileInfo results ? (Michael)
        ◦ this is done – merged to richdocuments-nc and disables welcome for guests.
    • https://forum.collaboraonline.com/t/i-have-no-idea-why-this-is-happening-and-what-to-check-not-loading-on-some-clients/1115/5
        ◦ no post-message arrives to the Nextcloud side – not clear why.
Design bits (Pedro)
    • Improvements merged targetting the new formula-bar and some fixes.
    • Perhaps good to create new control on the JS-builder; now have two buttons
        ◦ thinking of creating a new control instead ? For expander on formular bar etc.
    • Content Controls
        ◦ four types are in – with native controls
        ◦ nearly complete: text-box, drop-down, insert-picture, a PR pending for date control too
        ◦ new ‘Forms’ tab on the tabbed view, where we can see those actions.
        ◦ Missing icons were added.
        ◦ Some tweaks for how the drop-down looks in the CSS (Pedro)
            ▪ AI: should create an easy hack for it. (Pedro)
        ◦ Need two more icons: for picture and date controls.
            ▪ Should be in LibreOffice core already ? (Rizal)
                • yes – just ping me to add them. 
        ◦ What is this for ? (Nicolas)
            ▪ a new way to fill forms in MS Office (Rashesh)
            ▪ can you save – having filled out – or some way to submit to a db ? (Nicolas)
                • no - eg. fill out CV / Resume templates (Gokay).
                • https://vmiklos.hu/blog/sw-content-controls2.html
            ▪ can we create PDF forms from it too ? (Nicolas)
                • this is a useful area – Evince really lacks these features
                • people need Acrobat – does magic with forms Evince can’t do.
    • Dark mode discussion: https://github.com/CollaboraOnline/online/issues/4382 
        ◦ We treat this as an extra attribute for normalized-views cf. Watermarks …
    • Mac testing appreciated for:
        ◦ https://github.com/CollaboraOnline/online/issues/4834
        ◦ independent of browser – dialog watermark doesn’t appear.
            ▪ pinged Aron.
    • Interested in navigation sidebar (Rizal)
        ◦ why did we disable this ? (Kendy)
            ▪ don’t think the reason would be collaborative editing
            ▪ problems with the presentaiton of the UI – JSDialogs ? …
            ▪ could it be the icon-tree ? (Michael)
            ▪ have a tree-view already in some dialogs (Pedro)
        ◦ checked and was hidden re: problems when we were pixel-routing the dialog (Kendy)
            ▪ perhaps it “just works”
    • Did you try gitpod Rizal ? (Pedro)
        ◦ if you have time - just ping Pedro & he can help.
        ◦ new contributors using gitpod – because it’s easier.
22.05 bits (Michael)
    • CODE beta release – needs more testing
        ◦ actively testing it internally … lets see.
    • Hope to release it in a couple of weeks if all is well.
Other ongoing work (Kendy)
    • Rash started working on @mentions – notification etc.
        ◦ adding the federated ID to the comment author – after the document is round-tripped.
    • Ash is working on video embedding / playback – some save issues.
    • Working on other bugs: crashes & problems related to tunnelled dialogs.
Deltas (Nicolas)
    • do we use PNG still ?
        ◦ No – using deflate underneath (Michael)
            ▪ but could use zstd underneath instead.
    • Playing with webp – but much better than PNG on size
        ◦ good balance between size & performance (Michael)
            ▪ should use zstd → 5x faster than deflate in the future.
            ▪ Hope it gets faster re: typing etc. (Nicolas)
                • much better than 2 years ago =)

Next Meeting
09/06/2022