Collabora Online Weekly Meeting #74
Date: May 19 2022
All minutes published on: Meeting Minutes - Collabora Online
Attendees (write your name):
- Pedro, Michael, Ezinne, Rashes, Szymon, Pedro, Aron,
Andras, Gokay, Kendy
Sidebar (Michael)
- showing up oddly – when people join ? Seems like some cross-talk.
- Need to port fix to master (Szymon)
Grammar checking (Kendy)
- Mert is on vacation, but 2 weeks before 7.4 deadline
- in time for inclusion there.
- Presented at the ESC – some good points
- should include a link to the privacy policy.
- General support for including it.
- Multiple colors got done too.
-
Next
- Testing dis-connect / re-connect etc. and thread hanging.
- Add an HTTP timeout on the request – and configure that.
- Including this into COOL & documenting it.
- Testing dis-connect / re-connect etc. and thread hanging.
Gabriel (1-and-1)
- Moving the last modified timestamp and save status to status bar : browser: add last modification and document status at the bottom by gmasei11 · Pull Request #4531 · CollaboraOnline/online · GitHub
- Conclusion:
- needs to be a switch we can enable / disable:
- one of the UI options we pass in – with options & colors.
- UI_Defaults the best way (Kendy)
- Theming of Collabora Online — SDK https://sdk.collaboraonline.com/ documentation (Pedro)
- No news – didn’t have time to work on this
- Conclusion:
- Improve group_download_as xml option (having the download options within a dropdown)
- icon shared with the UX team they’re happy with it.
- Need to have some time to get the PR in (Pedroforum-wise)
- would like to share the same drop-down logic from elsewhere
- discussed with szymon, looks ok, needs to be reviewed
- Alex moved from 1&1 from April 1st.
Welcome updates (Gokay)
- Still working on improvements – most will be in the next CODE release not this one.
- Still need to add a timer to spin the slides & close them automatically
- Should add a timer to other dialogues eg. update-check (Pedro)
Forum (Pedro)
- Interesting report re: Android/tablet – a crash opening documents …
- Aron answered – user not able to get logcats …
- Pedro added instructions on logging app so we can get details.
- Would be good to have a topic on how to test & get logs to file issues.
- Can't Open Files on Android version 9 Tablet - #4 by workyg
- Improved the spam filter for the forum
- Improving our Kubernetes documentation would be good
- some questions in the forum there.
GitHub activity (Pedro)
- Easy hack: Hunting & removing code related to the old formula bar:
- Remove unused CSS related to old formulabar · Issue #4821 · CollaboraOnline/online · GitHub
- good to get rid of this – now we’re JSDialog’ing
- PR with more improvements re: formula bar …
- Private/pedro/jsformulabar input height n width by pedropintosilva · Pull Request #4820 · CollaboraOnline/online · GitHub
- some other bits still need work but this improves things – re: alignments / height etc.
- Contributors:
- a bunch of PR’s from Andreas K – reviewed them.
- Any story with tests failing ? …
- Szymon can look at it ?
- Compat view / tabbed view icons: (from Andreas)
- Compact View isn't part of Sidebar, Statusbar by Andreas-Kainz · Pull Request #4782 · CollaboraOnline/online · GitHub
- a nice PR – fixes the order of the icons;
- had some discussions & changes there. Need to get them in.
- would like help to get the tests to pass …
- AI: help diagnose that (Rashesh)
- Remove CSS vars
- btns var color name fixes by Andreas-Kainz · Pull Request #4799 · CollaboraOnline/online · GitHub
- reviewed, approved – like help making tests pass too (Rashesh)
- merged it → couldn’t have caused problems.
- JS Sidebar (Szymon)
- jssidebar simplify by Andreas-Kainz · Pull Request #4776 · CollaboraOnline/online · GitHub
- Simplify JS sidebar → tackles LTR/RTL problems …
- ideally as a few smaller commits to understand it.
- Really helps to bisect / test each commit.
- CollboraOnline github.io security update
- Bump minimist from 1.2.5 to 1.2.6 in /themes/hugo-theme-chunky-poster by dependabot[bot] · Pull Request #40 · CollaboraOnline/CollaboraOnline.github.io · GitHub
- relates only to the community website – NPM dependency updated.
-
Dark Mode
- general dark mode issue Add a dark mode · Issue #4382 · CollaboraOnline/online · GitHub
- have a solution for rendering tiles (Kendy)
- just needs implementing.
- have a solution for rendering tiles (Kendy)
- general dark mode issue Add a dark mode · Issue #4382 · CollaboraOnline/online · GitHub
Deltas
-
was seeing half of something – missing content (Szymon & Pedro)
- was just hanging for a bit – then appeared correctly …
- related to multiple bullet removal (older issue prolly).
Nextcloud bits (Julius)
- Julius out.
- Widget re-worked, no indicator to see which person you clicked to follow
- in the widget – when you press “follow someone” keeps following even if you edit
- should stop when you start to edit – as happens on a map.
- in the widget – when you press “follow someone” keeps following even if you edit
- Error duplicating a file within the same directory: Copying a file and renaming it in the same directory · Issue #2092 · nextcloud/richdocuments · GitHub
- looked like the preview requests may have caused the file-locking
- clone & wait for the preview to render does it still occur ? Can we work around that ?
- Could we send a preview as we save ? (Michael)
- added a built-in preview mechanism for ODF files
- Preview is/was kind of small …
- could delay that (Michael)
- Can also find a way to make preview generation not lock files (Julius)
- looked like the preview requests may have caused the file-locking
- Font pieces:
- Tor working to fix font mgmt issues in live deployment
- Meeting – minutes in the forum:
- Desktop / PC locking / launching feature → next for Tor.
- Getting locking information and then we can discuss how CO can pick up those details
- Detecting guests form CheckFileInfo results ? (Michael)
- there is a ticket for that (Gokay)
Design bits (Pedro)
- Dialogs that are not JSDialogs, or Vex, some leaflet thing …
- eg. ‘Repair document’ dialog … problems with alignment / close button
- Can we list them ? (Michael)
- seems this repair thing is the last one … it is an overlay / popup etc. (Pedro)
- AI: can we turn this into an easy hack & close the topic (Michael)
- Dark mode discussion: Add a dark mode · Issue #4382 · CollaboraOnline/online · GitHub
- We treat this as an extra attribute for normalized-views cf. Watermarks …
- Added icons for missing content-controls
- had some inconsistencies with labelling, were getting them from UNO commands
- were getting big labels there which looked odd, now fixed & approved by Rashesh
22.05 bits (Gokay)
- CODE beta release for developers this week : ready today.
- Will announce tomorrow.
- Delta work got merged → and seems to (mostly) work.
Other ongoing work (Kendy)
- Rash working on Content Controls
- using JSDialog drop-down
- Rash started working on @mentions – notification etc.
- adding the federated ID to the comment author – after the document is round-tripped.
- Ash is working on video embedding / playback
- Working on other bugs: crashes & problems related to tunnelled dialogs.
Next Meeting
02/06/2022